New issue
Advanced search Search tips

Issue 866489 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Dictation: if focus changes, text is entered into both the original and new text fields

Project Member Reported by leberly@chromium.org, Jul 23

Issue description

Chrome Version:	69.0.3494.0 (Official Build) dev (64-bit)
CrOS Firmware Version:	Google_Eve.9584.160.0

Steps to repro:
# Enable Dictation via Settings > Manage Accessibility Features
# Open the browser with focus in the Omnibox
# Press ctrl + d to start dictating. 
# While speaking, press ctrl + n to open a new window, focus is in that Omnibox
Expected: either you keep dictating into the old focused area only or you start dictating in the newly focused area only
Actual: dictation is entered into both at the same time


 
Cc: -zhelfins@chromium.org
Labels: OS-Chrome
Owner: zhelfins@chromium.org
Status: Started (was: Available)
Labels: M69A11yTests
Cc: zhelfins@chromium.org
Labels: a11y-testers
Owner: ----
Status: Unconfirmed (was: Started)
As of Chrome version: 70.0.3536.0, Firmware Version: Google_Eve.9584.197.0, I cannot reproduce this issue. I believe https://chromium-review.googlesource.com/1187135 may have resolved it; can we verify that it seems be fixed?
I can reliably repro this by just manually clicking earlier in the sentence before the engine detects the end of utterance. Can provide video if requested.

Google Chrome	69.0.3497.58 (Official Build) beta (64-bit)
Revision	a9cbf3aa9b477cee35271ffd775b7e3a110662a3-refs/branch-heads/3497@{#784}
Platform	10895.33.0 (Official Build) beta-channel eve
Firmware Version	Google_Eve.9584.160.0
The version of Chrome you tested on doesn't have the change I listed. I'd appreciate if someone could test on canary, which should have the change at this point.
Labels: Needs-Feedback
Owner: zhelfins@chromium.org
Status: Assigned (was: Unconfirmed)
Google Chrome	71.0.3554.0 (Official Build) dev (64-bit)
Firmware Version	Google_Caroline.7820.384.0

Hi Zach,

I've since learned how to tell which version a fix will land into so I'll be sure to check on that build or higher before commenting on a fix verification. I see that my current version is greater than canary from the end of August. 

As for this bug, I can still reproduce it using the repro steps above. The dictation is still entered into both the new and old areas that had focus. 

Please let me know if there is anything else for me to try.

Thanks,

Laura 
Labels: -a11y-testers
Removing a11y-testers label, please put back on when you'd like us to verify again. 
Cc: lpalmaro@chromium.org
I think we need to clarify the intended behavior here. Laura A., do you have thoughts on what text should be entered where in this case?
Thanks, Zach! I would say we should either start dictating into the new area of focus (not the older one), OR we should end dictation and play the earcon to signal that it has stopped since focus moved. With the latter, the user could choose to start dictating again if they want, but we'd be using the action of moving focus as an indication that they are going to stop dictating. What do you think? 
Status: Started (was: Assigned)
Labels: -Needs-Feedback
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f26886bec8201953dd636eef41bfe851ee19664

commit 2f26886bec8201953dd636eef41bfe851ee19664
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Mon Nov 26 18:53:17 2018

Have Dictation stop when focus changes

With this change, Dictation stops listening when a new tab is opened, as
well as in most cases where focus changes between two text fields on a
page.

I will follow up on why it does not stop when using my minimal example
of two <input type='text'> tags (and nothing else).

Bug: 866489
Change-Id: Ib0a60dcb3b5871173bceeab9675491c81e72414d
Reviewed-on: https://chromium-review.googlesource.com/c/1347002
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#610899}
[modify] https://crrev.com/2f26886bec8201953dd636eef41bfe851ee19664/chrome/browser/chromeos/accessibility/dictation_chromeos.cc
[modify] https://crrev.com/2f26886bec8201953dd636eef41bfe851ee19664/chrome/browser/chromeos/accessibility/dictation_chromeos.h
[modify] https://crrev.com/2f26886bec8201953dd636eef41bfe851ee19664/chrome/browser/chromeos/accessibility/dictation_chromeos_browsertest.cc

Cc: -zhelfins@chromium.org
Owner: anastasi@google.com

Sign in to add a comment