Lack of test_driver.bless is blocking import |
||||
Issue descriptionFirst and (currently) last failed import: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21627 https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21648 Example failure of media/picture-in-picture/request-picture-in-picture.html: This is a testharness.js-based test. FAIL request Picture-in-Picture rejects when frame is detached promise_test: Unhandled rejection with value: object "TypeError: test_driver.bless is not a function" FAIL request Picture-in-Picture rejects with MediaStreams promise_test: Unhandled rejection with value: object "TypeError: test_driver.bless is not a function" Harness: the test ran to completion. This is another case of resources/ changes breaking import because we don't automatically update those. robertma@, do we have a tracking bug for that?
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d commit 4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d Author: Philip Jägenstedt <foolip@chromium.org> Date: Mon Jul 23 21:05:10 2018 Sync LayoutTests/resources/ with LayoutTests/external/wpt/resources/ Roll in the most recent version of: testharness.js, testdriver.js, idlharness.js. (webidl2.js has not changed in wpt) Bug: 866467 Change-Id: I5be57429726e2179e0482514158be0e5ec49be04 Reviewed-on: https://chromium-review.googlesource.com/1146804 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577252} [add] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https-expected.txt [add] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-expected.txt [add] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https-expected.txt [modify] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/http/tests/security/deprecated-subresource-requests-expected.txt [modify] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/resources/idlharness.js [modify] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/resources/testdriver.js [modify] https://crrev.com/4ed8d3b692fc700bc7ffc56ad7bca7331a18c74d/third_party/WebKit/LayoutTests/resources/testharness.js
,
Jul 24
Follow-up before closing this should be to fix the tests to not have duplicate test names.
,
Jul 24
,
Jul 27
,
Sep 25
foolip@ Did you have chance to look at this? Are we good to close this?
,
Sep 27
I had some follow up to do in #3, but the test no longer has duplicate subtest names: https://wpt.fyi/results/picture-in-picture/request-picture-in-picture.html?label=stable&aligned=true |
||||
►
Sign in to add a comment |
||||
Comment 1 by foolip@chromium.org
, Jul 23