New issue
Advanced search Search tips

Issue 866461 link

Starred by 1 user
Status: Verified
Owner:
ioanap@chromium.org
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add explanation text to save and update passwords infobar

Project Member Reported by ioanap@chromium.org, Jul 23 
Previously, the text explaining where passwords are saved for users that sync their passwords was included in the infobar title. Now that the titles have been shortened, this text should be added separately to the infobars.

Comment 1 by ioanap@chromium.org, Jul 25

Description: Show this description

Comment 2 by ioanap@chromium.org, Jul 26 

Screenshots
NewStringSave.png
50.4 KB View Download
NewStringUpdate.png
54.9 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22e7a31f5995de5244c471d5e4ec6f568f32c1a

commit b22e7a31f5995de5244c471d5e4ec6f568f32c1a
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Jul 27 13:11:09 2018

Add explanation text to save and update password infobars

Since the titles of the infobars have been shortened, the information
about where passwords are saved for syncing users is now added to the
body of the save and update passwords infobars.

Bug:  866461 , 862269
Change-Id: Ic1231b1d8daaaa4a7f53730540b79439121b3ab1
Reviewed-on: https://chromium-review.googlesource.com/1146759
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578617}
[add] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/android/java/src/org/chromium/chrome/browser/infobar/UpdatePasswordInfoBar.java
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/android/java_sources.gni
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/BUILD.gn
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/password_manager_infobar_delegate_android.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/password_manager_infobar_delegate_android.h
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/update_password_infobar_delegate_android.h
[add] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/password_manager/update_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/ui/android/infobars/save_password_infobar.cc
[add] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/ui/android/infobars/save_password_infobar.h
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/browser/ui/android/infobars/update_password_infobar.cc
[modify] https://crrev.com/b22e7a31f5995de5244c471d5e4ec6f568f32c1a/chrome/test/BUILD.gn

Comment 4 by ioanap@chromium.org, Jul 30

Labels: Merge-Request-69
Status: Fixed (was: Started)
This change uses already existing string resources and is needed to ensure completeness of the information communicated in the infobars.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc7d802ccd62914b14b9c8f1a6860b8dd744632f

commit bc7d802ccd62914b14b9c8f1a6860b8dd744632f
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jul 31 09:23:50 2018

[Merge M69]Add explanation text to save and update password infobars

Since the titles of the infobars have been shortened, the information
about where passwords are saved for syncing users is now added to the
body of the save and update passwords infobars.

Bug:  866461 , 862269
Change-Id: Ic1231b1d8daaaa4a7f53730540b79439121b3ab1
Reviewed-on: https://chromium-review.googlesource.com/1146759
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578617}(cherry picked from commit b22e7a31f5995de5244c471d5e4ec6f568f32c1a)
Reviewed-on: https://chromium-review.googlesource.com/1156365
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#265}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[add] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/android/java/src/org/chromium/chrome/browser/infobar/UpdatePasswordInfoBar.java
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/android/java_sources.gni
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/BUILD.gn
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/password_manager_infobar_delegate_android.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/password_manager_infobar_delegate_android.h
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/update_password_infobar_delegate_android.h
[add] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/password_manager/update_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/ui/android/infobars/save_password_infobar.cc
[add] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/ui/android/infobars/save_password_infobar.h
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/browser/ui/android/infobars/update_password_infobar.cc
[modify] https://crrev.com/bc7d802ccd62914b14b9c8f1a6860b8dd744632f/chrome/test/BUILD.gn

Comment 7 by aska...@chromium.org, Aug 1

Status: Verified (was: Fixed)
Verified new strings for save password and update password as in #2. In chrome 69.0.3497.24.
►

Sign in to add a comment