New issue
Advanced search Search tips

Issue 866453 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 860458

Blocking:
issue 801985



Sign in to add a comment

Pipe the instance_id field to the commit

Project Member Reported by melandory@chromium.org, Jul 23

Issue description

instance_id field should be added to the commit in order to have the reflection blocking.


https://chromium-review.googlesource.com/c/chromium/src/+/939824
 
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16e0196b3fdfb73e072f894cd56654ecfe26407f

commit 16e0196b3fdfb73e072f894cd56654ecfe26407f
Author: Tanja Gornak <melandory@chromium.org>
Date: Thu Oct 04 09:55:00 2018

[Tango->FCM] Set the client ID for new invalidator.

The InstanceID, provided by GCM will be used in order to identify the Sync
commit data to server.  The ID is needed for reflection blocking.
On the serverside the ID isn't stored, but thrown away once the pipeline identifies
where to send the invalidation.

BUG=801985,  866453 

Change-Id: If13432c30ba6284d5ff685a6ac86d5c399244c74
Reviewed-on: https://chromium-review.googlesource.com/c/939824
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596565}
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/fcm_invalidation_service.cc
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/fcm_invalidation_service.h
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/fcm_invalidation_service_unittest.cc
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/invalidation_prefs.cc
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/invalidation_prefs.h
[modify] https://crrev.com/16e0196b3fdfb73e072f894cd56654ecfe26407f/components/invalidation/impl/profile_invalidation_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment