New issue
Advanced search Search tips

Issue 866449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Add metric collection to the share button in the location bar

Project Member Reported by stkhapugin@chromium.org, Jul 23

Issue description

The location bar's share button has to collect the same metric as the toolbar share button. 
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42f02d90384e3fb427379cd86880282c4dbcae5d

commit 42f02d90384e3fb427379cd86880282c4dbcae5d
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 23 14:11:01 2018

[iOS] Record metric in the location bar share button.

Adds a histogram action recording on location bar share button tap. It
is the same histogram as for the share button in the toolbar.

Bug:  866449 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I89cef712fe6488619c88a35b5528924961d4835a
Reviewed-on: https://chromium-review.googlesource.com/1146727
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577167}
[modify] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm

Labels: Merge-Request-69
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 24

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kariahda@chromium.org
Kariah: this is a very small change for metrics collection. 
Unit tests? Also, is it possible to get canary verification on this?
We normally don't unit test trivial metrics collection. I don't know if the test team can verify metric collection without being attached to a debugger. 
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 27

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Manual approval
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d436cea9d837a273707e036adb7c1598bad519a

commit 4d436cea9d837a273707e036adb7c1598bad519a
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 30 08:48:45 2018

[iOS] Record metric in the location bar share button.

Adds a histogram action recording on location bar share button tap. It
is the same histogram as for the share button in the toolbar.

Bug:  866449 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I89cef712fe6488619c88a35b5528924961d4835a
Reviewed-on: https://chromium-review.googlesource.com/1146727
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577167}(cherry picked from commit 42f02d90384e3fb427379cd86880282c4dbcae5d)
Reviewed-on: https://chromium-review.googlesource.com/1154827
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#202}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/4d436cea9d837a273707e036adb7c1598bad519a/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm

Sign in to add a comment