New issue
Advanced search Search tips

Issue 866446 link

Starred by 1 user
Status: Assigned
Owner:
stkhapugin@chromium.org
Cc:
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
q4

Blocking:
issue 831506



Sign in to add a comment

Replace use of UITextFieldTextDidBeginEditingNotification with UITextFieldDelegate methods when OmniboxViewController is the textfield delegate.

Project Member Reported by stkhapugin@chromium.org, Jul 23 
Currently OmniboxViewIOS is the OmniboxTextFieldIOS' delegate, and OmniboxViewController needs to know about the textfield delegate events. As a temporary solution, UITextField's standard notification UITextFieldTextDidBeginEditingNotification is used instead of plumbing the delegate calls through multiple classes. 

Ideally OmniboxViewIOS should not need to be the textfield delegate, which will allow the view controller to become the delegate. However this is currently problematic since the pre-UI Refresh omnibox does not have a view controller and relies heavily on OmniboxViewIOS.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc

commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 23 13:29:18 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577161}
[modify] https://crrev.com/06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d73dbd650f80985ebb76c86e28af122f1901ab

commit f8d73dbd650f80985ebb76c86e28af122f1901ab
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jul 25 11:40:02 2018

Update omnibox clear button visibility on focus.

Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446,  865019 ,  865013 ,  864511 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577161}(cherry picked from commit 06ea7b0cc20ee7d53a8170d4b29c4403f6dd52bc)
Reviewed-on: https://chromium-review.googlesource.com/1150100
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#66}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/f8d73dbd650f80985ebb76c86e28af122f1901ab/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
►

Sign in to add a comment