Delete ('x') button is not seen for dark background themes.
Reported by
shruti.j...@etouch.net,
Jul 23
|
||||||||||
Issue descriptionChrome Version:70.0.3500.0 (Official Build) Revision 19fb8c745affb4c0f621296e66bac6094e692076-refs/branch-heads/3500@{#1} (64-bit) OS: Windows(7,8,8.1,10) Pre-condition:Enable 'use-google-local-ntp ,ntp-icons' from chrome://flags. Test-URL:https://chrome.google.com/webstore/detail/charlotte-ronson/obakimnhgahiedhcjlcnohielmendpen?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome and open NTP. 2.Press Tab and Bring focus and observe delete ('x')button of thumbnails. Actual Result :Delete ('x') button is not seen for dark background themes. Expected Result :Delete ('x') button should be seen properly for dark background themes. This is a Non-regression issue seen from ‘M-68’ series. Kindly review the attached screen-cast . Thank You!
,
Jul 23
This is a non-regression dating to well before 68. Leaving this for after birthday.
,
Jul 31
,
Aug 22
This may just require applying the same change that works for custom backgrounds.
,
Aug 22
,
Aug 22
This one is depending on the heuristic to detect it is a dark theme or not. For those theme that our heuristic can detect it as a dark theme, the three-dot menu will be in white color. Unless we can have a better heuristic, this bug may not have a easy way to solve.
,
Aug 27
,
Oct 1
Unassigning this for now; it'll make sense to review this along with the larger Themes work.
,
Oct 1
,
Nov 12
@bklmn: Can we apply the shadow strategy suggested in https://crbug.com/874325#c5 to the 3 dot menu here? In the attached screenshot, the custom link text is more legible than the 3 dot menu.
,
Nov 12
I think that makes sense. Im thinking we can use the shadow styling behind the shortcut text...can we try that and see how it looks via screenshot?
,
Nov 14
The edit menu icon was brightened to white in https://chromium-review.googlesource.com/c/chromium/src/+/1335027, which makes it slightly easier to see on multi-colored backgrounds: - Before: https://screenshot.googleplex.com/Agf1nZaxwwP.png - After: https://screenshot.googleplex.com/fPZmseG3LyN.png It'll still be good to explore the drop shadow since white is still a bit difficult to see on light backgrounds.
,
Nov 14
@bklmn: this is targeted for a starter-bug. Will update with a screenshot once they're ready to start on it. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yyushkina@chromium.org
, Jul 23Components: UI>Browser>Themes