New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866439 link

Starred by 2 users
Status: Fixed
Owner:
yamaguchi@chromium.org
Closed: Jul 31
Cc:
tetsui@chromium.org
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary 'Sign in to another user...' tool tip is seen at Uber Tray

Project Member Reported by mmanchala@chromium.org, Jul 23 
Chrome Version: 70.0.3499.0/10902.0.0 dev channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
1) Sign in to user(Ex:A account) -> logout -> sign in to another user(Ex:B account) -> Go to Uber tray -> click on user I'd -> observe 'Sign in to another user...' option is seen for Multiple sign-in
2)Now hover mouse pointer on option and observe unnecessary 'Sign in to another user...'  tool tip
(Please refer Video and Screenshot)
 
Expected: Unnecessary 'Sign in to another user...'  tool tip should not be seen 
Actual: Instead unnecessary 'Sign in to another user...'  tool tip is seen

This is a Regression issue as issue is working fine in 69.0.3457.0/10784.0.0 dev-channel Reks

@tetsui : please confirm the Issue
Actual_UnnecessaryTooltip.mp4
5.2 MB View Download
Actual_UnnecessaryTooltip.jpg
1.3 MB View Download
Expected_NoTooltip.mp4
6.4 MB View Download

Comment 1 by tetsui@chromium.org, Jul 27

Cc: -ajha@chromium.org yoshiki@chromium.org tetsui@chromium.org
Owner: yamaguchi@chromium.org
yamaguchi@: Could you take a look? Thank you.

Comment 2 by yamaguchi@chromium.org, Jul 27

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28b0d99bbfa283b3b587f844b040b31db24d47c

commit b28b0d99bbfa283b3b587f844b040b31db24d47c
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Jul 31 08:13:34 2018

Show tooltip of a button only when text is truncated.

Tooltip is not needed for the "sign in another user..." button because
it's same as the label itself. The default behavior of the label can add
tooltip with the label text only when the label is truncated.

Test: manual
Bug:  866439 
Change-Id: I4dee9ea44b751d64f07b0458311a653bffb0a283
Reviewed-on: https://chromium-review.googlesource.com/1152644
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579343}
[modify] https://crrev.com/b28b0d99bbfa283b3b587f844b040b31db24d47c/ash/system/unified/user_chooser_view.cc

Comment 4 by yamaguchi@chromium.org, Jul 31

Status: Fixed (was: Started)
►

Sign in to add a comment