New issue
Advanced search Search tips

Issue 866433 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add use counters for RTCRtpTransceiver

Project Member Reported by hbos@chromium.org, Jul 23

Issue description

APIs of interest to track usage:
- RTCPeerConnection.getTransceivers()
- RTCPeerConneciton.addTransceiver()
- RTCRtpTransceiver.direction (getter/setter)

Transceivers just shipped in M69. Let's get [Measure] of them merged into M69.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c

commit b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c
Author: Henrik Boström <hbos@chromium.org>
Date: Mon Jul 23 16:04:02 2018

Add [Measure] to RTCRtpTransceiver APIs.

Measures usage of the following APIs:
- RTCPeerConnection.getTransceivers()
- RTCPeerConneciton.addTransceiver()
- RTCRtpTransceiver.direction (getter/setter)

// The run was green except for unrelated failures with
// mac_chromium_rel_ng that have happened on multiple CLs
NOTRY=True

Bug:  866433 
Change-Id: I430680fa3109681c38e82a7b8d2203e7ec18544e
Reviewed-on: https://chromium-review.googlesource.com/1146659
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577179}
[modify] https://crrev.com/b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.idl
[modify] https://crrev.com/b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.idl
[modify] https://crrev.com/b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c/tools/metrics/histograms/enums.xml

Labels: Merge-Request-69
Requesting b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c be merged into M69.
pls apply appropriate OSs label. Thank you.
Labels: OS-Android OS-Linux OS-Mac OS-Windows
Cc: benmason@chromium.org
Labels: -Merge-Request-69 Merge-Approved-69
Pls merge you change to M69 branch 3497 latest by 2:00 PM PT today so we can pick it up for tomorrow's M69 Dev release. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923b97264cb649b40746bb2876fcde7deb0b1a32

commit 923b97264cb649b40746bb2876fcde7deb0b1a32
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Jul 25 07:03:54 2018

Add [Measure] to RTCRtpTransceiver APIs.

Measures usage of the following APIs:
- RTCPeerConnection.getTransceivers()
- RTCPeerConneciton.addTransceiver()
- RTCRtpTransceiver.direction (getter/setter)

// The run was green except for unrelated failures with
// mac_chromium_rel_ng that have happened on multiple CLs
NOTRY=True
TBR=hbos@chromium.org

(cherry picked from commit b5b7d1a13bda0aace4dc1b83d07ce66d5a2be25c)

Bug:  866433 
Change-Id: I430680fa3109681c38e82a7b8d2203e7ec18544e
Reviewed-on: https://chromium-review.googlesource.com/1146659
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577179}
Reviewed-on: https://chromium-review.googlesource.com/1149362
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#63}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/923b97264cb649b40746bb2876fcde7deb0b1a32/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/923b97264cb649b40746bb2876fcde7deb0b1a32/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.idl
[modify] https://crrev.com/923b97264cb649b40746bb2876fcde7deb0b1a32/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.idl
[modify] https://crrev.com/923b97264cb649b40746bb2876fcde7deb0b1a32/tools/metrics/histograms/enums.xml

Status: Verified (was: Started)

Sign in to add a comment