New issue
Advanced search Search tips

Issue 866420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Focus doesn't traverse through close (X) button on 'Select a destination' overlay.

Reported by dchau...@etouch.net, Jul 23

Issue description

Chrome Version: 70.0.3500.0 (Official Build) Revision	19fb8c745affb4c0f621296e66bac6094e692076-refs/branch-heads/3500@{#1} 32/64-bit.
OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04).

Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage.
2. Click on 'Change' button under 'Destination' section to open 'Select a destination' overlay.
3. Now multiple times press 'Tab' key from keyboard and observe the focus on close (X) button at bottom right corner.

Actual: Focus doesn't traverse through close(X) button.
Expected: Focus should traverse through close(X) button.

This is a non-regression issue, seen from M-66 series as close button is introduced from build # 66.0.3352.0 in new Print Preview UI.

NOTE: This issue is also reproducible on Stable #67.0.3396.99, Beta #68.0.3440.68 & Dev #69.0.3493.3

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
1.3 MB View Download
Status: Untriaged (was: Unconfirmed)
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ced16a323f59238f78fdd6e743506a0fb34cf721

commit ced16a323f59238f78fdd6e743506a0fb34cf721
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jul 24 16:50:16 2018

Print Preview Componentization: promo close button fixes

Make sure the promo close button is in the tab order, and shows the
correct image when focused with the keyboard.

Bug:  866420 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id8054203f5917fc72f187c33a826d29817fd3b18
Reviewed-on: https://chromium-review.googlesource.com/1147254
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577579}
[modify] https://crrev.com/ced16a323f59238f78fdd6e743506a0fb34cf721/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/ced16a323f59238f78fdd6e743506a0fb34cf721/chrome/browser/resources/print_preview/new/destination_dialog.js

Labels: TE-Verified-M70 TE-Verified-70.0.3503.0
Update:
Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04) machines using latest canary #70.0.3503.0 and issue is fixed. Hence adding TE-Verified labels.

please refer below attached screen-cast for reference.

Thank You.
Fixed_behavior.mp4
636 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment