New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866412 link

Starred by 2 users
Status: Fixed
Owner:
shenghao@chromium.org
Closed: Aug 14
Cc:
█ lnishan@chromium.org
cindyb@chromium.org
ajha@chromium.org
jcliang@chromium.org
y...@chromium.org
mkarkada@chromium.org
henryhsu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Non-Regression: Unable to perform any operations in Camera app of Guest user

Project Member Reported by rkalavakuntla@chromium.org, Jul 23 
Chrome Version: 70.0.3499.0/10902.0.0 dev channel Daisy,Kip,Reks
OS:chrome OS

What steps will reproduce the problem?
(1)Open Guest user >> Go to App launcher and observe Camera icon
(2)Click it to Open and observe 

Actual: Unable to perform any operations in Camera app,only webstore page is seen opened 
Expected: On clicking on Camera icon,Camera should open 

Raising this as a new Non-Regression issue seen from M-70.

Attached the sreencast for reference..

Note: Issue is specific to Guest user, Camera app in Signed in user is working fine.
Actual.mp4
7.1 MB View Download

Comment 1 by rkalavakuntla@chromium.org, Jul 23 

Note:
-----
1.Context menu is seen missing for Camera app in both Guest and Signed in user
2.Able to do other operations in Camera app of Signed user
3.Unable to perform any operations in Camera app of Guest.

Comment 2 by y...@chromium.org, Jul 23

Cc: jcliang@chromium.org shenghao@chromium.org lnishan@chromium.org henryhsu@chromium.org

Comment 3 by shenghao@chromium.org, Jul 23 

This is an expected behavior. In guest mode, extensions, including CCA, are not available. The persistent camera icon therefore brings up the CWS page.

Comment 4 by shenghao@chromium.org, Jul 25

Status: WontFix (was: Untriaged)

Comment 5 by rkalavakuntla@chromium.org, Jul 25

Cc: -shenghao@chromium.org
Owner: shenghao@chromium.org
Status: Assigned (was: WontFix)
As per C #3 
In guest mode, extensions, including CCA, are not available.
Hence,re-opening the issue as unnecessary Camera icon is seen in App launcher seen of Guest user.

Thanks!

Comment 6 by sdantul...@chromium.org, Jul 31

Labels: ReleaseBlock-Stable
Same issue observed on M69 10895.10.0, 69.0.3497.21

Comment 7 by abodenha@chromium.org, Aug 1

Labels: Pri-1
Release blockers should be P1 or P0
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c2fe50bd308e8179c000995cc2d1c996c3c699

commit d7c2fe50bd308e8179c000995cc2d1c996c3c699
Author: Sheng-Hao Tsao <shenghao@google.com>
Date: Tue Aug 07 11:55:16 2018

Don't show camera icon in guest mode

This CL hides camera icon of internal camera app in guest mode. Since
extensions are not allowed in guest mode, users can't perform any
actions after clicking on the camera icon.

Bug:  866412 
Test: Tested on eve that there's no camera icon in guest mode.
Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570
Reviewed-on: https://chromium-review.googlesource.com/1152147
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Cr-Commit-Position: refs/heads/master@{#581198}
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/d7c2fe50bd308e8179c000995cc2d1c996c3c699/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Comment 9 by shenghao@chromium.org, Aug 7

Labels: -M-70 M-69 Merge-Request-69
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365459231738b45112c68997911b31c41904899a

commit 365459231738b45112c68997911b31c41904899a
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 07 20:08:15 2018

Revert "Don't show camera icon in guest mode"

This reverts commit d7c2fe50bd308e8179c000995cc2d1c996c3c699.

Reason for revert: Breaks the ASAN bots. Details in the followup email to this revert CL.

Original change's description:
> Don't show camera icon in guest mode
> 
> This CL hides camera icon of internal camera app in guest mode. Since
> extensions are not allowed in guest mode, users can't perform any
> actions after clicking on the camera icon.
> 
> Bug:  866412 
> Test: Tested on eve that there's no camera icon in guest mode.
> Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570
> Reviewed-on: https://chromium-review.googlesource.com/1152147
> Reviewed-by: Tatiana Gornak <melandory@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
> Cr-Commit-Position: refs/heads/master@{#581198}

TBR=stevenjb@chromium.org,melandory@chromium.org,shenghao@google.com

Change-Id: Iae87ba198da16262d6c7a79527234051994a54ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866412 
Reviewed-on: https://chromium-review.googlesource.com/1165962
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581321}
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/365459231738b45112c68997911b31c41904899a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 8

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by shenghao@chromium.org, Aug 9 

I have prepared the reland CL, which is undergoing CQ:
https://chromium-review.googlesource.com/c/chromium/src/+/1167147

Only the reland CL needs to be merged to M69.

Comment 13 by shenghao@chromium.org, Aug 9

Cc: cindyb@chromium.org
cindyb@, could you take a look?

Comment 14 by cindyb@chromium.org, Aug 9

Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db29fe046431076c3abf5af096eeb94e5acec4eb

commit db29fe046431076c3abf5af096eeb94e5acec4eb
Author: Sheng-Hao Tsao <shenghao@google.com>
Date: Fri Aug 10 09:06:17 2018

Reland: Don't show camera icon in guest mode

This CL relands "Don't show camera icon in guest mode", which was
reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1165962

Original description:

This CL hides camera icon of internal camera app in guest mode. Since
extensions are not allowed in guest mode, users can't perform any
actions after clicking on the camera icon.

TBR=stevenjb@chromium.org,melandory@chromium.org

Bug:  866412 
Test: Tested on eve that there's no camera icon in guest mode.
Change-Id: Ia033c0899c5d23005c1c4779d20aff72f9a91501
Reviewed-on: https://chromium-review.googlesource.com/1167147
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582096}
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/db29fe046431076c3abf5af096eeb94e5acec4eb/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 13 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 14

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c

commit c2e1cdf3a41881b93997e0ea5571b8f457e29b2c
Author: Sheng-Hao Tsao <shenghao@google.com>
Date: Tue Aug 14 07:44:25 2018

(Merge-to-69) Reland: Don't show camera icon in guest mode

This CL relands "Don't show camera icon in guest mode", which was
reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1165962

Original description:

This CL hides camera icon of internal camera app in guest mode. Since
extensions are not allowed in guest mode, users can't perform any
actions after clicking on the camera icon.

TBR=stevenjb@chromium.org,melandory@chromium.org

(cherry picked from commit db29fe046431076c3abf5af096eeb94e5acec4eb)

Bug:  866412 
Test: Tested on eve that there's no camera icon in guest mode.
Change-Id: Ia033c0899c5d23005c1c4779d20aff72f9a91501
Reviewed-on: https://chromium-review.googlesource.com/1167147
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582096}
Reviewed-on: https://chromium-review.googlesource.com/1174075
Cr-Commit-Position: refs/branch-heads/3497@{#612}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/c2e1cdf3a41881b93997e0ea5571b8f457e29b2c/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Comment 18 by shenghao@chromium.org, Aug 14

Status: Fixed (was: Assigned)

Comment 19 by hsiangc@chromium.org, Sep 7

Cc: mkarkada@chromium.org
►

Sign in to add a comment