Print Destination does not get selected from list on pressing Enter
Reported by
vineetha...@etouch.net,
Jul 23
|
||||||
Issue descriptionChrome Version: 70.0.3500.0 (Official Build) Revision 19fb8c745affb4c0f621296e66bac6094e692076-refs/branch-heads/3500@{#1}(32/64 bit) OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) Pre-conditions: Enable 'Enable new Print Preview UI' flag under chrome://flags What steps will reproduce the problem? (1) Launch Chrome open NTP and give print command using 'Ctrl+P' to open Print Preview overlay. (2) Click on 'Change' button to open 'Select a destination' overlay. (3) Now press tab to traverse through the list under Recent/Print Destinations. (4) Press Enter for any option under the list and observe. Actual : On pressing Enter, the entry for destination does not get selected instead print command gets executed and print overlay gets closed. Expected: On pressing Enter, the selected entry under Recent/Print Destinations should be chosen and shown as 'Destination' on Print overlay. This is a non-regression issue, seen from M67, since tab focus started traversing through the Recent/Print Destinations from build #69.0.3482.0 Note: Issue is not reproduced with mouse click.
,
Jul 23
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f423a15c1f856ed9689eca9ce1953dfc9c188990 commit f423a15c1f856ed9689eca9ce1953dfc9c188990 Author: rbpotter <rbpotter@chromium.org> Date: Wed Jul 25 22:02:16 2018 Print Preview Componentization: Select destinations on enter key press Bug: 866411 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2212f483c569b5633adcaf9c304b0100a6828139 Reviewed-on: https://chromium-review.googlesource.com/1147204 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578088} [modify] https://crrev.com/f423a15c1f856ed9689eca9ce1953dfc9c188990/chrome/browser/resources/print_preview/new/destination_list.html [modify] https://crrev.com/f423a15c1f856ed9689eca9ce1953dfc9c188990/chrome/browser/resources/print_preview/new/destination_list.js [modify] https://crrev.com/f423a15c1f856ed9689eca9ce1953dfc9c188990/chrome/test/data/webui/print_preview/destination_list_test.js [modify] https://crrev.com/f423a15c1f856ed9689eca9ce1953dfc9c188990/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
,
Jul 26
Verified this on current Canary 70.0.3503.0 on Windows 10 - destinations are now selected on pressing Enter. This behavior is very important for accessibility, as destinations cannot otherwise be selected with the keyboard. The change (in non-test code) is very small, and this has an automated test added in the CL above, so requesting a merge to M-69 for the change in comment 3.
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week LAST M69 Dev release before Beta promotion. Thank you.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d9bf82d8e530901009b8e632f9301a158addbf2 commit 3d9bf82d8e530901009b8e632f9301a158addbf2 Author: rbpotter <rbpotter@chromium.org> Date: Fri Jul 27 21:44:26 2018 Print Preview Componentization: Select destinations on enter key press (M69) Bug: 866411 Change-Id: I36c6a5d8d6e4c03f7d4ea99f4a4946aac30beed5 Reviewed-on: https://chromium-review.googlesource.com/1153650 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#178} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/3d9bf82d8e530901009b8e632f9301a158addbf2/chrome/browser/resources/print_preview/new/destination_list.html [modify] https://crrev.com/3d9bf82d8e530901009b8e632f9301a158addbf2/chrome/browser/resources/print_preview/new/destination_list.js [modify] https://crrev.com/3d9bf82d8e530901009b8e632f9301a158addbf2/chrome/test/data/webui/print_preview/destination_list_test.js [modify] https://crrev.com/3d9bf82d8e530901009b8e632f9301a158addbf2/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
,
Aug 1
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nyerramilli@chromium.org
, Jul 23