Issue metadata
Sign in to add a comment
|
Regression: Chrome crash is seen while opening Settings page in Guest user |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3499.0/10901.0.0 dev channel Daisy,Kip,Reks OS:chrome OS What steps will reproduce the problem? (1)In guest user>> Open chrome://settings page and observe crash Actual: When opening Settings page,chrome crashes Expected: No such crash should be seen This is a Regression issue as same is working fine on 69.0.3494.0/10893.0.0 dev NOTE: As it's guest user, unable to get crash ids. Attached the sreencast for reference..
,
Jul 24
Looks like introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1105773 There is probably no AccountTrackerService for guest session. Hence we crash in AccountManagerUIHandler ctor. Kush, could you check it out?
,
Jul 25
Thanks for the investigation Xiyuan! I have marked you on a patch. You're right: AccountTrackerService is not available in Guest Sessions and neither should Account Manager be.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f469b059172e8a58edae28d037cdd957da66af5 commit 1f469b059172e8a58edae28d037cdd957da66af5 Author: Kush Sinha <sinhak@chromium.org> Date: Wed Jul 25 18:00:39 2018 Disable crOS Account Manager in Guest Sessions Bug: 866354 , 820046, 833797 Change-Id: Ib2b56a59fd9d5a7d2cc9b013a875f5d29b05b5e0 Reviewed-on: https://chromium-review.googlesource.com/1150166 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577971} [modify] https://crrev.com/1f469b059172e8a58edae28d037cdd957da66af5/chrome/browser/signin/profile_oauth2_token_service_factory.cc [modify] https://crrev.com/1f469b059172e8a58edae28d037cdd957da66af5/chrome/browser/ui/webui/settings/chromeos/account_manager_handler.cc [modify] https://crrev.com/1f469b059172e8a58edae28d037cdd957da66af5/chrome/browser/ui/webui/settings/md_settings_ui.cc
,
Jul 25
Issue 867562 has been merged into this issue.
,
Jul 26
Fixed and checked on HEAD @ master (M70). rkalavakuntla@: Can you please double-check/verify. I'll need to back-merge this to M69. Thanks!
,
Jul 26
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 26
C #6 > Verified the issue on latest available [M-70]70.0.3502.0/10910.0.0 dev and 69.0.3497.14/10895.5.0 dev. [M-69] Still able to reproduce the issue. Thanks!
,
Jul 26
- You'll need Chrome >= 70.0.3503.0 dev (https://storage.googleapis.com/chromium-find-releases-static/1f4.html#1f469b059172e8a58edae28d037cdd957da66af5) to verify. - You can check the build status here: https://cros-goldeneye.corp.google.com/chromeos/console/listBuild?boards=kip&milestone=&chromeOsVersion=&chromeVersion=&startTimeFrom=&startTimeTo=#%2F (this for "kip") : 70.0.3503.0 isnt available for "kip" yet. - I haven't merged it to M69 yet. You'll see a "merge-merged" tag when that happens, pending your verification.
,
Jul 26
Chrome version >= 70.0.3503.0 dev is not available yet in GE. Will verify and update the issue,once the build is available. Thanks!
,
Jul 30
rkalavakuntla@: Seems to be available now (for M70) - https://cros-goldeneye.corp.google.com/chromeos/console/listBuild?boards=kip&milestone=&chromeOsVersion=&chromeVersion=&startTimeFrom=&startTimeTo=#%2F
,
Jul 30
Verified the issue on latest available [M-70]-70.0.3505.0/10921.0.0 dev. Unable to reproduce the issue.Issue seems fixed. Thanks!
,
Jul 30
,
Jul 30
,
Jul 31
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8f9e23d546439301dd54aa4f01fe04b584e423 commit 1f8f9e23d546439301dd54aa4f01fe04b584e423 Author: Kush Sinha <sinhak@chromium.org> Date: Tue Jul 31 14:02:12 2018 [Merge to M69] Disable crOS Account Manager in Guest Sessions Bug: 866354 , 820046, 833797 Change-Id: Ib2b56a59fd9d5a7d2cc9b013a875f5d29b05b5e0 Reviewed-on: https://chromium-review.googlesource.com/1150166 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577971}(cherry picked from commit 1f469b059172e8a58edae28d037cdd957da66af5) Reviewed-on: https://chromium-review.googlesource.com/1156644 Reviewed-by: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#268} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/1f8f9e23d546439301dd54aa4f01fe04b584e423/chrome/browser/signin/profile_oauth2_token_service_factory.cc [modify] https://crrev.com/1f8f9e23d546439301dd54aa4f01fe04b584e423/chrome/browser/ui/webui/settings/chromeos/account_manager_handler.cc [modify] https://crrev.com/1f8f9e23d546439301dd54aa4f01fe04b584e423/chrome/browser/ui/webui/settings/md_settings_ui.cc
,
Aug 1
rkalavakuntla@: Can you please check this on M69 (>= 69.0.3497.23). Thanks!
,
Aug 1
Rechecked the issue on latest available [M-69]-69.0.3497.24/10895.11.0 dev. Unable to reproduce the issue.Issue seems fixed. Thanks!
,
Aug 1
,
Aug 1
i don't think RVG is necessary here |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Jul 23