New issue
Advanced search Search tips

Issue 866340 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[Orca] Selects/drop-downs in HTML and in browser chrome are inaccessible

Project Member Reported by joanmari...@gmail.com, Jul 23

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3500.0 Safari/537.36

Steps to reproduce the problem:
1. Launch Chrome/Chromium
  * export ACCESSIBILITY_ENABLED=1, and
  * launch with --force-renderer-accessibility

2. Launch the attached accessible-event listener in a terminal

3. Load "data:text/html,<select><option>1</option><option>2</option><option>3</option></select>" in browser

4. Give the select element focus

5. Arrow up and down

6. Press space to expand the select, then arrow up and down

7. Give focus to the address and search bar, type something brief (e.g. "http") and arrow up and down

What is the expected behavior?
The accessible-event listener would print out events each time the selection changed.

What went wrong?
The accessible-event listener doesn't print out events when the selection changes.

Did this work before? No 

Chrome version: 70.0.3500.0  Channel: n/a
OS Version: 
Flash Version: 

Compare to: Firefox (with accessibility enabled), Epiphany

Documentation: https://developer.gnome.org/atk/stable/AtkSelection.html, https://developer.gnome.org/atk/stable/AtkObject.html#AtkObject.signals

Impact: Selects in web pages, and the popup in the address and search bar, are completely inaccessible to Orca users.
 
selection-events.py
642 bytes View Download
Labels: Needs-Triage-M70
Components: -UI UI>Accessibility
Cc: dmazz...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e

commit e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Mon Sep 10 17:06:16 2018

Emit state-changed:selected events for ATK on Aura Linux

* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
* Check to see if focus should follow selection. If it should, also
  emit state-changed:focused events.
* Ensure that the correct states (focusable and selectable) wind up
  in the state set of elements where focus should follow selection.
* Forward events from Blink content to AXPlatformNodeAuraLinux.
* Create an event listener so that DumpAccessibilityEventsTest tests
  can be run. Add expectations for tests for which events are now
  emitted. At the present time, that is only focus and selected.

R=dmazzoni@google.com

Bug:  866340 
Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a
Reviewed-on: https://chromium-review.googlesource.com/1163724
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Cr-Commit-Position: refs/heads/master@{#589951}
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/browser/accessibility/accessibility_event_recorder.cc
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/browser/accessibility/accessibility_event_recorder_auralinux.cc
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/browser/accessibility/browser_accessibility_manager_auralinux.cc
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/browser/accessibility/browser_accessibility_manager_auralinux.h
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/BUILD.gn
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/aria-combo-box-expand-expected-auralinux.txt
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/aria-combo-box-focus-expected-auralinux.txt
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/aria-combo-box-next-expected-auralinux.txt
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/listbox-focus-expected-auralinux.txt
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/listbox-next-expected-auralinux.txt
[add] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/event/menulist-focus-expected-auralinux.txt
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/html/optgroup-expected-auralinux.txt
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/content/test/data/accessibility/html/select-expected-auralinux.txt
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e/ui/accessibility/platform/ax_platform_node_auralinux.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a17983f62f1c00832e31dbbb9b701b46b62fe84

commit 4a17983f62f1c00832e31dbbb9b701b46b62fe84
Author: Ojan Vafai <ojan@chromium.org>
Date: Mon Sep 10 18:50:31 2018

Revert "Emit state-changed:selected events for ATK on Aura Linux"

This reverts commit e966eccab35dde2d8a0cd4cfaf16cf71a1f54d8e.

Reason for revert: Broke two DumpAccessibilityEventsTest tests. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/3172 

Original change's description:
> Emit state-changed:selected events for ATK on Aura Linux
> 
> * Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
> * Check to see if focus should follow selection. If it should, also
>   emit state-changed:focused events.
> * Ensure that the correct states (focusable and selectable) wind up
>   in the state set of elements where focus should follow selection.
> * Forward events from Blink content to AXPlatformNodeAuraLinux.
> * Create an event listener so that DumpAccessibilityEventsTest tests
>   can be run. Add expectations for tests for which events are now
>   emitted. At the present time, that is only focus and selected.
> 
> R=​dmazzoni@google.com
> 
> Bug:  866340 
> Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a
> Reviewed-on: https://chromium-review.googlesource.com/1163724
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#589951}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,nektar@chromium.org,aleventhal@chromium.org,joanmarie.diggs@gmail.com

Change-Id: If194799a765415ba34229b5315c54584021078e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866340 
Reviewed-on: https://chromium-review.googlesource.com/1217069
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590002}
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/browser/accessibility/accessibility_event_recorder.cc
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/browser/accessibility/accessibility_event_recorder_auralinux.cc
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/browser/accessibility/browser_accessibility_manager_auralinux.cc
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/browser/accessibility/browser_accessibility_manager_auralinux.h
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/test/BUILD.gn
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/aria-combo-box-expand-expected-auralinux.txt
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/aria-combo-box-focus-expected-auralinux.txt
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/aria-combo-box-next-expected-auralinux.txt
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/listbox-focus-expected-auralinux.txt
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/listbox-next-expected-auralinux.txt
[delete] https://crrev.com/7af1758ae9528c4f621cc9563d80658362a49110/content/test/data/accessibility/event/menulist-focus-expected-auralinux.txt
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/test/data/accessibility/html/optgroup-expected-auralinux.txt
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/content/test/data/accessibility/html/select-expected-auralinux.txt
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/4a17983f62f1c00832e31dbbb9b701b46b62fe84/ui/accessibility/platform/ax_platform_node_auralinux.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572b446bd1105d6c98b3b0386745650ccc7fd99a

commit 572b446bd1105d6c98b3b0386745650ccc7fd99a
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Tue Sep 11 05:30:05 2018

Re-land: Emit state-changed:selected events for ATK on Aura Linux

Originally landed: crrev.com/c/1163724
Reverted: crrev.com/c/1217069

The revert was due to the two new tests failing on Ubuntu 16.04,
which has a newer version of ATK and thus different expectations.
In order to run the same tests in both environments, prune states
which are not essential to what is being tested from the state set
of the expectations. This modification also eliminates the need to
hand-edit new expectations which are generated on more recent systems.

Original changes preserved in this re-land:
* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
* Check to see if focus should follow selection. If it should, also
  emit state-changed:focused events.
* Ensure that the correct states (focusable and selectable) wind up
  in the state set of elements where focus should follow selection.
* Forward events from Blink content to AXPlatformNodeAuraLinux.
* Create an event listener so that DumpAccessibilityEventsTest tests
  can be run. Add expectations for tests for which events are now
  emitted. At the present time, that is only focus and selected.

R=dmazzoni@google.com

Bug:  866340 
Change-Id: I371ad0a1516aceb6c6924d0142a6f3268dfdd3ac
Reviewed-on: https://chromium-review.googlesource.com/1217744
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590209}
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/browser/accessibility/accessibility_event_recorder.cc
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/browser/accessibility/accessibility_event_recorder_auralinux.cc
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/browser/accessibility/browser_accessibility_manager_auralinux.cc
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/browser/accessibility/browser_accessibility_manager_auralinux.h
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/BUILD.gn
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/aria-combo-box-expand-expected-auralinux.txt
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/aria-combo-box-focus-expected-auralinux.txt
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/aria-combo-box-next-expected-auralinux.txt
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/listbox-focus-expected-auralinux.txt
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/listbox-next-expected-auralinux.txt
[add] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/event/menulist-focus-expected-auralinux.txt
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/html/optgroup-expected-auralinux.txt
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/content/test/data/accessibility/html/select-expected-auralinux.txt
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/572b446bd1105d6c98b3b0386745650ccc7fd99a/ui/accessibility/platform/ax_platform_node_auralinux.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1

commit 79bd2796e2b1e5e0b939a14f1a5628ef33f427d1
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Thu Sep 13 12:33:20 2018

Emit state-changed:expanded events for ATK on Aura Linux

* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
* Forward events from Blink content to AXPlatformNodeAuraLinux.
* Update expectations for tests for which expanded events are now
  emitted.
* Also AX_EXPORT the AXPlatformNodeAuraLinux class so that we don't have
  to keep applying it to individual methods.

R=dmazzoni@google.com

Bug:  866340 
Change-Id: I0eeb6e8da674debc9832647992bb5cb08a3c6e12
Reviewed-on: https://chromium-review.googlesource.com/1222408
Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590981}
[modify] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/content/browser/accessibility/browser_accessibility_manager_auralinux.cc
[modify] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/content/browser/accessibility/browser_accessibility_manager_auralinux.h
[add] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/content/test/data/accessibility/event/aria-combo-box-collapse-expected-auralinux.txt
[modify] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/content/test/data/accessibility/event/aria-combo-box-expand-expected-auralinux.txt
[modify] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/79bd2796e2b1e5e0b939a14f1a5628ef33f427d1/ui/accessibility/platform/ax_platform_node_auralinux.h

Components: UI>Accessibility>Compatibility
Status: Available (was: Unconfirmed)
Status: Fixed (was: Available)

Sign in to add a comment