New issue
Advanced search Search tips

Issue 866334 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[Orca] Accessible keyboard are events missing

Project Member Reported by joanmari...@gmail.com, Jul 23

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3500.0 Safari/537.36

Steps to reproduce the problem:
1. Launch Chrome/Chromium
  * export ACCESSIBILITY_ENABLED=1, and
  * launch with --force-renderer-accessibility

2. Launch the attached accessible-event listener in a terminal

3. Use the keyboard to interact with the content in the browser

What is the expected behavior?
The event listener would print out each key press.

What went wrong?
The event listener does not print out any key presses when the browser is focused.

Did this work before? N/A 

Chrome version: 70.0.3500.0  Channel: n/a
OS Version: 
Flash Version: 

Compare to: Gtk+ apps, Firefox (with accessibility enabled), Epiphany

Documentation: https://developer.gnome.org/atk/stable/AtkUtil.html#AtkKeySnoopFunc

Impacts:

1. In order for Orca's commands to work (e.g. presenting the next heading in response to H, presenting the next line in response to Down, etc.), Orca needs to be notified when keys are pressed and what those keys are. Because Chrome/Chromium fails to do this, no Orca commands work.

2. Because accessibility events typically indicate what happened (e.g. text was inserted) but not why (user input versus dynamic content), Orca has heuristics which it uses to try to figure out why an accessibility event was emitted by the browser in order to determine what, if anything to present to the user in response. These heuristics rely in part on being notified of input events.
 
key-events.py
719 bytes View Download
Labels: Needs-Triage-M70
Components: -UI UI>Accessibility
Cc: dmazz...@chromium.org
Components: UI>Accessibility>Compatibility
Status: Available (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26b9d891ad497c3928e9b7c04567100efe9bbdd

commit b26b9d891ad497c3928e9b7c04567100efe9bbdd
Author: Martin Robinson <mrobinson@igalia.com>
Date: Wed Nov 14 15:43:54 2018

Add X11 support for ATK key event listeners

ATK requires us to allow it to filter all key events. Add an AtkUtil
mechanism to filter key events.

Bug:  866334 
Change-Id: I42383479ab78242325bda0714afb60b7dcf2fe65
Reviewed-on: https://chromium-review.googlesource.com/c/1319709
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607989}
[modify] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/BUILD.gn
[add] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/platform/DEPS
[modify] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/platform/atk_util_auralinux.cc
[modify] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/platform/atk_util_auralinux.h
[add] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/platform/atk_util_auralinux_unittest.cc
[add] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/accessibility/platform/atk_util_auralinux_x11.cc
[modify] https://crrev.com/b26b9d891ad497c3928e9b7c04567100efe9bbdd/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15860c91415705b220f6ef6d7d1fa5b49f5a1364

commit 15860c91415705b220f6ef6d7d1fa5b49f5a1364
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Nov 14 23:23:52 2018

Revert "Add X11 support for ATK key event listeners"

This reverts commit b26b9d891ad497c3928e9b7c04567100efe9bbdd.

Reason for revert: Added static initializers, see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/37632

Original change's description:
> Add X11 support for ATK key event listeners
> 
> ATK requires us to allow it to filter all key events. Add an AtkUtil
> mechanism to filter key events.
> 
> Bug:  866334 
> Change-Id: I42383479ab78242325bda0714afb60b7dcf2fe65
> Reviewed-on: https://chromium-review.googlesource.com/c/1319709
> Commit-Queue: Martin Robinson <mrobinson@igalia.com>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607989}

TBR=sadrul@chromium.org,dmazzoni@chromium.org,mrobinson@igalia.com

Change-Id: I7cc1d2bfa85761af5c1704260646758ae3028063
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866334 
Reviewed-on: https://chromium-review.googlesource.com/c/1336437
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608166}
[modify] https://crrev.com/15860c91415705b220f6ef6d7d1fa5b49f5a1364/ui/accessibility/BUILD.gn
[delete] https://crrev.com/eda55b710565564535d84205384d61f45b77f238/ui/accessibility/platform/DEPS
[modify] https://crrev.com/15860c91415705b220f6ef6d7d1fa5b49f5a1364/ui/accessibility/platform/atk_util_auralinux.cc
[modify] https://crrev.com/15860c91415705b220f6ef6d7d1fa5b49f5a1364/ui/accessibility/platform/atk_util_auralinux.h
[delete] https://crrev.com/eda55b710565564535d84205384d61f45b77f238/ui/accessibility/platform/atk_util_auralinux_unittest.cc
[delete] https://crrev.com/eda55b710565564535d84205384d61f45b77f238/ui/accessibility/platform/atk_util_auralinux_x11.cc
[modify] https://crrev.com/15860c91415705b220f6ef6d7d1fa5b49f5a1364/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c

commit 993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c
Author: Martin Robinson <mrobinson@igalia.com>
Date: Fri Nov 16 10:02:03 2018

Re-land: Add X11 support for ATK key event listeners

Original: http://crrev.com/c/1319709
Revert: http://crrev.com/c/1336437

Moves a statically initialized map to a be initialized as a local
static using NoDestructor.

Original description:

ATK requires us to allow it to filter all key events. Add an AtkUtil
mechanism to filter key events.

Bug:  866334 
Change-Id: I918590da241dc10f71ade558454a2fbf118e5860
Reviewed-on: https://chromium-review.googlesource.com/c/1337621
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608716}
[modify] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/BUILD.gn
[add] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/platform/DEPS
[modify] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/platform/atk_util_auralinux.cc
[modify] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/platform/atk_util_auralinux.h
[add] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/platform/atk_util_auralinux_unittest.cc
[add] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/accessibility/platform/atk_util_auralinux_x11.cc
[modify] https://crrev.com/993de8a24edb8b1e6eb2a8fb43cb58fb7771ba5c/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Verified (was: Available)

Sign in to add a comment