New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866329 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Some Google service Auth errors are not defined in GoogleServiceAuthError.java

Project Member Reported by zhaofeng@google.com, Jul 23

Issue description

Components: Infra>Client>Chrome
Components: -Infra>Client>Chrome Services>Sync
Labels: Sync-Triaged
Sync triage ping. Is there any updates?
Labels: OS-Android
Owner: treib@chromium.org
Status: Assigned (was: Untriaged)
Looks like this inconsistency has been around since 2013, so it's probably not a huge issue :)
Still, seems like an easy fix, so I'll take it. At first we can just add the missing entries; longer term it'd be better to use GENERATED_JAVA_ENUM_PACKAGE to automatically generate the Java enum from the C++ one.
Labels: FixitSync
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25247a7f1024fcc6df58a895db978656f13488d

commit f25247a7f1024fcc6df58a895db978656f13488d
Author: Marc Treib <treib@chromium.org>
Date: Mon Oct 08 15:48:16 2018

Add missing entries to Java version of GoogleServiceAuthError

There's a C++ version and a Java equivalent of GoogleServiceAuthError.
The Java version was missing a few entries that were added over the last
years; this CL adds them and so brings the two back in sync.
Longer-term, it'd be better to automatically generate the Java version
from the C++ one using GENERATED_JAVA_ENUM_PACKAGE, but that's left for
a future CL.

Bug:  866329 
Change-Id: Iaed8a9d10c4824bca3f2f828828f5934c0c2845e
Reviewed-on: https://chromium-review.googlesource.com/c/1268335
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597568}
[modify] https://crrev.com/f25247a7f1024fcc6df58a895db978656f13488d/chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java

Labels: -Pri-2 Pri-3
I think GENERATED_JAVA_ENUM_PACKAGE won't work well after all, since the actual enum (State) is within the GoogleServiceAuthError class.

However, there is a mojo version of GoogleServiceAuthError, we should probably migrate to that instead of our homegrown Sync-specific Java version.
Status: Fixed (was: Started)
This one is done, the two are now consistent. I've filed bug 900184 for the followup to use the common mojo version.

Sign in to add a comment