Some Google service Auth errors are not defined in GoogleServiceAuthError.java |
||||||||
Issue descriptionSome Google service Auth errors are not defined in: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java See more in file: https://cs.chromium.org/chromium/src/google_apis/gaia/google_service_auth_error.h Otherwise we may get IllegalArgumentException in: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java?l=71&rcl=e3540f40cb15b3d0013259b504d66a1d2b8395c0
,
Jul 23
,
Jul 25
,
Aug 24
Sync triage ping. Is there any updates?
,
Sep 27
Looks like this inconsistency has been around since 2013, so it's probably not a huge issue :) Still, seems like an easy fix, so I'll take it. At first we can just add the missing entries; longer term it'd be better to use GENERATED_JAVA_ENUM_PACKAGE to automatically generate the Java enum from the C++ one.
,
Sep 27
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f25247a7f1024fcc6df58a895db978656f13488d commit f25247a7f1024fcc6df58a895db978656f13488d Author: Marc Treib <treib@chromium.org> Date: Mon Oct 08 15:48:16 2018 Add missing entries to Java version of GoogleServiceAuthError There's a C++ version and a Java equivalent of GoogleServiceAuthError. The Java version was missing a few entries that were added over the last years; this CL adds them and so brings the two back in sync. Longer-term, it'd be better to automatically generate the Java version from the C++ one using GENERATED_JAVA_ENUM_PACKAGE, but that's left for a future CL. Bug: 866329 Change-Id: Iaed8a9d10c4824bca3f2f828828f5934c0c2845e Reviewed-on: https://chromium-review.googlesource.com/c/1268335 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597568} [modify] https://crrev.com/f25247a7f1024fcc6df58a895db978656f13488d/chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java
,
Oct 11
I think GENERATED_JAVA_ENUM_PACKAGE won't work well after all, since the actual enum (State) is within the GoogleServiceAuthError class. However, there is a mojo version of GoogleServiceAuthError, we should probably migrate to that instead of our homegrown Sync-specific Java version.
,
Oct 30
This one is done, the two are now consistent. I've filed bug 900184 for the followup to use the common mojo version. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by zhaofeng@google.com
, Jul 23