Issue 866291 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ apaci...@chromium.org no longer active
Closed:	Jul 24
Cc:	jbanavatu@chromium.org
Components:	Blink>Media>PictureInPicture
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	1
Type:	Bug
Needs-Feedback M-69

[PIP] Activate controls with keyboard.

Project Member Reported by apaci...@chromium.org, Jul 22

Issue description

Currently, controls (play/pause, close) are focusable, but do nothing when focused and keyboard enter or space are used.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a1601425172f0417c718b7e0671f869976fa50

commit b6a1601425172f0417c718b7e0671f869976fa50
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Jul 23 15:19:19 2018

[Picture in Picture] Activate controls using enter / space keys.

This change adds in KeyEvent handling to support keyboard usage with
the controls buttons. They should be activated when the 'enter' or
'space' keys are used.

The previous implementation of OnKeyEvent used an OverlayWindowViews
tracking of which control is being focused, which is now obsolete.

Bug:  866291 
Change-Id: I8a59337aa7aef5c95da081a9b5f33762462eeaef
Reviewed-on: https://chromium-review.googlesource.com/1146283
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577172}
[modify] https://crrev.com/b6a1601425172f0417c718b7e0671f869976fa50/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/b6a1601425172f0417c718b7e0671f869976fa50/chrome/browser/ui/views/overlay/overlay_window_views.h

Comment 2 by jbanavatu@chromium.org, Jul 24

Cc: jbanavatu@chromium.org
Labels: Needs-Feedback

Able to reproduce the issue on build without fix #70.0.3500.0, but unable to verify this on latest canary #70.0.3501.0 as we are not seeing focus on PIP video controls using keyboard.

Steps:
1. Navigate to https://googlechrome.github.io/samples/picture-in-picture/
2. Toggle to picture in picture mode >> Hover on PIP video>> hit tab and Observe there is no focus is seen on PIP controls

Attaching screen-cast for reference.

@apacible: Please let us know if we missed something from our end. Also let us know if we need to file separate bug for this?

Thanks!