New issue
Advanced search Search tips

Issue 866265 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome Duet hide the options in pop-up menu(3 dots). There are only one option - "new tab".

Reported by przemych...@gmail.com, Jul 21

Issue description

Steps to reproduce the problem:
1. Launch clean Google Chrome Canary.
2. Enable Chrome Duet in flags.
3. Restart twice.

What is the expected behavior?
Toolbar should move to the bottom. Omnibox should stay at the top.

What went wrong?
Pop-up menu display only one option - "new tab". But my other smartphone[Samsung S4(Android 5.0.1) with the same browser and settings] display everything correctly. 
I also checked it on older versions of the browser, up to version 69.0.3492.0 and always something wrong was displayed on Samsung S6.

Did this work before? No 

Chrome version: 70.0.3498.0  Channel: canary
OS Version: 7.0.0
Flash Version:
 
Screenshot_20180721-195940.png
219 KB View Download
Screenshot_2018-07-21-19-59-24.png
147 KB View Download

Comment 1 Deleted

Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Components: -UI UI>Browser
Labels: Target-70 M-70 Triaged-Mobile FoundIn-70 Target-69 FoundIn-69
Status: Untriaged (was: Unconfirmed)
Tested this issue on Android and able to reproduce this issue.

Steps Followed:
1. Launched chrome
2. Enabled chrome Duet in chrome://flags
3. Restarted twice and observed 3 dot menu -- clicked on it and observed only first option in menu is seen

Observations:
===============
1. Issue is seen from introduction of chrome Duet flag
2. Issue is not seen on Android 6.0 - Nexus 5

Chrome versions tested:
 70.0.3498.0 ; 70.0.3500.0(canary)

OS:
Android 7.0

Android Devices:
Samsung Galaxy J7

This seems to be a Non-Regression issue as same behavior is seen from introduction of chrome duet flag. Leaving the issue as Untriaged  for further input's on this issue.

Please navigate to below link for log's --
go/chrome-androidlogs/866265
 
Thanks!
Cc: twelling...@chromium.org amaralp@chromium.org
Owner: mdjones@chromium.org
Adding some FE folk.  @twellington, does the app menu have the offsetting bugs on certain versions or did we migrate to the non-broken widgets?

This looks like a positioning bug for a certain subset of devices.
Labels: android-fe-triaged
We're using PopupWindow instead of ListPopupWindow (which had the positioning issues with vertical offset being interpreted differently), but iirc some versions of Android restrict the popup from showing outside the window bounds and some do not.

For those that do not, we need to make sure the x-y position we're using to show the popup match where we actually want it to show. We used to have logic for this but it possibly got deleted/missed when re-adding support for the bottom anchored app menu.
Status: Started (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc92761711fd2d8e12efac49f93d2edd0324ee9a

commit bc92761711fd2d8e12efac49f93d2edd0324ee9a
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Aug 02 20:29:28 2018

Fix bottom anchored overflow menu position in Duet

This patch re-adds some of the code that was removed during Chrome
Home cleanup to correctly position the overflow menu when anchored to
the bottom of the screen (removal patch fround here:
https://chromium-review.googlesource.com/c/chromium/src/+/934978).

Bug:  866265 
Change-Id: I4e4341b138cd9315f9a7fae8cbf47487923a0086
Reviewed-on: https://chromium-review.googlesource.com/1161174
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580300}
[modify] https://crrev.com/bc92761711fd2d8e12efac49f93d2edd0324ee9a/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/bc92761711fd2d8e12efac49f93d2edd0324ee9a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Status: Fixed (was: Started)
Labels: android-bottom-toolbar
 Issue 883539  has been merged into this issue.
 Issue 883575  has been merged into this issue.
It seems like this problem still appears in 71.0.3574.0 dev with Android 7.0.0.
#13 is your device HTC?
#14 No. My device is Meizu Pro 6 Plus, running a custom ROM called Flyme.

Sign in to add a comment