New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866261 link

Starred by 1 user
Status: Fixed
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Closed: Jul 23
Cc:
perezju@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix PRESUBMIT errors of src/tools/perf/

Project Member Reported by nednguyen@chromium.org, Jul 21 
With the new pylint roll, we now have a bunch of new PRESUBMIT errors. Open this bug to fix them.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85daaeb153b54a15802902fc8ca199cb43557bb7

commit 85daaeb153b54a15802902fc8ca199cb43557bb7
Author: Ned Nguyen <nednguyen@google.com>
Date: Mon Jul 23 16:19:15 2018

Fix PRESUBMIT errors of tools/perf

Bug:866261
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af

NOTRY=true  # layout test flakiness

Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af
Reviewed-on: https://chromium-review.googlesource.com/1146330
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577182}
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/chrome_telemetry_build/chromium_config.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/contrib/cluster_telemetry/screenshot.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/perf_data_generator_unittest.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/results_dashboard.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/sharding_map_generator.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/sharding_map_generator_unittest.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/core/upload_results_to_perf_dashboard.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/fetch_benchmark_deps_unittest.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/generate_legacy_perf_dashboard_json.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/page_sets/google_pages.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/page_sets/rendering/rendering_story.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/page_sets/system_health/multi_tab_stories.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/page_sets/system_health/system_health_story.py
[modify] https://crrev.com/85daaeb153b54a15802902fc8ca199cb43557bb7/tools/perf/process_perf_results.py

Comment 2 by nednguyen@chromium.org, Jul 23

Status: Fixed (was: Untriaged)
►

Sign in to add a comment