New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866260 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix PRESUBMIT errors of catapult

Project Member Reported by nednguyen@chromium.org, Jul 21

Issue description

With the new pylint roll, we now have a bunch of new PRESUBMIT errors. Open this bug to fix them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d400abdcd30a344226a9328d3fde8c398bfbc352

commit d400abdcd30a344226a9328d3fde8c398bfbc352
Author: Nghia Nguyen <nednguyen@google.com>
Date: Mon Jul 23 14:22:48 2018

Fix PRESUBMIT errors in catapult

Bug:  chromium:866260 
Change-Id: I62b68513fee3a482493dd78781a456896c61ed86
Reviewed-on: https://chromium-review.googlesource.com/1146294
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/platform_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/actions/action_runner_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/util/ps_util.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/value/histogram.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/trace_event_importer_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/system_info.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome/cros_browser_finder_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/event.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/results/artifact_results_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/testing/system_stub_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/story_runner.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/value/trace_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/power_monitor/android_power_monitor_controller.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/testing/system_stub.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/image_processing/screen_finder_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/core/cros_interface.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/wpr/archive_info_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/util/screenshot_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/browser/browser_interval_profiling_controller_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/util/image_util.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/util/webpagereplay_go_server_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_controller_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/build/linux_setup_msr.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/event_container.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/util/ts_proxy_server.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/linux_platform_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/android_app_backend_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/gpu_info.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/slice.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/forwarders/cros_forwarder_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/util/webpagereplay_go_server.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/memory_dump_event.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/results/results_options.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/thread.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/image_processing/screen_finder.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/android_backend_settings_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/browser/browser_finder.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/value/skip.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/snap_page_util_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/chrome_trace_category_filter.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/results/page_test_results_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/value/value_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/core/local_server.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/forwarders/android_forwarder.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/trace_event_importer.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome_inspector/memory_backend_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/story_runner_unittest.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/internal/platform/android_platform_backend.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/timeline/model.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/__init__.py
[modify] https://crrev.com/d400abdcd30a344226a9328d3fde8c398bfbc352/telemetry/telemetry/web_perf/timeline_based_measurement.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c1e861467cefc2877f135c1e5c5fe977271475

commit 84c1e861467cefc2877f135c1e5c5fe977271475
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 23 22:17:20 2018

Roll src/third_party/catapult 9e8a0b2b37d9..1381813c377d (3 commits)

https://chromium.googlesource.com/catapult.git/+log/9e8a0b2b37d9..1381813c377d


git log 9e8a0b2b37d9..1381813c377d --date=short --no-merges --format='%ad %ae %s'
2018-07-23 nednguyen@google.com Increase default timeout limit of setting tsproxy's traffic settings to 20 seconds
2018-07-23 nednguyen@google.com Add '--story-shard-begin-index' and '--story-shard-end-index' flags
2018-07-23 nednguyen@google.com Fix PRESUBMIT errors in catapult


Created with:
  gclient setdep -r src/third_party/catapult@1381813c377d

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:865250, chromium:866095 , chromium:866260 
TBR=sullivan@chromium.org

Change-Id: I0f4b0a06fa6b8e5312fbbd6f6385910004841801
Reviewed-on: https://chromium-review.googlesource.com/1147060
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577290}
[modify] https://crrev.com/84c1e861467cefc2877f135c1e5c5fe977271475/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b893d71f7199a668434c20461bb7cefe309f6a3f

commit b893d71f7199a668434c20461bb7cefe309f6a3f
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 24 21:30:11 2018

Roll src/third_party/catapult d269b0e87d1e..e0ae2989b096 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/d269b0e87d1e..e0ae2989b096


git log d269b0e87d1e..e0ae2989b096 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 benjhayden@chromium.org Add a new ReportTemplate system.
2018-07-24 simonhatch@chromium.org Disable a bunch of pylint warnings.
2018-07-24 nastasoiuf@google.com Initial implementation


Created with:
  gclient setdep -r src/third_party/catapult@e0ae2989b096

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:866260 
TBR=sullivan@chromium.org

Change-Id: I7f71d7246cfd6312d73d4ef4dac17b1c3c6af864
Reviewed-on: https://chromium-review.googlesource.com/1147917
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577691}
[modify] https://crrev.com/b893d71f7199a668434c20461bb7cefe309f6a3f/DEPS

Sign in to add a comment