New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866236 link

Starred by 2 users
Status: Assigned
Owner:
dpa...@chromium.org
Cc:
joelhockey@chromium.org
█ scottchen@chromium.org
michae...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

WebUI: Decouple shared UI elements from chrome:// URLs.

Project Member Reported by dpa...@chromium.org, Jul 21 
Currently there are a lot of unnecessary absolute chrome:// URLs used under ui/webui/resources. These URLs couple the codebase with Chrome (and browser_tests) unnecessarily.

There is no good reason I can think of to keep using absolute chrome:// URLs when relative URLs can be used. Decoupling from chrome:// URLs can lead to many benefits, for example:

 - Running UI unit tests without js2gtest, just with Mocha (a long-standing goal)
 - Being able to leverage UI elements outside of Chrome. For example see the WebUI elements demo at https://freshp86.github.io/chromium-webui/demo.html. The demo is pretty useful for designers, and new WebUI developers. The demo is currently hard to maintain because of all the chrome:// URLs. Eventually this demo could be moved within the Chromium repo, without requiring a fork of the WebUI code.
 - Being able to run UI elements in jsfiddle/jsbin etc. This makes it very easy to showcase a bug, or experiment with something very quickly, without a full chromium build.

Example CL at https://chromium-review.googlesource.com/c/chromium/src/+/1144610. If there are no objections to this, I am also planning to add PRESUBMIT checks to prevent future additions of unnecessary chrome:// URLS.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54e4135e2f08b5042d36120c6be3d94d43efaeb2

commit 54e4135e2f08b5042d36120c6be3d94d43efaeb2
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 25 23:51:20 2018

WebUI: Use relative paths where possible in shared UI elements, part 1.

This not only results to smaller file size, but also makes the code more
portable, since it is less dependent on chrome:// URLs, and can eventually
lead to running those elements and tests outside the context of a browser_tests
and without js2gtest.

For example this makes it easier to keep maintaining the following WebUI demo
https://freshp86.github.io/chromium-webui/demo.html, and potentially move it within
the Chromium repo itself.

Bug: 866236
Change-Id: I1459789177ba5ede252c3ade3e0952686f4f01b5
Reviewed-on: https://chromium-review.googlesource.com/1144610
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578132}
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_png_behavior.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/network/cr_network_list.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/chromeos/network/network_icons.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_icons_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_scrollable_behavior.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_toast/cr_toast.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/hidden_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/icons.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/paper_tabs_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/search_highlight_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/shared_style_css.html
[modify] https://crrev.com/54e4135e2f08b5042d36120c6be3d94d43efaeb2/ui/webui/resources/cr_elements/shared_vars_css.html
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5

commit 9a6cce08c00d70eeb3ceb2363c8945418fdb98b5
Author: dpapad <dpapad@chromium.org>
Date: Sat Jul 28 03:59:45 2018

WebUI: Use relative paths where possible in shared UI elements, part 2.

This not only results to smaller file size, but also makes the code more
portable, since it is less dependent on chrome:// URLs, and can eventually
lead to running those elements and tests outside the context of a browser_tests
and without js2gtest.

Bug: 866236
Change-Id: I26b4a22f61b10cbbd1a19c5e055bb5c0f2aaf471
Reviewed-on: https://chromium-review.googlesource.com/1150931
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578913}
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/action_link.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/action_link_css.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/assert.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/event_target.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/array_data_model.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/command.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/context_menu_button.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/context_menu_handler.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/drag_wrapper.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/focus_grid.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/focus_manager.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/focus_outline_manager.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/focus_row.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/focus_without_ink.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/list.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/list_item.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/list_selection_controller.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/list_selection_model.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/menu.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/menu_button.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/menu_item.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/overlay.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/page_manager/page.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/page_manager/page_manager.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/position_util.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/cr/ui/splitter.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/event_tracker.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/i18n_behavior.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/i18n_template.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/icon.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/list_property_update_behavior.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/load_time_data.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/md_select_css.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/parse_html_subset.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/polymer.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/promise_resolver.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/search_highlight_utils.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/util.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/web_ui_listener_behavior.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/html/webui_listener_tracker.html
[modify] https://crrev.com/9a6cce08c00d70eeb3ceb2363c8945418fdb98b5/ui/webui/resources/webui_resources.grd
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f0e0078e53270131ccbc5b64d343ff0acf322ae

commit 2f0e0078e53270131ccbc5b64d343ff0acf322ae
Author: dpapad <dpapad@chromium.org>
Date: Thu Dec 20 02:43:18 2018

History WebUI cleanup: Convert unnecessary absolute URLs to relative.

Also change GRIT configuration from flattenhtml to preprocess where possible.

Bug: 866236
Change-Id: I7385da764932f41f9ee6808b26d0896767a67e8e
Reviewed-on: https://chromium-review.googlesource.com/c/1381723
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618083}
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/BUILD.gn
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/browser_service.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/constants.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/lazy_load.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/router.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/searched_label.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/2f0e0078e53270131ccbc5b64d343ff0acf322ae/chrome/browser/resources/md_history/synced_device_manager.html
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134fd6467a64d16187dd1b5e5819a409f77562d8

commit 134fd6467a64d16187dd1b5e5819a409f77562d8
Author: dpapad <dpapad@chromium.org>
Date: Thu Dec 20 18:12:58 2018

Bookmarks WebUI cleanup: Convert unnecessary absolute URLs to relative.

Also change GRIT configuration from flattenhtml to preprocess where possible.

Bug: 866236
Change-Id: Ief42c461cc6b61d2a3719e823c261053d2bf205d
Reviewed-on: https://chromium-review.googlesource.com/c/1383395
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618273}
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/browser_resources.grd
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/actions.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/api_listener.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/bookmarks.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/constants.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/debouncer.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/dialog_focus_manager.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/dnd_manager.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/mouse_focus_behavior.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/reducers.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/router.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/store.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/store_client.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/toast_manager.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/134fd6467a64d16187dd1b5e5819a409f77562d8/chrome/browser/resources/md_bookmarks/util.html
►

Sign in to add a comment