Sporadic UdevDeviceTest failures in Android N PFQ |
|||||||||
Issue descriptionUnitTest stage occasionally fails in UdevDeviceTest.IsOnBootDevice: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8940432555860615312 cros-disks-0.0.1-r2553: [ RUN ] UdevDeviceTest.IsOnBootDevice cros-disks-0.0.1-r2553: ../../../../../../../tmp/portage/chromeos-base/cros-disks-0.0.1-r2553/work/cros-disks-0.0.1/cros-disks/udev_device_unittest.cc:277: Failure cros-disks-0.0.1-r2553: Value of: device.IsOnBootDevice() cros-disks-0.0.1-r2553: Actual: true cros-disks-0.0.1-r2553: Expected: false cros-disks-0.0.1-r2553: terminating with uncaught exception of type testing::internal::GoogleTestFailureException: ../../../../../../../tmp/portage/chromeos-base/cros-disks-0.0.1-r2553/work/cros-disks-0.0.1/cros-disks/udev_device_unittest.cc:277: Failure cros-disks-0.0.1-r2553: Value of: device.IsOnBootDevice() cros-disks-0.0.1-r2553: Actual: true cros-disks-0.0.1-r2553: Expected: false cros-disks-0.0.1-r2553: Error: /var/cache/portage/chromeos-base/cros-disks/out/Default/disks_testrunner: failed with signal SIGIOT|SIGABRT(6)
,
Jul 23
+benchan, who seems to be the main author for these udev* files.
,
Jul 24
Also +sheriff and gardener. The failure is in a unit test in platform2/cros-disks, so it shouldn't be Android specific.
,
Jul 24
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/32bee936810068f31e9af01eb9b0d68158530b40 commit 32bee936810068f31e9af01eb9b0d68158530b40 Author: Ben Chan <benchan@chromium.org> Date: Wed Jul 25 07:14:55 2018 cros-disks: disable a flaky UdevDeviceTest.IsOnBootDevice test BUG= chromium:866231 TEST=Run unit tests. Change-Id: Idebccbeaccd9998acf77f60177a31404521ef96d Reviewed-on: https://chromium-review.googlesource.com/1149095 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Victor Hsieh <victorhsieh@chromium.org> [modify] https://crrev.com/32bee936810068f31e9af01eb9b0d68158530b40/cros-disks/udev_device_unittest.cc
,
Jul 31
We also see this on R69, should we merge this back? https://logs.chromium.org/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8939497763315797008/+/steps/UnitTest/0/stdout
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/54d2d87d3ce554ac2047f1c9500075011e77aba3 commit 54d2d87d3ce554ac2047f1c9500075011e77aba3 Author: Ben Chan <benchan@chromium.org> Date: Thu Aug 02 22:52:09 2018 cros-disks: disable a flaky UdevDeviceTest.IsOnBootDevice test BUG= chromium:866231 TEST=Run unit tests. Change-Id: Idebccbeaccd9998acf77f60177a31404521ef96d Reviewed-on: https://chromium-review.googlesource.com/1149095 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Victor Hsieh <victorhsieh@chromium.org> (cherry picked from commit 32bee936810068f31e9af01eb9b0d68158530b40) Reviewed-on: https://chromium-review.googlesource.com/1158025 Tested-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/54d2d87d3ce554ac2047f1c9500075011e77aba3/cros-disks/udev_device_unittest.cc
,
Aug 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Today
(16 hours ago)
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by domlasko...@chromium.org
, Jul 23Owner: victorhsieh@chromium.org
Status: Assigned (was: Untriaged)