New issue
Advanced search Search tips

Issue 866230 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: OmniboxViewViewsTest.SelectAllOnTabToFocus



Sign in to add a comment

OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky

Project Member Reported by Findit, Jul 21

Issue description

Cc: pbos@chromium.org
Owner: timloh@chromium.org
Status: Started (was: Available)
Reverting at https://chromium-review.googlesource.com/c/chromium/src/+/1146421
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72294616387f89cb2036f962cc99f2d3a6ea05b

commit e72294616387f89cb2036f962cc99f2d3a6ea05b
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Jul 23 04:55:19 2018

Revert "Match security chip visibility with focus ring"

This reverts commit 26399bca111241fe779fcbcfaf2047faac85deb6.

Reason for revert: OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky

Original change's description:
> Match security chip visibility with focus ring
> 
> Instantly hides or shows the IconLabelBubbleView separator when focus
> rings are available to prevent showing the separator when a focus ring
> overlaps it.
> 
> Bug:  chromium:865029 
> Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99
> Reviewed-on: https://chromium-review.googlesource.com/1142442
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576358}

TBR=pbos@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  865029 ,  866230 
Change-Id: I30372e90c1613b33690b43dd28fbe151abddddef
Reviewed-on: https://chromium-review.googlesource.com/1146421
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577110}
[modify] https://crrev.com/e72294616387f89cb2036f962cc99f2d3a6ea05b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/e72294616387f89cb2036f962cc99f2d3a6ea05b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c83f323d614760aba156aece59a9ac53864c78b

commit 3c83f323d614760aba156aece59a9ac53864c78b
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Jul 23 18:28:45 2018

Revert "Match security chip visibility with focus ring"

This reverts commit 26399bca111241fe779fcbcfaf2047faac85deb6.

Reason for revert: OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky

Original change's description:
> Match security chip visibility with focus ring
>
> Instantly hides or shows the IconLabelBubbleView separator when focus
> rings are available to prevent showing the separator when a focus ring
> overlaps it.
>
> Bug:  chromium:865029 
> Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99
> Reviewed-on: https://chromium-review.googlesource.com/1142442
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576358}

TBR=pbos@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  865029 ,  866230 
Change-Id: I30372e90c1613b33690b43dd28fbe151abddddef
Reviewed-on: https://chromium-review.googlesource.com/1146421
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577110}(cherry picked from commit e72294616387f89cb2036f962cc99f2d3a6ea05b)
Reviewed-on: https://chromium-review.googlesource.com/1147081
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#17}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3c83f323d614760aba156aece59a9ac53864c78b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/3c83f323d614760aba156aece59a9ac53864c78b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Sign in to add a comment