New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 866229 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 5
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-08
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: !descriptors->GetKey(i)->IsInterestingSymbol() in objects-debug.cc

Project Member Reported by ClusterFuzz, Jul 21

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6075410165792768

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !descriptors->GetKey(i)->IsInterestingSymbol() in objects-debug.cc
  v8::internal::Map::MapVerify
  v8::internal::Object::ObjectVerify
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=54594:54595

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6075410165792768

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 21

Components: Blink>JavaScript>GC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 21

Labels: Test-Predator-Auto-Owner
Owner: ca...@igalia.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/b6f7ea580595f98b89fc47c50f9ccfbbd3b9c448 ([runtime] use new CloneObject bytecode for some ObjectLiteralSpread cases).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 21

Labels: Pri-1
Labels: Security_Impact-Head
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 23

Labels: M-69 Target-69
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 23

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 25

Labels: -Security_Impact-Head Security_Impact-Beta
Friendly ping from the security sheriff. This is a high severity vulnerability affecting beta branch.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 4

caitp: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7098f35c7ceee6c84c8951f21a6bdb4c4e692d3a

commit 7098f35c7ceee6c84c8951f21a6bdb4c4e692d3a
Author: Caitlin Potter <caitp@igalia.com>
Date: Sat Aug 04 16:48:18 2018

[CloneObjectIC] copy may_have_interesting_symbols bit to fast result map

This fixes a CHECK failure in MapVerify, and gets the correct behaviour
for uses of the well-known symbols.

BUG=v8:7611,  chromium:866229 
R=jkummerow@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org

Change-Id: I5d679357b8807ea9d1054121d8d336fe0dd43c7c
Reviewed-on: https://chromium-review.googlesource.com/1162278
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#54905}
[modify] https://crrev.com/7098f35c7ceee6c84c8951f21a6bdb4c4e692d3a/src/ic/ic.cc
[add] https://crrev.com/7098f35c7ceee6c84c8951f21a6bdb4c4e692d3a/test/mjsunit/es9/regress/regress-866229.js

Project Member

Comment 12 by ClusterFuzz, Aug 5

ClusterFuzz has detected this issue as fixed in range 54904:54905.

Detailed report: https://clusterfuzz.com/testcase?key=6075410165792768

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !descriptors->GetKey(i)->IsInterestingSymbol() in objects-debug.cc
  v8::internal::Map::MapVerify
  v8::internal::Object::ObjectVerify
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=54594:54595
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=54904:54905

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6075410165792768

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Aug 5

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6075410165792768 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 5

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 7

Labels: Merge-Request-69
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 7

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ (Security TPM) for M69 merge review.
Good to approve for 69 tomorrow just to give a bit more time in Canary
NextAction: 2018-08-08
The NextAction date has arrived: 2018-08-08
How is the change looking in canary?
Cc: hablich@chromium.org jkummerow@chromium.org
+jkummerow@ (CL reviewer), PTAL comment #18 and #21. Thank you.
Labels: -Hotlist-Merge-Review -M-69 -Target-69 -Merge-Review-69
This is the same situation as  crbug.com/866282#c24 . M69 is not affected. Sheriffbot should learn to look at actual branches for DEPS'ed in projects, not just commit dates.
Project Member

Comment 24 by sheriffbot@chromium.org, Aug 14

Labels: M-69 Target-69
Labels: -ReleaseBlock-Stable -M-69 -Target-69 Target-70 M-70
Project Member

Comment 26 by sheriffbot@chromium.org, Nov 11

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment