Want r337640 for  issue 846464 .

r338331 for issue 783296

I packaged r338331 last night, let's see if it goes through the CQ:
https://chromium-review.googlesource.com/c/chromium/src/+/1155925

We'll need a new package. There are two issues that need to be fixed before we can roll:

1. I reopened  issue 869067 , more cleanup is needed for reference temporaries.
2. https://reviews.llvm.org/D15225 is causing problems with Mac ASan and goma. There's no way our ToT waterfall could've seen this because it requires making goma packages. Our in-tree package.py script includes the relevant runtime libs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa73d4c41de3725b9d7fa2dc45da148dfa8cb71

commit aaa73d4c41de3725b9d7fa2dc45da148dfa8cb71
Author: Max Moroz <mmoroz@chromium.org>
Date: Wed Aug 01 17:53:01 2018

Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686.

This change removes 6+ MB of binaries from the build tools bundle:
3.7M	lib/linux/libclang_rt.asan-i686-android.so
2.5M	lib/linux/libclang_rt.ubsan_standalone-i686-android.so
80K	lib/linux/libclang_rt.profile-i686-android.a

It also can break some workflows, but as discussed in person, there is a good
chance that no one is using those libraries on i686 arch.


Bug:  866225 
Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3
Reviewed-on: https://chromium-review.googlesource.com/1158708
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579854}
[modify] https://crrev.com/aaa73d4c41de3725b9d7fa2dc45da148dfa8cb71/tools/clang/scripts/update.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc14e55b5cd9359e09aa9b8aa8795b100031abfb

commit cc14e55b5cd9359e09aa9b8aa8795b100031abfb
Author: Reid Kleckner <rnk@google.com>
Date: Wed Aug 01 20:32:48 2018

Roll clang 337439:338452.

Bug:  866225 
Change-Id: I11d97d9a97432a1abb97e69a1395948b9d3e19fe
Reviewed-on: https://chromium-review.googlesource.com/1157290
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579922}
[modify] https://crrev.com/cc14e55b5cd9359e09aa9b8aa8795b100031abfb/tools/clang/scripts/update.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23e601d76661af13a654d9cfee5cae586a105e7b

commit 23e601d76661af13a654d9cfee5cae586a105e7b
Author: Max Moroz <mmoroz@chromium.org>
Date: Thu Aug 02 14:56:31 2018

Revert "Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686."

This reverts commit aaa73d4c41de3725b9d7fa2dc45da148dfa8cb71.

Reason for revert: Apparently glob.glob doesn't work with expressions line {value1,value2} :(

Original change's description:
> Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686.
> 
> This change removes 6+ MB of binaries from the build tools bundle:
> 3.7M	lib/linux/libclang_rt.asan-i686-android.so
> 2.5M	lib/linux/libclang_rt.ubsan_standalone-i686-android.so
> 80K	lib/linux/libclang_rt.profile-i686-android.a
> 
> It also can break some workflows, but as discussed in person, there is a good
> chance that no one is using those libraries on i686 arch.
> 
> 
> Bug:  866225 
> Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3
> Reviewed-on: https://chromium-review.googlesource.com/1158708
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Max Moroz <mmoroz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579854}

TBR=thakis@chromium.org,hans@chromium.org,mmoroz@chromium.org

Change-Id: Ic009c159a98be684a9dec8ea5aec364e83d7389d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866225 
Reviewed-on: https://chromium-review.googlesource.com/1160801
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580179}
[modify] https://crrev.com/23e601d76661af13a654d9cfee5cae586a105e7b/tools/clang/scripts/update.py

Next roll is  issue 871418 .

This clang roll may cause
https://bugs.chromium.org/p/chromium/issues/detail?id=870907&desc=2#c12

Do you know something about this iOS clang change?

Nothing in https://bugs.chromium.org/p/chromium/issues/detail?id=870907&desc=2#c12 suggests that the clang roll has anything to do with that issue -- it sounds like build output became 50 GB larger and because of that caching breaks (?) Why do you think it's related? Have you built chrome/iOS with old and new compiler and verified that it caused much larger output? From a distance, this sounds like something not caused by a compiler update since 50GB is a _lot_ of additional data.

It does appear to be due to the clang roll. Doesn't seem to be a revertible offense atm, so filed  bug 872926  to track it.

a 50 GB increase in the build output size is definitely a revertible offense unless there's a really good explanation for it and we planned for it ahead of time. We are reverting it for now to confirm that it's the cause and to restore our capacity as per  bug 870907 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8457b638ed3550460518321e4a4a21b08c2e30f9

commit 8457b638ed3550460518321e4a4a21b08c2e30f9
Author: Reid Kleckner <rnk@chromium.org>
Date: Fri Aug 10 02:44:48 2018

Revert "Roll clang 337439:338452."

This reverts commit cc14e55b5cd9359e09aa9b8aa8795b100031abfb.

Reason for revert:
The new version of clang appears to have regressed -O0 code size significantly ( https://crbug.com/870907 )

Original change's description:
> Roll clang 337439:338452.
>
> Bug:  866225 
> Change-Id: I11d97d9a97432a1abb97e69a1395948b9d3e19fe
> Reviewed-on: https://chromium-review.googlesource.com/1157290
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579922}

TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org
NOTRY=true

Bug:  866225 ,  870907 
Change-Id: I39ac706d7fc4191d4519f1692f927788a072a081
Reviewed-on: https://chromium-review.googlesource.com/1170006
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582026}
[modify] https://crrev.com/8457b638ed3550460518321e4a4a21b08c2e30f9/tools/clang/scripts/update.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d74b4a7338023093d2cc0ada1c8d9964e1f1faf8

commit d74b4a7338023093d2cc0ada1c8d9964e1f1faf8
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Aug 14 17:08:19 2018

Re-land "Roll clang 337439:338452."

And configure libc++ to force inline ABI-hidden functions, as was its behaviour
before r338122. Without this, the symbol tables of Mach-O binaries grow
significantly due to including multiple definitions of these functions.

Bug:  866225 ,  870907 ,  872926 
Change-Id: I4382e9de57fc79b3baff3d329e338887cb4b133b
Reviewed-on: https://chromium-review.googlesource.com/1174546
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582951}
[modify] https://crrev.com/d74b4a7338023093d2cc0ada1c8d9964e1f1faf8/build/config/compiler/BUILD.gn
[modify] https://crrev.com/d74b4a7338023093d2cc0ada1c8d9964e1f1faf8/tools/clang/scripts/update.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdcf168ccdaf03e6fb1a14665f36821e17241ba6

commit cdcf168ccdaf03e6fb1a14665f36821e17241ba6
Author: Max Moroz <mmoroz@chromium.org>
Date: Fri Aug 24 06:54:27 2018

Partial revert of "Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686.".

This reverts commit 1501aabf48bc0a5923275752de739dceb0dc810c.

Reason for revert: broke a build that was used for fuzzing: crbug.com/877063.

Original change's description:
> Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686.
>
> This change removes 6+ MB of binaries from the build tools bundle:
> 3.7M	lib/linux/libclang_rt.asan-i686-android.so
> 2.5M	lib/linux/libclang_rt.ubsan_standalone-i686-android.so
> 80K	lib/linux/libclang_rt.profile-i686-android.a
>
> It also can break some workflows, but as discussed in person, there is a good
> chance that no one is using those libraries on i686 arch.
>
>
> Bug:  866225 
> Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3
> Reviewed-on: https://chromium-review.googlesource.com/1158708
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Max Moroz <mmoroz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579854}


R=hans@chromium.org, inferno@chromium.org, thakis@chromium.org

Bug: 877063
Change-Id: Ic5754458e6516dc25cf4cedaeb7eb9195faafbec
Reviewed-on: https://chromium-review.googlesource.com/1187629
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585731}
[modify] https://crrev.com/cdcf168ccdaf03e6fb1a14665f36821e17241ba6/tools/clang/scripts/update.py

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/895a545147a5b8d2850b2dcd34fd4e3dae9d0f4b

commit 895a545147a5b8d2850b2dcd34fd4e3dae9d0f4b
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Sep 06 19:44:35 2018