New issue
Advanced search Search tips

Issue 866212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 866092

Blocking:
issue 871795



Sign in to add a comment

ResourceLoadingHintsBrowserTest.ResourceLoadingHintsHttpsNoWhitelisted is flaky on Linux

Project Member Reported by kbr@chromium.org, Jul 21

Issue description

Seen here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/146289

Previously reported flaky on Windows. Now observed on Linux.

Please disable this test on all platforms until the root cause is addressed.

Not sure what component to use. src/components/previews/OWNERS says UI>Browser>Previews but that doesn't exist any more.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dcd9de126d3382609324cf5d743bb1eecd910bf

commit 9dcd9de126d3382609324cf5d743bb1eecd910bf
Author: Tarun Bansal <tbansal@chromium.org>
Date: Sat Jul 21 06:45:19 2018

Attempt to deflake resource loading hints test

Bug:  866212 
Change-Id: Ia74a20e7061590fafadf69ac13ac595f1c6c4f8e
TBR: dougarnett@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1146060
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577074}
[modify] https://crrev.com/9dcd9de126d3382609324cf5d743bb1eecd910bf/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

 Issue 866271  has been merged into this issue.
 Issue 866224  has been merged into this issue.
 Issue 866220  has been merged into this issue.
Owner: tbansal@chromium.org
Status: Fixed (was: Untriaged)
Seems to be fixed
Cc: timloh@chromium.org
Sorry, I misread the flakiness data. Disabling these tests now: https://chromium-review.googlesource.com/c/chromium/src/+/1146532
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b161ba1ec6b59f634c339fc37b35085496359195

commit b161ba1ec6b59f634c339fc37b35085496359195
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Jul 23 09:04:36 2018

Disable flaky ResourceLoadingHintsBrowserTest tests on Linux

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=ResourceLoadingHintsBrowserTest.ResourceLoadingHints

TBR=tbansal

Bug:  866212 
Change-Id: Ie4e1ff6848b2b28d7daf98a74057296a6de2a5df
Reviewed-on: https://chromium-review.googlesource.com/1146532
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577126}
[modify] https://crrev.com/b161ba1ec6b59f634c339fc37b35085496359195/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

Components: -Tests>Flaky
Status: Assigned (was: Fixed)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762a6a7d62fadf2dacd5d125c984f8ee961ab707

commit 762a6a7d62fadf2dacd5d125c984f8ee961ab707
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Aug 13 22:59:21 2018

Reenable ResourceLoadingHintsBrowserTest on Linux

The plan is to keep a close eye on bots, and disable the tests back
if we see flakiness.

This CL will help us understand which of the tests are failing,
and also get a stack trace (which is now lost).

Bug:  866212 
Change-Id: I94ff8ffb7278eff1ad3533d7872c1781e1e38b67
Reviewed-on: https://chromium-review.googlesource.com/1173443
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582730}
[modify] https://crrev.com/762a6a7d62fadf2dacd5d125c984f8ee961ab707/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8399dbaefcc6808ff83b8731fd9a954297a18fb9

commit 8399dbaefcc6808ff83b8731fd9a954297a18fb9
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Aug 14 04:20:21 2018

Revert "Reenable ResourceLoadingHintsBrowserTest on Linux"

This reverts commit 762a6a7d62fadf2dacd5d125c984f8ee961ab707.

Reason for revert: It looks still flaky.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=ResourceLoadingHintsBrowserTest.ResourceLoadingHintsHttp%0AResourceLoadingHintsBrowserTest

Original change's description:
> Reenable ResourceLoadingHintsBrowserTest on Linux
> 
> The plan is to keep a close eye on bots, and disable the tests back
> if we see flakiness.
> 
> This CL will help us understand which of the tests are failing,
> and also get a stack trace (which is now lost).
> 
> Bug:  866212 
> Change-Id: I94ff8ffb7278eff1ad3533d7872c1781e1e38b67
> Reviewed-on: https://chromium-review.googlesource.com/1173443
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582730}

TBR=tbansal@chromium.org,ryansturm@chromium.org

Change-Id: Ic7974e852ddb12daadb956d38b54a94bc2f8096d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  866212 
Reviewed-on: https://chromium-review.googlesource.com/1173971
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582829}
[modify] https://crrev.com/8399dbaefcc6808ff83b8731fd9a954297a18fb9/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

 Issue 874085  has been merged into this issue.
Labels: -Sheriff-Chromium
The tests are disabled. Let me remove the sheriff label.
Blocking: 871795
Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90c56ded9bfe169c3a6e19053f5f900154dfb321

commit 90c56ded9bfe169c3a6e19053f5f900154dfb321
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Sep 05 23:11:27 2018

Attempt to fix flaky resource loading hints test

Fix the flakiness by checking if all the subresources have
been actually fetched. This check is not really necessary since
the test additionally checks (via UMA) if the resource loading
hints were actually received by the renderer. The tests still check
if the resources that were vlocked via hints are indeed blocked from
loading.

Change-Id: I931570b73068250636916b0c234d17648976c84c
Bug:  866212 
Reviewed-on: https://chromium-review.googlesource.com/1203321
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589050}
[modify] https://crrev.com/90c56ded9bfe169c3a6e19053f5f900154dfb321/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment