CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered in webkit_unit_tests failing on linux_chromium_rel_ng |
|||
Issue descriptionSeen here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/146289 [ RUN ] CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered Received signal 11 SEGV_MAPERR 000000000068 #0 0x0000047ae3fc base::debug::StackTrace::StackTrace() #1 0x0000047adf71 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f1116842330 <unknown> #3 0x0000051dd428 blink::Canvas2DLayerBridge::NewImageSnapshot() #4 0x000005c21b1f blink::HTMLCanvasElement::FinalizeFrame() #5 0x00000426da94 blink::CanvasRenderingContext2DTest::DrawSomething() #6 0x000004273c69 blink::CanvasRenderingContext2DTest_LowLatencyIsSingleBuffered_Test::TestBody() #7 0x000002997562 testing::Test::Run() #8 0x0000029980b0 testing::TestInfo::Run() #9 0x0000029985c7 testing::TestCase::Run() #10 0x0000029a3ec7 testing::internal::UnitTestImpl::RunAllTests() #11 0x0000029a3a3d testing::UnitTest::Run() #12 0x000006b65d21 base::TestSuite::Run() #13 0x0000013fb446 (anonymous namespace)::runHelper() #14 0x000006b680cd base::(anonymous namespace)::LaunchUnitTestsInternal() #15 0x000006b67f21 base::LaunchUnitTests() #16 0x0000013fb3c0 main #17 0x7f1113a4bf45 __libc_start_main #18 0x0000013fa02a _start This is affecting the CQ. Marking P1. Not sure if this is a new test; if it is it should be reverted.
,
Jul 23
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeabd72a10ef61fb282866417a2721127622762b commit aeabd72a10ef61fb282866417a2721127622762b Author: Timothy Loh <timloh@chromium.org> Date: Mon Jul 23 03:49:56 2018 Revert "Add a single buffered mode to CanvasResourceProvider" This reverts commit 5c4bc1ff53af81b21ba55479c492e085cfd10ec2. Reason for revert: CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered failing I suppose this depended on https://chromium-review.googlesource.com/c/1144602/, which was reverted, so the test this CL adds is failing now. Original change's description: > Add a single buffered mode to CanvasResourceProvider > > This CL completes the initial implementation of Low Latency mode for 2d > canvases > > Bug: 788439 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9 > Reviewed-on: https://chromium-review.googlesource.com/1145235 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576962} TBR=junov@chromium.org,fserb@chromium.org NOTRY=TRUE Bug: 788439, 866211 Change-Id: I8e976b4cb6aca452f6d1891677e35e4411e2a5e4 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1146460 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577108} [modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc [modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc [modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc [modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
,
Jul 23
Revert looks good
,
Jul 23
|
|||
►
Sign in to add a comment |
|||
Comment 1 by timloh@chromium.org
, Jul 23