"MimeHandlerViewTests/MimeHandlerViewTest.BeforeUnload_ShowDialog/1" is flaky |
||||
Issue description"MimeHandlerViewTests/MimeHandlerViewTest.BeforeUnload_ShowDialog/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJNaW1lSGFuZGxlclZpZXdUZXN0cy9NaW1lSGFuZGxlclZpZXdUZXN0LkJlZm9yZVVubG9hZF9TaG93RGlhbG9nLzEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jul 23
,
Jul 23
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd1cb805ed7421efa2b0b394af32623bef3ab62e commit dd1cb805ed7421efa2b0b394af32623bef3ab62e Author: Sam McNally <sammc@chromium.org> Date: Mon Jul 23 08:46:19 2018 Deflake MimeHandlerViewTest.BeforeUnload_*. Wait for IPC propagation to ensure the tests do not try to navigate before the beforeunload handler registration has informed the browser. Also, use a navigation instead of a reload to avoid ending up back at the page with a beforeunload handler during shutdown, causing shutdown to be blocked by a beforeunload dialog. TBR=rdevlin.cronin@chromium.org Bug: 866209 Change-Id: Id7c34e7a371f10f05297ea6cd3e3addeef75a49b Reviewed-on: https://chromium-review.googlesource.com/1146528 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577125} [modify] https://crrev.com/dd1cb805ed7421efa2b0b394af32623bef3ab62e/chrome/test/data/extensions/api_test/mime_handler_view/index.js [modify] https://crrev.com/dd1cb805ed7421efa2b0b394af32623bef3ab62e/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
,
Jul 25
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Jul 22