New issue
Advanced search Search tips

Issue 866203 link

Starred by 1 user
Status: Fixed
Owner:
xiaochu@chromium.org
Closed: Aug 6
Cc:
norvez@chromium.org
kerrnel@chromium.org
vapier@chromium.org
ahass...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 852167



Sign in to add a comment

move imageloader/manifest.* to libbrillo

Project Member Reported by xiaochu@chromium.org, Jul 21 
imageloader/manifest.* is shared by imageloader&dlcservice. Instead of duplicating the code, we probably add them to libbrillo to share the code.

Proposal for the new locations:
libbrillo/brillo/imageloader/manifest.h
libbrillo/brillo/imageloader/manifest.cc

Comment 1 by xiaochu@chromium.org, Jul 21

Description: Show this description

Comment 2 by xiaochu@chromium.org, Jul 21

Cc: ahass...@chromium.org vapier@chromium.org kerrnel@chromium.org norvez@chromium.org

Comment 3 by xiaochu@chromium.org, Jul 21

Blocking: 852167

Comment 4 by xiaochu@chromium.org, Jul 23

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/d88bc3e668d298b215c48fd45cff96901cb6bd85

commit d88bc3e668d298b215c48fd45cff96901cb6bd85
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Wed Aug 01 07:05:33 2018

move manifest* from imageloader to libbrillo

We move them to libbrillo so it could be shared by
imageloader&dlcservice.

BUG= chromium:866203 
TEST=unittest

Change-Id: Id6e1f898d69c5cb1d4d291147482248ee3578f03
Reviewed-on: https://chromium-review.googlesource.com/1147249
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/d88bc3e668d298b215c48fd45cff96901cb6bd85/libbrillo.gypi
[add] https://crrev.com/d88bc3e668d298b215c48fd45cff96901cb6bd85/brillo/imageloader/manifest.cc
[add] https://crrev.com/d88bc3e668d298b215c48fd45cff96901cb6bd85/brillo/imageloader/manifest.h
[add] https://crrev.com/d88bc3e668d298b215c48fd45cff96901cb6bd85/brillo/imageloader/manifest_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/646339e066502e6acdc6caef29982d753c372e17

commit 646339e066502e6acdc6caef29982d753c372e17
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Aug 02 20:53:49 2018

imageloader: use the manifest in libbrillo

* remove manifest* from this repo
* change to use manfiest* in libbrillo

BUG= chromium:866203 
TEST=unittest
CQ-DEPEND=1147249

Change-Id: Ie42c9eac02f6090974603ced85dfd8be5b2656ae
Reviewed-on: https://chromium-review.googlesource.com/1147750
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/helper_process_proxy.cc
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/helper_process_proxy.h
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/imageloader_unittest.cc
[delete] https://crrev.com/d1191f2d1c3c3e5ed7cb2d7dc02d16d75e0a6a2c/imageloader/manifest.cc
[delete] https://crrev.com/d1191f2d1c3c3e5ed7cb2d7dc02d16d75e0a6a2c/imageloader/manifest.h
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/dlc.cc
[delete] https://crrev.com/d1191f2d1c3c3e5ed7cb2d7dc02d16d75e0a6a2c/imageloader/manifest_unittest.cc
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/dlc_unittest.cc
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/component.h
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/imageloader.gyp
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/component.cc
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/mock_helper_process_proxy.h
[modify] https://crrev.com/646339e066502e6acdc6caef29982d753c372e17/imageloader/component_unittest.cc

Comment 7 by xiaochu@chromium.org, Aug 6

Status: Fixed (was: Untriaged)
►

Sign in to add a comment