New issue
Advanced search Search tips

Issue 866202 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 31
Cc:
h...@chromium.org
thakis@chromium.org
inglorion@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clang's new -Wmemset-transposed-args fires on ffmpeg

Project Member Reported by r...@chromium.org, Jul 21 
ToT clang produces this warning:

[8047/53792] CC obj/third_party/ffmpeg/ffmpeg_internal/options.o
FAILED: obj/third_party/ffmpeg/ffmpeg_internal/options.o
...
../../third_party/ffmpeg/libavcodec/options.c:273:64: error: 'size' argument to memset is '0'; did you mean to transpose the last two arguments? [-Werror,-Wmemset-transposed-args]
alloc_and_copy_or_fail(intra_matrix, 64 * sizeof(int16_t), 0);
^
../../third_party/ffmpeg/libavcodec/options.c:273:64: note: parenthesize the third argument to silence
../../third_party/ffmpeg/libavcodec/options.c:274:64: error: 'size' argument to memset is '0'; did you mean to transpose the last two arguments? [-Werror,-Wmemset-transposed-args]
alloc_and_copy_or_fail(inter_matrix, 64 * sizeof(int16_t), 0);
^
../../third_party/ffmpeg/libavcodec/options.c:274:64: note: parenthesize the third argument to silence
../../third_party/ffmpeg/libavcodec/options.c:275:94: error: 'size' argument to memset is '0'; did you mean to transpose the last two arguments? [-Werror,-Wmemset-transposed-args]
alloc_and_copy_or_fail(rc_override,  src->rc_override_count * sizeof(*src->rc_override), 0);
^
../../third_party/ffmpeg/libavcodec/options.c:275:94: note: parenthesize the third argument to silence

It's from a macro, though, so it's a false positive.

I'm going to disable it in a second.

Comment 1 by r...@chromium.org, Jul 21 

Hopefully https://chromium-review.googlesource.com/c/chromium/src/+/1145887 will green our ToT bots.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c0d3d2d1164f16fb7c542ee058c0b1a791d00a

commit 24c0d3d2d1164f16fb7c542ee058c0b1a791d00a
Author: Reid Kleckner <rnk@google.com>
Date: Sat Jul 21 01:40:33 2018

Disable -Wmemset-transposed-args when building with ToT clang

This warning has a few false positives in ffmpeg.

TBR=thakis@chromium.org
BUG= 866202 

Change-Id: I08634bdeabe6e30225d37941b078c540c21a74bc
Reviewed-on: https://chromium-review.googlesource.com/1145887
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577055}
[modify] https://crrev.com/24c0d3d2d1164f16fb7c542ee058c0b1a791d00a/build/config/compiler/BUILD.gn

Comment 3 by thakis@chromium.org, Jul 22 

I mentioned this on cfe-commits, and quuxplusone had a good suggestion: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180716/235513.html So hopefully erik.pilkington will implement this and we can just turn this on again without any code changes.

Comment 4 by thakis@chromium.org, Jul 24 

http://llvm.org/viewvc/llvm-project?view=revision&revision=337706 probably helped with the ffmpeg case. Should we try reverting #577055 and see how the bots do?
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b73adaf4a5d5ba05236cf3d2096137de1d938b

commit a5b73adaf4a5d5ba05236cf3d2096137de1d938b
Author: Reid Kleckner <rnk@chromium.org>
Date: Mon Jul 30 22:49:16 2018

Revert "Disable -Wmemset-transposed-args when building with ToT clang"

This reverts commit 24c0d3d2d1164f16fb7c542ee058c0b1a791d00a.

Reason for revert: Try the warning again after Clang r337706.

Original change's description:
> Disable -Wmemset-transposed-args when building with ToT clang
> 
> This warning has a few false positives in ffmpeg.
> 
> TBR=thakis@chromium.org
> BUG= 866202 
> 
> Change-Id: I08634bdeabe6e30225d37941b078c540c21a74bc
> Reviewed-on: https://chromium-review.googlesource.com/1145887
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577055}

TBR=thakis@chromium.org,rnk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  866202 
Change-Id: I2d2dceca60f19b20554f96dea0c7d8bb2dc6792d
Reviewed-on: https://chromium-review.googlesource.com/1155497
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579213}
[modify] https://crrev.com/a5b73adaf4a5d5ba05236cf3d2096137de1d938b/build/config/compiler/BUILD.gn

Comment 7 by dtapu...@chromium.org, Aug 31

Status: Fixed (was: Untriaged)
►

Sign in to add a comment