New issue
Advanced search Search tips

Issue 866201 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
M-X



Sign in to add a comment

Increase padding of left-most tab if single-tab mode is off

Project Member Reported by bettes@chromium.org, Jul 21

Issue description

What is the expected result?

If single tab mode is not enabled, we should add 8dp to the left most tab to give it some breathing room. 

This shouldn't be applied to Mac


What happens instead?

The tabs were originally spec'd to be flush against the window because its location worked seamlessly in and out of single tab mode. 

https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZW9TjXpqhOa9/files/MCHY41TzXRKqENy0cCjkrJyrwMSJbxAVNpw
 
Screen Shot 2018-07-20 at 4.58.56 PM.png
206 KB View Download
Cc: robliao@chromium.org
Labels: -Restrict-View-Google -Hotlist-Teamfood-Feedback Proj-MdRefresh
Owner: ----
Status: Untriaged (was: Accepted)
Labels: -Pri-2 Hotlist-Polish Pri-1
Status: Available (was: Untriaged)
Cc: kylixrd@chromium.org pkasting@chromium.org
pkasting@ or kylixrd@: Is adding a left padding to the tabstrip a simple change or an involved change?
Complicated, given that we still have both single-tab mode and leading-NTB in the codebase and we have to work correctly with those.  And the "this shouldn't apply to Mac" rule -- which is possibly also true of Windows RTL, except in the case of high contrast, in which case the caption buttons are on the other side -- makes it even more complicated.

Until I fixed this recently (which took a week of work), we actually had the padding requested in at least some cases, and it looked very strange.

I don't think we should try to fit this into M-69 due to the complexity.  If Alan still feels strongly about it in the M-70 timeframe, we can try experimenting with it then.
Components: UI>Browser>TabStrip
Labels: Group-Tabstrip
Labels: M-X
Moving this to P2 till we resolve  issue 841643  priorities
Labels: -Pri-1 Pri-2
Labels: -Proj-MdRefresh Proj-DesktopUI
Labels: Hotlist-DesktopUITriaged

Sign in to add a comment