New issue
Advanced search Search tips

Issue 866197 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crosvm rename aarch64 seccomp to arm

Project Member Reported by sonnyrao@chromium.org, Jul 20

Issue description

crosvm names it's seccomp policy aarch64 but it's really for the 32-bit syscalls, let's make it more consistent
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3212979ffeb10f35d2fbc2d1da1dbd38270b84fb

commit 3212979ffeb10f35d2fbc2d1da1dbd38270b84fb
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Tue Jul 24 04:04:38 2018

crosvm: fix name of seccomp_arch on arm

crosvm current calls it's seccomp policy aarch64 (because that's the
target) but crosvm itself is build as 32-bit and uses the the 32-bit
syscalls, let's make it more consistent.

CQ-DEPEND=CL:1145909
BUG= chromium:866197 
TEST=emerge-kevin crosvm, check for policies in
/usr/share/policy/crosvm/ and run vm_CrosVmStart

Change-Id: If72b971cd87e90b7d77317cb2539cd66f94b0d28
Reviewed-on: https://chromium-review.googlesource.com/1145903
Commit-Ready: Sonny Rao <sonnyrao@chromium.org>
Tested-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/3212979ffeb10f35d2fbc2d1da1dbd38270b84fb/chromeos-base/crosvm/crosvm-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b847858e66d58a3bf7506f43f1a22781014a527e

commit b847858e66d58a3bf7506f43f1a22781014a527e
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Tue Jul 24 04:04:38 2018

seccomp: rename aarch64 -> arm

These policies are not for aarch64 but use the 32-bit system calls.
We call it aarch64 support because that's what we're targetting for
the guest kernel, but it doesn't really make any sense to call the
seccomp policies aarch64 when we're building a 32-bit binary.
We can add real aarch64 seccomp policies when we start building a
aarch64 crosvm binary.

BUG= chromium:866197 
TEST=emerge-kevin crosvm, run vm_CrosVmStart
CQ-DEPEND=CL:1145903

Change-Id: I7c5e70fbc127e4209ed392cfcf10ea36a6dd4b2c
Reviewed-on: https://chromium-review.googlesource.com/1145909
Commit-Ready: Sonny Rao <sonnyrao@chromium.org>
Tested-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/block_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/vhost_vsock_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/net_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/rng_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/wl_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/balloon_device.policy
[rename] https://crrev.com/b847858e66d58a3bf7506f43f1a22781014a527e/seccomp/arm/vhost_net_device.policy

Status: Fixed (was: Assigned)

Sign in to add a comment