New issue
Advanced search Search tips

Issue 866196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression on old wallpaper picker: Custom category is not clickable any more after setting an online wallpaper

Project Member Reported by wzang@chromium.org, Jul 20

Issue description

Need to fix this since the new wallpaper picker is punted to M70.

This is a regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1093742

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e9b094f93c5e6c77d3206c2a3efd17c4dcdd6f8

commit 1e9b094f93c5e6c77d3206c2a3efd17c4dcdd6f8
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Jul 21 01:51:45 2018

cros: Add |highResolutionURL| field to old wallpaper picker images

1) This code path is only used by old wallpaper picker.

2) |highResolutionURL| was added to new wallpaper picker images only,
   but the code paths shared by new and old pickers may access this
   field. For consistency, add this field to the old images as well
   (an alternative is to check the flag, but it's less clean.)

Bug:  866196 
Change-Id: Ia948f49090029441408f4fcb6498403ea09147a9
Reviewed-on: https://chromium-review.googlesource.com/1145879
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577056}
[modify] https://crrev.com/1e9b094f93c5e6c77d3206c2a3efd17c4dcdd6f8/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Status: Fixed (was: Started)
Labels: Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 24

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56bb9e85179e50c4ca01fb27c45e90a59d0828bd

commit 56bb9e85179e50c4ca01fb27c45e90a59d0828bd
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Jul 24 18:18:23 2018

[Merge to M69] cros: Add |highResolutionURL| field to old wallpaper picker images

1) This code path is only used by old wallpaper picker.

2) |highResolutionURL| was added to new wallpaper picker images only,
   but the code paths shared by new and old pickers may access this
   field. For consistency, add this field to the old images as well
   (an alternative is to check the flag, but it's less clean.)

TBR=wzang@chromium.org

(cherry picked from commit 1e9b094f93c5e6c77d3206c2a3efd17c4dcdd6f8)

Bug:  866196 
Change-Id: Ia948f49090029441408f4fcb6498403ea09147a9
Reviewed-on: https://chromium-review.googlesource.com/1145879
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577056}
Reviewed-on: https://chromium-review.googlesource.com/1148691
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#45}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/56bb9e85179e50c4ca01fb27c45e90a59d0828bd/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Sign in to add a comment