New issue
Advanced search Search tips

Issue 866191 link

Starred by 3 users
Status: Fixed
Owner:
manukh@chromium.org
Closed: Aug 27
Cc:
manukh@chromium.org
markchang@chromium.org
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Reduce padding between page actions

Project Member Reported by bettes@chromium.org, Jul 20 
What is the expected result?
Page actions should have 0 padding between each

What happens instead?
4dp padding
Screen Shot 2018-07-20 at 4.35.57 PM.png
89.3 KB View Download

Comment 1 by markchang@chromium.org, Jul 24

Labels: -Restrict-View-Google -Hotlist-Teamfood-Feedback Proj-MdRefresh
Owner: ----
Status: Untriaged (was: Accepted)

Comment 2 by markchang@chromium.org, Jul 24

Labels: -Pri-2 Hotlist-Polish Pri-3
Status: Available (was: Untriaged)

Comment 3 by meh...@chromium.org, Jul 25

Components: UI>Browser>Omnibox

Comment 4 by robliao@chromium.org, Jul 31

Labels: Group-Omnibox

Comment 5 by jdonnelly@chromium.org, Aug 21

Labels: Pri-2

Comment 6 by jdonnelly@chromium.org, Aug 21

Owner: manukh@chromium.org

Comment 7 by manukh@chromium.org, Aug 22

Status: Started (was: Available)

Comment 8 Deleted

Comment 9 by manukh@chromium.org, Aug 22 

bettes@
I assume this change applies to both material refresh and touch refresh?

attached are screenshots of:
material refresh with current padding (4px)
material refresh with removed padding
touch refresh with current padding (6px)
touch refresh with removed padding
refresh 4px.png
35.2 KB View Download
refresh 0px.png
35.2 KB View Download
touch 6px.png
78.7 KB View Download
touch 0px.png
78.6 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3

commit a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3
Author: manuk <manukh@chromium.org>
Date: Mon Aug 27 15:14:08 2018

Remove padding between page action icons in the location bar.

This cl removes horizontal white-space between adjacent page actions' hover circles. White-space will remain between the icons visually, as the icons are smaller than their hover circles. Padding between the page actions and the location bar remains unchanged. This only affects material refresh and touchable material refresh.

Bug:  866191 
Change-Id: I8b48256a068fc5078c6c4bcb558ab9cd68763e91
Reviewed-on: https://chromium-review.googlesource.com/1185531
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586266}
[modify] https://crrev.com/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3/chrome/browser/ui/views/location_bar/location_bar_layout.cc
[modify] https://crrev.com/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3/chrome/browser/ui/views/location_bar/location_bar_layout.h
[modify] https://crrev.com/a852107fdbd4dc9d4fc7293bdc1953c18c40a6c3/chrome/browser/ui/views/location_bar/location_bar_view.cc

Comment 11 by manukh@chromium.org, Aug 27

Status: Fixed (was: Started)

Comment 12 by tommycli@chromium.org, Aug 28

Cc: bettes@chromium.org markchang@chromium.org manukh@chromium.org
 Issue 876516  has been merged into this issue.
►

Sign in to add a comment