Don't show omnibox_hover when hovering over page actions, lock icon, bookmarks |
|||||
Issue descriptionWhat is the expected result? Omnibox hover and bookmark star hover should never appear on top of each other. Don't show the omnibox hover when your cursor is within the 32x32 boundary. What happens instead? Both hover states appear, reducing the necessary contrast needed.
,
Jul 25
The Omnibox hover effect was introduced in issue 853241 . Maybe it helps.
,
Jul 26
,
Jul 27
orinj: take a look at how the "Switch to open tab" button reacts to hover. We basically want the same thing here.
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fcc31f365c2d7ab330ef224aeb708969f9bb063 commit 2fcc31f365c2d7ab330ef224aeb708969f9bb063 Author: Orin Jaworski <orinj@chromium.org> Date: Wed Aug 01 00:10:04 2018 [omnibox] Change mouse event handling for omnibox hover The location bar was getting a hover effect when the mouse was anywhere within (in omnibox, in bookmarks star, etc.) but having child view hover effects on top of the location bar hover effect was interfering with contrast. Now only the OmniboxViewViews will trigger the location bar hover effect, and mousing into other children will turn it off. This ensures contrast and is consistent with the interaction logic - specifically, the mouse cursor changing to a text insertion bar and the omnibox becoming clickable for edit. Bug: 866190 Change-Id: I7e04131a4a0d0533aeb13842fb6889ecee990750 Reviewed-on: https://chromium-review.googlesource.com/1153976 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#579630} [modify] https://crrev.com/2fcc31f365c2d7ab330ef224aeb708969f9bb063/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/2fcc31f365c2d7ab330ef224aeb708969f9bb063/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/2fcc31f365c2d7ab330ef224aeb708969f9bb063/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/2fcc31f365c2d7ab330ef224aeb708969f9bb063/chrome/browser/ui/views/omnibox/omnibox_view_views.h
,
Aug 2
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by markchang@chromium.org
, Jul 24Owner: jdonnelly@chromium.org
Status: Untriaged (was: Accepted)