Hmm... well the actual favicon is square.

The real question to me is why the favicons in the suggestions dropdown are rounded.

This can be tested with the facebook.com favicon as well.

dschuyler: Hey Dave -- is there anything in the ImageView class that might be rounding off the favicons?

Yes, it should be the other way around (updated issue title to reflect this). We should modify sites' favicons. Even if we were tempted to do this in order to match our rounding preferences, it can produce odd-looking results (see, e.g. the calendar.google.com favicon).

The favicons are getting rounded here:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc?l=241&rcl=3df5254f608bfec7ee6407faed8c7232b935f318

I'm guessing that some series of changes inadvertently ended up with us applying the rounding intended for entity images to all suggestion images. Regardless, we should add an option to OmniboxImageView indicating whether we want rounding and limit it to the entity suggestions case.

CL out for review: https://crrev.com/c/1147503

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7468854e9384b3625bc473a5e513a2d1995664c

commit b7468854e9384b3625bc473a5e513a2d1995664c
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Jul 25 23:45:51 2018

Omnibox UI Refresh: Fix rounded favicons in suggestions.

Favicons for suggestions have been getting incorrectly rounded. This
led to a discrepency in how they appeared on the tab and location-bar
vs. the Omnibox suggestions.

This CL does a few things:

 1) Changes the icon_view_ member of OmniboxMatchCellView from the
    OmniboxImageView class (which rounds corners) to a plain ImageView.
    This fixes the heart of the bug.

 2) Renames OmniboxImageView => RoundedCornerImageView, to make things
    more explicit.

 3) Renames image_view_ to answer_image_view_ to make things more
    explicit. Also updates the comment to clarify that it's used for
    all suggestion answers, not just rich entities.

As a followup, we should investigate eliminating / refactoring
RoundedCornerImageView, as it appears (in the code) to apply the entity
image corner radius to all answers-in-suggest images.

But that's a less noticeable and separate concern.

Bug:  866187 
Change-Id: Ib35528e109d484dfca6013569c6cd52f71a8f6ae
Reviewed-on: https://chromium-review.googlesource.com/1147503
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578129}
[modify] https://crrev.com/b7468854e9384b3625bc473a5e513a2d1995664c/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/b7468854e9384b3625bc473a5e513a2d1995664c/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/b7468854e9384b3625bc473a5e513a2d1995664c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Confirmed in Canary that the above CL fixes it.

Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0374f19f45da427e18d3e24e70e33575c73cc8d3

commit 0374f19f45da427e18d3e24e70e33575c73cc8d3
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Jul 27 16:45:13 2018

Omnibox UI Refresh: Fix rounded favicons in suggestions.

Favicons for suggestions have been getting incorrectly rounded. This
led to a discrepency in how they appeared on the tab and location-bar
vs. the Omnibox suggestions.

This CL does a few things:

 1) Changes the icon_view_ member of OmniboxMatchCellView from the
    OmniboxImageView class (which rounds corners) to a plain ImageView.
    This fixes the heart of the bug.

 2) Renames OmniboxImageView => RoundedCornerImageView, to make things
    more explicit.

 3) Renames image_view_ to answer_image_view_ to make things more
    explicit. Also updates the comment to clarify that it's used for
    all suggestion answers, not just rich entities.

As a followup, we should investigate eliminating / refactoring
RoundedCornerImageView, as it appears (in the code) to apply the entity
image corner radius to all answers-in-suggest images.

But that's a less noticeable and separate concern.

Bug:  866187 
Change-Id: Ib35528e109d484dfca6013569c6cd52f71a8f6ae
Reviewed-on: https://chromium-review.googlesource.com/1147503
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578129}(cherry picked from commit b7468854e9384b3625bc473a5e513a2d1995664c)
Reviewed-on: https://chromium-review.googlesource.com/1153308
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#158}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/0374f19f45da427e18d3e24e70e33575c73cc8d3/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/0374f19f45da427e18d3e24e70e33575c73cc8d3/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/0374f19f45da427e18d3e24e70e33575c73cc8d3/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Able to reproduce the issue using Mac 10.13.5, Ubuntu 17.10 and Windows 10 on build without fix #69.0.3497.0.

Verified the fix on Mac 10.13.5, Ubuntu 17.10 and windows 10 on latest chrome version #69.0.3497.23 by following below steps.

Steps:
=====
1.Launched chrome
2.Enabled #omnibox-ui-show-suggestion-favicons flag
3.Entered facebook.com in the omnibar and able to see the square shaped favicon in the suggestions.

Attaching screen shot for reference.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!

Deleted: 866187.png 325 KB

	866187.png 325 KB View Download

+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh .