FindTextTest.FindText in pdf_unittests crashes with XFA enabled |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Set "pdf_enable_xfa = true" in the GN build config. (2) Build pdf_unittests. (3) Run pdf_unittests. What is the expected result? All tests pass. What happens instead? With some extra asserts added to see what is happening, FindTextTest.FindText crashes with: pdf_unittests: ../../ppapi/cpp/resource.cc:24: virtual pp::Resource::~Resource(): Assertion `Module::Get()' failed. #4 0x00000000021d6f72 in pp::Resource::~Resource() () at ../../ppapi/cpp/resource.cc:24 #5 0x0000000001229375 in pp::URLLoader::~URLLoader() () at ../../ppapi/cpp/url_loader.h:23 #6 0x000000000122645e in TestBody () at ../../pdf/pdfium/findtext_unittest.cc:178
,
Sep 26
The build config is borked. The "pdf" target thinks XFA is enabled, while the "pdf_unittests" target thinks it is not.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3625927238ab774dc1960f792edd5904b6911e58 commit 3625927238ab774dc1960f792edd5904b6911e58 Author: Lei Zhang <thestig@chromium.org> Date: Wed Sep 26 16:13:18 2018 Fix pdf_unittests build config. The build config for pdf_unittests needs to stay in sync with the "pdf" target. Extract out the build config into "pdf_common_config". BUG= 866182 Change-Id: I9fa8f5e89cd74ad28e7297dedce73a3aab143137 Reviewed-on: https://chromium-review.googlesource.com/1244977 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594333} [modify] https://crrev.com/3625927238ab774dc1960f792edd5904b6911e58/pdf/BUILD.gn
,
Sep 26
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Sep 26