New issue
Advanced search Search tips

Issue 866178 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Jul 24
Cc:
omrilio@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Other overview windows animate behind the snapped window

Project Member Reported by x...@chromium.org, Jul 20 
Chrome Version: 69.0.3497.0
OS: Chrome 

What steps will reproduce the problem?
(1) In tablet mode, open a few windows and enter overview mode
(2) Tap and drag an overview window to snap to one side of the screen, overview should now occupy the other side of the screen
(3) Tap on one overview window to select it 

What is the expected result?
The overview window should animate to its snapped position, and all other windows in overview should not animate

What happens instead?
The other windows also animate behind the snapped window
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c86f168ebe18f075d22aca89c84236eb1f4a8ca

commit 6c86f168ebe18f075d22aca89c84236eb1f4a8ca
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Jul 23 20:11:37 2018

Overview: fix the animation regression.

If one side of the screen is occupied by a split window, and the other
side of the screen is occupied by overview, select an overview window
should only animate the selected overview window to snap, and the other
windows should not animate.

Bug:  866178 
Change-Id: I1cb243ad61791a240227c6395770643603726a33
Reviewed-on: https://chromium-review.googlesource.com/1145836
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577230}
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/overview/window_grid.h
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/overview/window_selector.h
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/6c86f168ebe18f075d22aca89c84236eb1f4a8ca/ash/wm/splitview/split_view_controller_unittest.cc

Comment 2 by x...@chromium.org, Jul 24

Status: Fixed (was: Assigned)

Comment 3 by x...@chromium.org, Jul 24

Labels: Merge-Request-69
Should it merge back to 69?
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 25

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 30 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a

commit 6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Jul 30 18:24:43 2018

[Merge to M69] Overview: fix the animation regression.

If one side of the screen is occupied by a split window, and the other
side of the screen is occupied by overview, select an overview window
should only animate the selected overview window to snap, and the other
windows should not animate.

TBR=wutao@chromium.org
(cherry picked from commit 6c86f168ebe18f075d22aca89c84236eb1f4a8ca)

Bug:  866178 
Change-Id: I1cb243ad61791a240227c6395770643603726a33
Reviewed-on: https://chromium-review.googlesource.com/1145836
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577230}
Reviewed-on: https://chromium-review.googlesource.com/1155373
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#221}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/overview/window_grid.h
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/overview/window_selector.h
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/6edd5ffb18ceb9c015fd62d4c6b208889a5fb48a/ash/wm/splitview/split_view_controller_unittest.cc
►

Sign in to add a comment