Extensions Click-to-Script: Don't grayscale active extensions |
||
Issue descriptionExtension icons in the toolbar should only be grayscaled if they can neither accept clicks (i.e., the extension action is disabled) *and* the extension cannot inject on the page.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86600c69a09bdc9d38eabba200685e1d0606b456 commit 86600c69a09bdc9d38eabba200685e1d0606b456 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Mon Jul 23 23:49:36 2018 [jumbo] avoid ambiguities between extensions::features:: and features:: extensions/common/extension_features.h contains an extensions::features namespace, which can be confused with chrome/common/chrome_features.h's features namespace in jumbo builds. Let's disambiguate these enough to get jumbo builds working again. Followup to this CL, which uncovered the issue (but didn't cause it): https://chromium-review.googlesource.com/c/chromium/src/+/1145630 Bug: 866170 Change-Id: Iea5cca04c3c636014eae14f987c4aecd2dfb93bc Reviewed-on: https://chromium-review.googlesource.com/1147521 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#577342} [modify] https://crrev.com/86600c69a09bdc9d38eabba200685e1d0606b456/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeb0ab47c29fda8b317939f7e9bb868d4dcbe9b2 commit eeb0ab47c29fda8b317939f7e9bb868d4dcbe9b2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Aug 30 01:38:13 2018 [Extensions Click-to-Script] Fix grayscaling with content script access With runtime host permissions, extension icons shouldn't be grayscaled when they have access to the page. Correctly account for content script permissions in this checking, and add unittests for the same. Bug: 866170 Change-Id: Icde8d0b121c2054cd812bb7342d4ce1fdf7fb00e Reviewed-on: https://chromium-review.googlesource.com/1184024 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587390} [modify] https://crrev.com/eeb0ab47c29fda8b317939f7e9bb868d4dcbe9b2/chrome/browser/ui/extensions/extension_action_view_controller.cc [modify] https://crrev.com/eeb0ab47c29fda8b317939f7e9bb868d4dcbe9b2/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc
,
Aug 30
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 23