Ensure that we're not dropping the data from OOPIFs in the scheduler task sampling UKM and record the full picture.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3955669790864c0e3b39da863dbb1420fda21f28 commit 3955669790864c0e3b39da863dbb1420fda21f28 Author: Alexander Timin <altimin@chromium.org> Date: Thu Jul 26 11:28:29 2018 [scheduler] Record scheduler task UKM for OOPIFs. Do not drop renderer scheduler tasks silently for OOPIFs. This relies on the fact that now ukm recording works for any Document, including OOPIFs (main frame url is recorded for them). Move UkmRecorder and UkmSourceId methods from PageScheduler::Delegate to FrameScheduler::Delegate. BUG= 866169 R=haraken@chromium.org,eseckler@chromium.org Change-Id: I13d1a3db66c537ae20e7b236bc408753c9e71d28 Reviewed-on: https://chromium-review.googlesource.com/1145435 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578262} [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/core/frame/local_frame.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/core/page/page.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/core/page/page.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller_unittest.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/public/page_scheduler.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/test/fake_page_scheduler.h [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc [modify] https://crrev.com/3955669790864c0e3b39da863dbb1420fda21f28/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79bc68df6329d7e16d952260072799ace3521eb5 commit 79bc68df6329d7e16d952260072799ace3521eb5 Author: Alexander Timin <altimin@chromium.org> Date: Fri Jul 27 14:20:33 2018 [scheduler] Add UMA for UKM task recording statuses. Record the results of the task UKM recording to ensure that we are not dropping tasks anymore (we used to do so for OOPIFs). R=eseckler@chromium.org,holte@chromium.org BUG= 866169 Change-Id: I814bd8f71e9e2c0ba6de75f861cb46ca1119aa31 Reviewed-on: https://chromium-review.googlesource.com/1150226 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#578629} [modify] https://crrev.com/79bc68df6329d7e16d952260072799ace3521eb5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h [modify] https://crrev.com/79bc68df6329d7e16d952260072799ace3521eb5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/79bc68df6329d7e16d952260072799ace3521eb5/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h [modify] https://crrev.com/79bc68df6329d7e16d952260072799ace3521eb5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/79bc68df6329d7e16d952260072799ace3521eb5/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Jul 26