IPP-over-USB Crashing on Some devices with kernal v3.8.11 |
||||||||
Issue descriptionAll of the crashes seem to be caused by "minijail_enter" in ippusbxd. The cause of the issue is likely a syscall which is not in the seccomp filter.
,
Jul 26
,
Jul 26
Crash is caused because we're trying to use cgroups on an unsupported kernel
,
Aug 1
Landed this change which should fix the issue: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1150728 cgroups are not available in kernel version 3.8 which was resulting in the crash in minijail.
,
Aug 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d8d25f905a4649339d0ac6a15a8920a2bd9fab5b commit d8d25f905a4649339d0ac6a15a8920a2bd9fab5b Author: David Valleau <valleau@chromium.org> Date: Sat Aug 04 09:00:02 2018 ippusb_manager: Adding chmod call to init script to ensure group access After changing debugd to create the "/run/ippusb" directory (https://crrev.com/c/1155968), the directory gets created before the ippusb init scripts begin running. This change adds a chmod call to the init scripts to ensure that the directory allows group access. BUG= chromium:866144 TEST=Tested manually on device Change-Id: Iea57731be09eafb4a6773a0f843ed69e7f86f038 Reviewed-on: https://chromium-review.googlesource.com/1161615 Commit-Ready: David Valleau <valleau@chromium.org> Tested-by: David Valleau <valleau@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d8d25f905a4649339d0ac6a15a8920a2bd9fab5b/ippusb_manager/etc/init/ippusb-pre-upstart-socket-bridge.conf
,
Aug 6
I have tested that these changes on one of the latest images (R70-10944.0.0) from Goldeneye and everything works correctly. If possible I would like to have them picked back into M69 as they fix crashes that users would experience when trying to print. These are small changes that should not have an impact on any other systems.
,
Aug 6
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9
Merge approved, M69.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/539c760f114425b88b75d7160a7668ac591b320e commit 539c760f114425b88b75d7160a7668ac591b320e Author: David Valleau <valleau@chromium.org> Date: Thu Aug 09 22:33:18 2018 ippusb_manager: Adding chmod call to init script to ensure group access After changing debugd to create the "/run/ippusb" directory (https://crrev.com/c/1155968), the directory gets created before the ippusb init scripts begin running. This change adds a chmod call to the init scripts to ensure that the directory allows group access. BUG= chromium:866144 TEST=Tested manually on device Change-Id: Iea57731be09eafb4a6773a0f843ed69e7f86f038 Reviewed-on: https://chromium-review.googlesource.com/1161615 Commit-Ready: David Valleau <valleau@chromium.org> Tested-by: David Valleau <valleau@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit d8d25f905a4649339d0ac6a15a8920a2bd9fab5b) Reviewed-on: https://chromium-review.googlesource.com/1169923 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> [modify] https://crrev.com/539c760f114425b88b75d7160a7668ac591b320e/ippusb_manager/etc/init/ippusb-pre-upstart-socket-bridge.conf
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7e0f8e5deb42656856a20c5953a26452c3e115b6 commit 7e0f8e5deb42656856a20c5953a26452c3e115b6 Author: David Valleau <valleau@chromium.org> Date: Thu Aug 09 22:33:22 2018 ippusb_manager: Removing use of cgroups Devices with kernel 3.8 do not support cgroups which was causing crashes in minijail_enter(). This change removes the use of cgroups until devices with 3.8 reach EOL. BUG= chromium:866144 TEST=Tested manually on device Change-Id: I5122666767a519221d0f819508cb214fb735f219 Reviewed-on: https://chromium-review.googlesource.com/1150728 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: David Valleau <valleau@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> (cherry picked from commit ff06da0ea49ff9c0cd4820ad2cb0ec91d40bd3a4) Reviewed-on: https://chromium-review.googlesource.com/1169922 Commit-Queue: David Valleau <valleau@chromium.org> [modify] https://crrev.com/7e0f8e5deb42656856a20c5953a26452c3e115b6/ippusb_manager/ippusb_manager.cc
,
Aug 13
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by skau@chromium.org
, Jul 26