New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866141 link

Starred by 1 user
Status: Fixed
Owner:
█ updowndota@chromium.org
Last visit 26 days ago
Closed: Jul 25
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Assistant Optin UI: use <img> instead of <iron-icon> where possible.

Project Member Reported by scottchen@chromium.org, Jul 20 
In several places within resources/chromeos/assistant_optin/, <iron-icon> is used to load an image.

Initiating custom-elements (and therefore new shadow-doms) have performance costs, So for places where we're not taking advantage of SVG icons[1], we should use <img> with height/width CSS styling instead.

[1] https://cs.chromium.org/search/?q=%22%3Ciron-icon+src%22+file:%5Esrc/chrome/browser/resources/chromeos/assistant_optin/+package:%5Echromium$&type=cs
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92ae3ae83f56d4279fc6021d621509c12be22819

commit 92ae3ae83f56d4279fc6021d621509c12be22819
Author: Yue Li <updowndota@chromium.org>
Date: Wed Jul 25 03:50:22 2018

Use <img> instead of <iron-icon> in Assistant optin

Also:
- update logic for Assistant settings.
- update timeout for loading the flow.

Bug:  866141 , b/111704810, b/111796422
Test: Manual Test
Change-Id: Ibb3ba413992ee92b2e334dddeaf7d714d500ffcb
Reviewed-on: https://chromium-review.googlesource.com/1148768
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577792}
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.html
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.html
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.html
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.js
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.html
[add] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_shared_styles.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.html
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.css
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.html
[modify] https://crrev.com/92ae3ae83f56d4279fc6021d621509c12be22819/chrome/browser/resources/settings/search_page/search_page.js

Comment 2 by updowndota@chromium.org, Jul 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment