PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility failing on debug builds |
|||||||
Issue descriptionSomehow the description didn't pick up: [ RUN ] PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility Xlib: extension "RANDR" missing on display ":99". [26764:26764:0720/122551.991756:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 32 characters (32 were expected). [26764:26979:0720/122552.464670:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [26764:26764:0720/122552.560991:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [26764:26764:0720/122553.707545:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11 [26976:26976:0720/122554.119376:WARNING:owning_audio_manager_accessor.cc(80)] Out of process audio service initializing. [26764:26764:0720/122554.616127:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11 [26764:26764:0720/122556.972491:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [26764:26764:0720/122557.405036:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11 [1:1:0720/122602.509670:ERROR:webthread_impl_for_utility_thread.cc(19)] Not implemented reached in virtual blink::ThreadScheduler *blink::scheduler::WebThreadImplForUtilityThread::Scheduler() const [1:1:0720/122602.819179:ERROR:webthread_impl_for_utility_thread.cc(19)] Not implemented reached in virtual blink::ThreadScheduler *blink::scheduler::WebThreadImplForUtilityThread::Scheduler() const [26764:26764:0720/122605.015425:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11 [26764:26764:0720/122629.010331:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11 BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000f76339b7 base::debug::StackTrace::StackTrace() #1 0x0000f7300122 base::debug::StackTrace::StackTrace() #2 0x00000ecb23f1 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x0000f77becb0 ([vdso]+0xcaf) #4 0x0000f77becd9 ([vdso]+0xcd8) #5 0x0000d62024cb __poll #6 0x0000d68b120b g_poll #7 0x0000d68a23e8 <unknown> #8 0x0000d68a2528 g_main_context_iteration #9 0x0000f73ac168 base::MessagePumpGlib::Run() #10 0x0000f73a4649 base::MessageLoop::Run() #11 0x0000f73a46a7 base::MessageLoop::Run() #12 0x0000f745a21f base::RunLoop::Run() #13 0x00000ed4f6ee content::RunThisRunLoop() #14 0x00000ed51a6c content::MessageLoopRunner::Run() #15 0x00000ed68b74 content::AccessibilityNotificationWaiter::WaitForNotification() #16 0x00000ecc2a19 content::WaitForAccessibilityTreeToContainNodeWithName() #17 0x00000acd44f9 (anonymous namespace)::PrintPreviewDialogControllerBrowserTest_PrintPreviewPdfAccessibility_Test::RunTestOnMainThread() #18 0x00000ecb0c9a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x000008597caa _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #20 0x000008597bd4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #21 0x00000ecb382a _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE #22 0x00000ecb3711 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x00000858616e _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #24 0x00000d9a0d9f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x00000d99e358 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x0000eccf4dc2 content::BrowserMainLoop::PreMainMessageLoopRun() #27 0x0000eb563faa _ZN4base8internal13FunctorTraitsIMN7content24NetworkConnectionTrackerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #28 0x0000eb563ed4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content24NetworkConnectionTrackerEFvvEJPS5_EEEvOT_DpOT0_ #29 0x0000eccfc97a _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEiOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE #30 0x0000eccfc861 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #31 0x0000eb51581e _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #32 0x0000ede1b013 content::StartupTaskRunner::RunAllTasksNow() #33 0x0000eccef8c9 content::BrowserMainLoop::CreateStartupTasks() #34 0x0000eccff6a2 content::BrowserMainRunnerImpl::Initialize() #35 0x0000ecce6648 content::BrowserMain() #36 0x0000ef34efbb content::RunBrowserProcessMain() #37 0x0000ef351d3f content::ContentMainRunnerImpl::Run() #38 0x0000ef345ec7 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #39 0x0000e78c9c0f service_manager::Main() #40 0x0000ef34bfd3 content::ContentMain() #41 0x00000ecafff8 content::BrowserTestBase::SetUp() #42 0x00000d81abf0 InProcessBrowserTest::SetUp() #43 0x00000977de0f _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateENSt3__15tupleIJEEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS9_KFS3_vEEES3_PT_T0_RKS6_ #44 0x00000b1ac0d1 testing::internal::HandleExceptionsInMethodIfSupported<>() #45 0x00000b18bdcf testing::Test::Run() #46 0x00000b18caf6 testing::TestInfo::Run() #47 0x00000b18d707 testing::TestCase::Run() #48 0x00000b1a2825 testing::internal::UnitTestImpl::RunAllTests() #49 0x00000b1b744f testing::internal::HandleSehExceptionsInMethodIfSupported<>() #50 0x00000b1adab1 testing::internal::HandleExceptionsInMethodIfSupported<>() #51 0x00000b1a2456 testing::UnitTest::Run() #52 0x00000d86553d RUN_ALL_TESTS() #53 0x00000d8617b6 base::TestSuite::Run() #54 0x00000d7517cf ChromeTestSuiteRunner::RunTestSuite() #55 0x00000d751929 ChromeTestLauncherDelegate::RunTestSuite() #56 0x00000ed3e65f content::LaunchTests() #57 0x00000d752cec LaunchChromeTests() #58 0x00000d750f98 main #59 0x0000d613caf3 __libc_start_main #60 0x0000084e3a12 <unknown> [576/890] PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility (TIMED OUT) Locally I also see renderer crash?: [1:1:0720/141226.699018:FATAL:marking_visitor.h(99)] Check failed: Heap().GetStackFrameDepth().IsAcceptableStackUse(). #0 0x00000cbb5dad base::debug::StackTrace::StackTrace() #1 0x00000c92c41c base::debug::StackTrace::StackTrace() #2 0x00000c98712a logging::LogMessage::~LogMessage() #3 0x00000bc6fd03 blink::MarkingVisitor::Visit() #4 0x000016c347d6 blink::Visitor::Trace<>() #5 0x000016c3432e blink::Visitor::Trace<>() #6 0x000016c4455f blink::V0CustomElementMicrotaskImportStep::Trace() #7 0x00000c08540c blink::TraceTrait<>::Trace() #8 0x00000bc6fd78 blink::MarkingVisitor::Visit() #9 0x00000c5777d6 blink::Visitor::Trace<>() #10 0x00000c57439e blink::Visitor::Trace<>() #11 0x00000c5778dd blink::TraceIfEnabled<>::Trace<>() #12 0x00000c5b2037 WTF::TraceInCollectionTrait<>::Trace<>() #13 0x00000c5b1fbd blink::TraceTrait<>::Trace<>() #14 0x00000bc6fd78 blink::MarkingVisitor::Visit() #15 0x00000bc6fe85 blink::MarkingVisitor::VisitBackingStoreStrongly() #16 0x00000c5b320b blink::Visitor::TraceBackingStoreStrongly<>() #17 0x00000c5b3150 blink::HeapAllocator::TraceVectorBacking<>() #18 0x00000c5b3039 WTF::Vector<>::Trace<>() #19 0x00000c5b2fb8 blink::TraceTrait<>::Trace() #20 0x00000c5b19ad blink::Visitor::Trace<>() #21 0x000016c34981 blink::V0CustomElementMicrotaskQueueBase::Trace() #22 0x000016c346a8 blink::TraceTrait<>::Trace() #23 0x00000bc6fd78 blink::MarkingVisitor::Visit() #24 0x000016c347d6 blink::Visitor::Trace<>() #25 0x000016c3432e blink::Visitor::Trace<>() #26 0x000016c4455f blink::V0CustomElementMicrotaskImportStep::Trace() #27 0x00000c08540c blink::TraceTrait<>::Trace() #28 0x00000bc6fd78 blink::MarkingVisitor::Visit() #29 0x00000c5777d6 blink::Visitor::Trace<>() #30 0x00000c57439e blink::Visitor::Trace<>() #31 0x00000c5778dd blink::TraceIfEnabled<>::Trace<>() #32 0x00000c5b2037 WTF::TraceInCollectionTrait<>::Trace<>() #33 0x00000c5b1fbd blink::TraceTrait<>::Trace<>() #34 0x00000bc6fd78 blink::MarkingVisitor::Visit() #35 0x00000bc6fe85 blink::MarkingVisitor::VisitBackingStoreStrongly() #36 0x00000c5b320b blink::Visitor::TraceBackingStoreStrongly<>() #37 0x00000c5b3150 blink::HeapAllocator::TraceVectorBacking<>() #38 0x00000c5b3039 WTF::Vector<>::Trace<>() #39 0x00000c5b2fb8 blink::TraceTrait<>::Trace() #40 0x00000c5b19ad blink::Visitor::Trace<>() #41 0x000016c34981 blink::V0CustomElementMicrotaskQueueBase::Trace() #42 0x000016c346a8 blink::TraceTrait<>::Trace() #43 0x00000bc6fd78 blink::MarkingVisitor::Visit() #44 0x000016c347d6 blink::Visitor::Trace<>() #45 0x000016c3432e blink::Visitor::Trace<>() #46 0x000016c4455f blink::V0CustomElementMicrotaskImportStep::Trace() #47 0x00000c08540c blink::TraceTrait<>::Trace() #48 0x00000bc6fd78 blink::MarkingVisitor::Visit() #49 0x00000c5777d6 blink::Visitor::Trace<>() #50 0x00000c57439e blink::Visitor::Trace<>() #51 0x00000c5778dd blink::TraceIfEnabled<>::Trace<>() #52 0x00000c5b2037 WTF::TraceInCollectionTrait<>::Trace<>() #53 0x00000c5b1fbd blink::TraceTrait<>::Trace<>() #54 0x00000bc6fd78 blink::MarkingVisitor::Visit() #55 0x00000bc6fe85 blink::MarkingVisitor::VisitBackingStoreStrongly() #56 0x00000c5b320b blink::Visitor::TraceBackingStoreStrongly<>() #57 0x00000c5b3150 blink::HeapAllocator::TraceVectorBacking<>() #58 0x00000c5b3039 WTF::Vector<>::Trace<>() #59 0x00000c5b2fb8 blink::TraceTrait<>::Trace() #60 0x00000c5b19ad blink::Visitor::Trace<>() #61 0x000016c34981 blink::V0CustomElementMicrotaskQueueBase::Trace()
,
Jul 20
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/263b4a76fd980f494a1b88bba5528fc3bb606f69 commit 263b4a76fd980f494a1b88bba5528fc3bb606f69 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Fri Jul 20 21:25:18 2018 Revert "Display warning when PDF signals an attempt to save" This reverts commit 277b7985fae75c9f21f8ab9111fb65d250328f70. Reason for revert: Causing test failure on debug builds: PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility See bug for details. BUG=866138 Original change's description: > Display warning when PDF signals an attempt to save > > This CL adds a warning dialogue that is shown when a > signal via SaveCalled is received. Currently this > signal is only wired up for app.execMenuItem("SaveAs") > in XFA JS, but will be added in other locations where > saving is attempted. > > Once saving of PDFs is fully implemented this warning > can be removed. > > BUG=pdfium:953,chromium:61248 > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Ib89c394a07459692ee1302ea97f7b0b291b42b92 > Reviewed-on: https://chromium-review.googlesource.com/1115205 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576920} TBR=rharrison@chromium.org,thestig@chromium.org,dsinclair@chromium.org,tsepez@chromium.org,jochen@chromium.org,rbpotter@chromium.org Change-Id: I883ec9bc7d3c4140996c12c3fc6524c4314f109d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: pdfium:953, chromium:61248 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1145203 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576992} [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/chrome/browser/extensions/api/resources_private/resources_private_api.cc [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/chrome/browser/resources/component_extension_resources.grd [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/chrome/browser/resources/pdf/BUILD.gn [delete] https://crrev.com/63f1f746d473a01f328087e15a2993e2163153e3/chrome/browser/resources/pdf/elements/viewer-save-called-screen/BUILD.gn [delete] https://crrev.com/63f1f746d473a01f328087e15a2993e2163153e3/chrome/browser/resources/pdf/elements/viewer-save-called-screen/viewer-save-called-screen.html [delete] https://crrev.com/63f1f746d473a01f328087e15a2993e2163153e3/chrome/browser/resources/pdf/elements/viewer-save-called-screen/viewer-save-called-screen.js [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/chrome/browser/resources/pdf/index.html [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/chrome/browser/resources/pdf/pdf.js [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/components/pdf_strings.grdp [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/out_of_process_instance.cc [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/out_of_process_instance.h [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/pdf_engine.h [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/pdfium/pdfium_form_filler.cc [modify] https://crrev.com/263b4a76fd980f494a1b88bba5528fc3bb606f69/pdf/pdfium/pdfium_form_filler.h
,
Jul 23
Talked with lfg@ about this and he thinks that this isn't actually a problem in my CL, since I am just adding some WebUI HTML/JS, and not touching Blink. It does not reproduce on HEAD, but consistently does with my CL, https://chromium-review.googlesource.com/c/chromium/src/+/1115205, on a Debug build calling browser_tests --gtest_filter=PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility Could you take a look at this or reassign as appropriate?
,
Jul 23
,
Jul 23
+cc keishi (this looks similar to bug 645253). Also important to notice that there are no blink changes in the CL, so this is the result of the changes html/js files, and whatever is causing the GC graph to grow to this size is already in blink.
,
Jul 23
keishi: I think we need to add DISABLE_EAGER_TRACING to V0CustomElementMicrotaskImportStep.
,
Jul 23
Thanks for the update, I'll take sheriff label off for now.
,
Sep 24
keishi: Ping. Any chance you can take a look at this in Q4? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lazyboy@chromium.org
, Jul 20Owner: rharrison@chromium.org
Status: Assigned (was: Unconfirmed)