Omnibox results containing `Switch to This Tab` pill are shaded with 2 different grays when pointer is over the pill. |
||||||
Issue descriptionChrome Version: 70.0.3498.0 (Developer Build) (64-bit) OS: Linux What steps will reproduce the problem? (1) Open a tab (2) Navigate to a url (3) Open a new tab (4) Begin typing the same url, the `Switch to This tab` result should appear (5) Hover your pointer over the `Switch to This tab` pill. What is the expected result? The light gray background of the result should be 1 consistent color. What happens instead? The rectangle section bounding the pill is a darker shade of gray than the remainder of the result's background. See attached picture. Top is when the pointer is not on the first result; middle is with the pointer over the first result; bottom is with the pointer over the pill (issue).
,
Jul 30
Trent, I'm wondering what the expected behavior here is. I wonder this, first, because there's little that the class can do to affect the area outside the oval border. But second, because, when I mouse over the icons within the Omnibox (bookmark star, magnifying glass, etc.), they have a similar oval highlight, but the Omnibox also darkens. Thus, if these icons have the same issue as the tab switch button, you wouldn't see it (because it matches the new background.) Is the proper fix here to have the OmniboxResultView darken as well? Or is there an alpha issue? (i.e. outside the border should have alpha=0 but doesn't)
,
Jul 31
I'm not sure what's going on. This does look wrong though. Maybe it's in MdTextButton::OnPaintBackground -- the paint doesn't appear to be clipped there. Does overriding OnPaintBackground to short-circuit directly to LabelButton's implementation work?
,
Jul 31
Having it only call LabelButton:OnPaintBackground does remove the rectangle, at the expense of some dark - ee vs e9. I'll take a shot at preserving the oval.
,
Jul 31
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfd30be326fc1a0b28131588730a635f1849ed0c commit bfd30be326fc1a0b28131588730a635f1849ed0c Author: Kevin Bailey <krb@chromium.org> Date: Wed Aug 01 15:47:35 2018 [MdTextButton] Apply rounded rectangle to background painting In the final OnPaintBackground() method, it currently uses a standard rectangle to "dim" the background on hover (or animation). This resulted in some dimming outside a rounded button. This change uses a rounded rectangle instead, using the existing corner radius. Bug: 866136 Change-Id: Ifb8ad476e231049efbf73e1dc64c0c1f0f113897 Reviewed-on: https://chromium-review.googlesource.com/1156877 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579819} [modify] https://crrev.com/bfd30be326fc1a0b28131588730a635f1849ed0c/ui/views/controls/button/md_text_button.cc
,
Aug 1
,
Aug 2
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #70.0.3498.0. Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using latest chrome version #70.0.3510.0 as per the comment #0. Attaching screen shot for reference. Observed that light gray background of the result is 1 consistent color. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tommycli@chromium.org
, Jul 23Status: Available (was: Untriaged)