New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 866095 link

Starred by 1 user
Status: Fixed
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Closed: Aug 6
Cc:
perezju@chromium.org
martiniss@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename the Telemetry sharding flags to no longer have experimental prefix

Project Member Reported by nednguyen@chromium.org, Jul 20 
The current sharding flags of Telemetry are:
--experimental-story-shard-begin-index
--experimental-story-shard-end-index

Now that these flags are run in production, we should remove "experimental" from the flags names
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c1e861467cefc2877f135c1e5c5fe977271475

commit 84c1e861467cefc2877f135c1e5c5fe977271475
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 23 22:17:20 2018

Roll src/third_party/catapult 9e8a0b2b37d9..1381813c377d (3 commits)

https://chromium.googlesource.com/catapult.git/+log/9e8a0b2b37d9..1381813c377d


git log 9e8a0b2b37d9..1381813c377d --date=short --no-merges --format='%ad %ae %s'
2018-07-23 nednguyen@google.com Increase default timeout limit of setting tsproxy's traffic settings to 20 seconds
2018-07-23 nednguyen@google.com Add '--story-shard-begin-index' and '--story-shard-end-index' flags
2018-07-23 nednguyen@google.com Fix PRESUBMIT errors in catapult


Created with:
  gclient setdep -r src/third_party/catapult@1381813c377d

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:865250, chromium:866095 , chromium:866260 
TBR=sullivan@chromium.org

Change-Id: I0f4b0a06fa6b8e5312fbbd6f6385910004841801
Reviewed-on: https://chromium-review.googlesource.com/1147060
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577290}
[modify] https://crrev.com/84c1e861467cefc2877f135c1e5c5fe977271475/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae556091aa79c9fef724bd55a93249f7a942e26

commit 2ae556091aa79c9fef724bd55a93249f7a942e26
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Jul 25 18:41:08 2018

Update run_performance_tests.py to use '--story-shard-begin-index' and '--story-shard-end-index' flags

Bug:866095
Change-Id: I92c07d23a98910fa0840811fe45f2daa8b2ba8a1

TBR=perezju@chromium.org, eyaich@chromium.org

# Bypass unrelated PRESUBMIT lint error

No-Presubmit: true
Change-Id: I92c07d23a98910fa0840811fe45f2daa8b2ba8a1
Reviewed-on: https://chromium-review.googlesource.com/1150420
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#577990}
[modify] https://crrev.com/2ae556091aa79c9fef724bd55a93249f7a942e26/testing/scripts/run_performance_tests.py

Comment 5 by nednguyen@chromium.org, Aug 6

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a983489b920ba3d202424e71775a23e35c0ad764

commit a983489b920ba3d202424e71775a23e35c0ad764
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 06 18:13:40 2018

Roll src/third_party/catapult 79eccf98e8fd..93f9ef7fc26f (2 commits)

https://chromium.googlesource.com/catapult.git/+log/79eccf98e8fd..93f9ef7fc26f


git log 79eccf98e8fd..93f9ef7fc26f --date=short --no-merges --format='%ad %ae %s'
2018-08-06 nednguyen@google.com Remove --experimental-story-shard-* flags
2018-08-06 perezju@chromium.org [long term health] Tweak gsutil url and ignore output dirs


Created with:
  gclient setdep -r src/third_party/catapult@93f9ef7fc26f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:866095 , chromium:863390 
TBR=sullivan@chromium.org

Change-Id: If56e39209b541bb82681b8e5d5b438e9b50ac46e
Reviewed-on: https://chromium-review.googlesource.com/1163115
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580920}
[modify] https://crrev.com/a983489b920ba3d202424e71775a23e35c0ad764/DEPS

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment