New issue
Advanced search Search tips
Starred by 8 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 896967
issue 901205
issue 909822
issue 919599
issue 920442

Blocking:
issue 772181
issue 922137



Sign in to add a comment
link

Issue 866062: Spin up functional chromium tests on CrOS hardware

Reported by bpastene@chromium.org, Jul 20 2018 Project Member

Issue description

Tracking bug for the post-commit hardware test effort.

VM-tests are up and running on the CQ:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel?limit=200

Time to get hardware coverage as well. We've already got the hardware in swarming:
https://chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AChromeOS&l=100&q=os%3A&s=id%3Aasc

Which is (theoretically) running telemetry unittests:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ChromeOS%20Swarm

All of which is in varying states of disrepair. Off the top of my head, TODOs are:

- Resuscitate the hardware.

- Keep the hardware alive.
  - Set up monitoring of their health. (a la android)
  - Get the chromebooks on our weekly repair cycles so they can get automatically revived. (a la android)
  - (Also figure out how to stop the OOBE tutorial video which seems to shut down the ethernet adapter.... or something.)

- Develop auto-flashing story.
  - Package cros' "cros flash" utility into an isolate.
  - Regularly fetch the latest stable images from chromeos-image-archive GS bucket.
  - Schedule a nightly/weekly cron to flash those images onto the chromebooks using the isolate.

- Flesh out test runner scripts in //build/chromeos/ to support running hardware (along with VMs).

- Set up simplechrome waterfall builder which builds the tests. (Like the VM builder, but targeting the HW's board.)

- Run the tests.

- ???

- Profit


If all goes well, that should put us in a good position to start looking into running perf benchmarks on the hardware as well. But that's for another bug.
 

Comment 1 by bugdroid1@chromium.org, Jul 25 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f80879af74355bff3f1b95a8ec1a24e74f8655

commit 60f80879af74355bff3f1b95a8ec1a24e74f8655
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Jul 25 18:53:13 2018

Refactor cros VM test runner with more test abstraction.

Now with more OOP! Class structure is:

RemoteTest
   | --- GTestTest
   | --- BrowserSanityTest

Doesn't add anything new. Just splits out sanity-test and gtest-test
logic into their own classes (and resuses what it can in a parent class)

I'm planning on making some changes to how GTests are launched in the
VM. This'll make that easier.

I'm also thinking about reusing some logic in here when running hardware
tests. This will make that easier as well.

Bug: 732531, 866062
Change-Id: I80a6e29c657b1db6c7911cb873c64be094c9b5ef
Reviewed-on: https://chromium-review.googlesource.com/1145796
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577996}
[add] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/PRESUBMIT.py
[modify] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/create_vm_test_script.py
[add] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/pylintrc
[modify] https://crrev.com/60f80879af74355bff3f1b95a8ec1a24e74f8655/build/chromeos/run_vm_test.py

Comment 2 by bpastene@chromium.org, Sep 15

WIP design doc for all this: https://docs.google.com/document/d/1q9sKqVWHHZTeF_1V6eaoclxiptW5gef5Y5ed-BeXytM

Will finish & send out for review next week.

Comment 3 by keiichiw@chromium.org, Sep 19

Cc: keiichiw@chromium.org

Comment 4 by bugdroid1@chromium.org, Oct 11

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11

Project Member

Comment 7 by bpastene@chromium.org, Oct 26

Blockedon: 896967

Comment 8 by bugdroid1@chromium.org, Oct 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/49d72f3f1b5a6d1c1df9795243ba781cfd470c3d

commit 49d72f3f1b5a6d1c1df9795243ba781cfd470c3d
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Oct 31 20:06:55 2018

Set en_US.UTF-8 as the locale in android & cros docker containers.

It fails when trying to create files/symlinks with unique chars, eg:
"TÜRKTRUST_Elektronik_Sertifika_Hizmet_Sağlayıcısı_H5.crt"

Bug: 866062
Change-Id: I8e82ea280acb223a38f2ff8c16929af23b2141c1
Reviewed-on: https://chromium-review.googlesource.com/c/1310833
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18704}
[modify] https://crrev.com/49d72f3f1b5a6d1c1df9795243ba781cfd470c3d/docker/docker_devices/android/Dockerfile
[modify] https://crrev.com/49d72f3f1b5a6d1c1df9795243ba781cfd470c3d/docker/docker_devices/cros/Dockerfile

Comment 9 by bpastene@chromium.org, Nov 2

Blockedon: 901205

Comment 10 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01cab269fca79746a498132c9cda17b5916cc425

commit 01cab269fca79746a498132c9cda17b5916cc425
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Nov 08 00:44:22 2018

Add an experimental cros-dut-flash-scheduler builder to buildbucket-dev.

This'll be the builder that triggers nightly flashing jobs into the
cros-dut-flash builder.

Adding it to dev while I develop & experiment with it and the flashing
builder.

Bug: 866062
Change-Id: I0319bbcb3591a6488940a9a61330a787d9dbdc01
Reviewed-on: https://chromium-review.googlesource.com/c/1325013
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606255}
[modify] https://crrev.com/01cab269fca79746a498132c9cda17b5916cc425/infra/config/global/cr-buildbucket-dev.cfg

Comment 11 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/9340ca098680c83651e722cd3ac33a0c8bbe64eb

commit 9340ca098680c83651e722cd3ac33a0c8bbe64eb
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Nov 08 21:53:41 2018

Allow gsutil recipe_module calls to not always be infra_steps.

I'm writing a recipe that makes heavy use of gsutil's ls and cat, and
some of the calls are expected to fail. So this allows the user to make
those that fail do so as normal steps.

R=iannucci, tandrii

Bug: 866062
Change-Id: I4c9cdcb77c00afd4ab8fefd146f22fa94fcc37d7
Reviewed-on: https://chromium-review.googlesource.com/c/1325332
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/9340ca098680c83651e722cd3ac33a0c8bbe64eb/recipes/recipe_modules/gsutil/api.py
[modify] https://crrev.com/9340ca098680c83651e722cd3ac33a0c8bbe64eb/recipes/README.recipes.md

Comment 12 by bugdroid1@chromium.org, Nov 8

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/025554ba9f2486bc651655cf08226a8cd93e377a

commit 025554ba9f2486bc651655cf08226a8cd93e377a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 09 00:38:28 2018

Roll src/third_party/depot_tools fc810ab24daa..93cd73d98000 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc810ab24daa..93cd73d98000


git log fc810ab24daa..93cd73d98000 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-08 bpastene@chromium.org Allow gsutil recipe_module calls to not always be infra_steps.
2018-11-08 martiniss@chromium.org Revert "Roll recipe dependencies (trivial)."


Created with:
  gclient setdep -r src/third_party/depot_tools@93cd73d98000

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:866062
TBR=agable@chromium.org

Change-Id: Ib3a90d2e456d199614cc895ed7e4b47d7e2a3208
Reviewed-on: https://chromium-review.googlesource.com/c/1327351
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606664}
[modify] https://crrev.com/025554ba9f2486bc651655cf08226a8cd93e377a/DEPS

Comment 14 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/13d60e2477144faecdb947c4f9f0a8796526a20f

commit 13d60e2477144faecdb947c4f9f0a8796526a20f
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Nov 12 22:23:53 2018

Comment 15 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e13b73312852a6f81b9439d1e5dc238660ad5484

commit e13b73312852a6f81b9439d1e5dc238660ad5484
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Nov 12 23:05:57 2018

Use the builder named cache in the cros_flash recipe.

Instead of a specific one. The builder cache is already present for all
swarmbucket builds. Everything else has to be created manually. So using
the builder cache is less of a hassle, but essentially equivalent.

TBR=martiniss

Bug: 866062
Change-Id: I9018b8f64e9f240bb3dd661d1767435c439a2fb2
Reviewed-on: https://chromium-review.googlesource.com/c/1332667
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/e13b73312852a6f81b9439d1e5dc238660ad5484/scripts/slave/recipes/cros_flash.expected/basic_test_with_extract.json
[modify] https://crrev.com/e13b73312852a6f81b9439d1e5dc238660ad5484/scripts/slave/recipes/cros_flash.expected/basic_test.json
[modify] https://crrev.com/e13b73312852a6f81b9439d1e5dc238660ad5484/scripts/slave/recipes/cros_flash.py

Comment 16 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/704dd118660a442bb0d11ba11b8fd01864d5f158

commit 704dd118660a442bb0d11ba11b8fd01864d5f158
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Nov 19 19:13:02 2018

Initial add for a recipe that schedules flashing jobs in CrOS DUT pools.

This is just the first few steps in the recipe. Much TODOs to still do.
Will change it incrementally for (hopefully) easier reviewing.

Bug: 866062
Change-Id: Ie18ce02548fff40eed1b70d98a5ec3d74c4ff761
Reviewed-on: https://chromium-review.googlesource.com/c/1330732
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/704dd118660a442bb0d11ba11b8fd01864d5f158/scripts/slave/README.recipes.md
[add] https://crrev.com/704dd118660a442bb0d11ba11b8fd01864d5f158/scripts/slave/recipes/cros_flash_scheduler.expected/full_run.json
[add] https://crrev.com/704dd118660a442bb0d11ba11b8fd01864d5f158/scripts/slave/recipes/cros_flash_scheduler.py
[modify] https://crrev.com/704dd118660a442bb0d11ba11b8fd01864d5f158/scripts/slave/recipes/OWNERS

Comment 17 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0135088fe41d96aecdd658437a31c765330992ce

commit 0135088fe41d96aecdd658437a31c765330992ce
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Nov 19 20:34:20 2018

Add a luci scheduler job for the cros-dut-flash-scheduler dev bot.

Needs https://chromium-review.googlesource.com/c/chromium/tools/build/+/1330732
before this can land.

Bug: 866062
Change-Id: I2e802b8d72df043ddefc1f1caefee205fdfa3161
Reviewed-on: https://chromium-review.googlesource.com/c/1338839
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609415}
[modify] https://crrev.com/0135088fe41d96aecdd658437a31c765330992ce/infra/config/global/luci-scheduler-dev.cfg

Comment 18 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a3d71bd2f6d5059190e2fff6e067fb0cfa7c207a

commit a3d71bd2f6d5059190e2fff6e067fb0cfa7c207a
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Nov 19 23:56:15 2018

cros_flash_scheduler: Get the GS image path for the given board & lkgm.

Will be used once I implement the flashing triggering.

R=jbudorick, martiniss

Bug: 866062
Change-Id: I0d4ab2f1fc60545c91171adb4cf086afca517aaa
Reviewed-on: https://chromium-review.googlesource.com/c/1342959
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/a3d71bd2f6d5059190e2fff6e067fb0cfa7c207a/scripts/slave/README.recipes.md
[modify] https://crrev.com/a3d71bd2f6d5059190e2fff6e067fb0cfa7c207a/scripts/slave/recipes/cros_flash_scheduler.expected/full_run.json
[modify] https://crrev.com/a3d71bd2f6d5059190e2fff6e067fb0cfa7c207a/scripts/slave/recipes/cros_flash_scheduler.py

Comment 19 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/196a99d66e9adbb82ad6975a2547ea81d16bcdb7

commit 196a99d66e9adbb82ad6975a2547ea81d16bcdb7
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Nov 20 22:04:35 2018

cros_flash_scheduler: Trigger (& collect) flashing builds.

Still a few more TODOs, but we're getting there!

See https://luci-milo-dev.appspot.com/swarming/task/41476770a34a7310
for an example run of this as-is.

R=jbudorick, martiniss

Bug: 866062
Change-Id: I3780ed36126296b6150f59d6fdaaa9cd8536d140
Reviewed-on: https://chromium-review.googlesource.com/c/1342727
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/196a99d66e9adbb82ad6975a2547ea81d16bcdb7/scripts/slave/README.recipes.md
[modify] https://crrev.com/196a99d66e9adbb82ad6975a2547ea81d16bcdb7/scripts/slave/recipes/cros_flash_scheduler.expected/full_run.json
[modify] https://crrev.com/196a99d66e9adbb82ad6975a2547ea81d16bcdb7/scripts/slave/recipes/cros_flash_scheduler.py

Comment 20 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d1b0ba5e6894df10a573dfc5e714c8a85d010b2c

commit d1b0ba5e6894df10a573dfc5e714c8a85d010b2c
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Nov 21 19:49:30 2018

cros_flash_scheduler: Collect bot state after the flash tasks finish.

And retrigger again if all bots are OK after getting flashed.

See https://luci-milo-dev.appspot.com/swarming/task/414c5101527ed710 for
an example run of this.

Bug: 866062
Change-Id: Ida5cc3aa2bbaa4fac1a0fad6f7bc12a7358d35be
Reviewed-on: https://chromium-review.googlesource.com/c/1345430
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/d1b0ba5e6894df10a573dfc5e714c8a85d010b2c/scripts/slave/README.recipes.md
[modify] https://crrev.com/d1b0ba5e6894df10a573dfc5e714c8a85d010b2c/scripts/slave/recipes/cros_flash_scheduler.expected/full_run.json
[modify] https://crrev.com/d1b0ba5e6894df10a573dfc5e714c8a85d010b2c/scripts/slave/recipes/cros_flash_scheduler.py

Comment 21 by achuith@chromium.org, Nov 28

Cc: achuith@chromium.org
Status: Started (was: Assigned)

Comment 22 by bpastene@chromium.org, Nov 28

The dut flasher is up at https://luci-milo-dev.appspot.com/p/chromium/builders/luci.chromium.ci/cros-dut-flash-scheduler

Tho the lkgm hasn't been updated since the flashing cron was enabled last week, so every run since has been a no-op. I'll head over to the lab and see if I can't resurrect the ones that are unreachable/unauthorized:
https://chromium-swarm-dev.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=os%3AChromeOS&s=id

Comment 23 by bpastene@chromium.org, Nov 28

Blockedon: 909822

Comment 24 by bugdroid1@chromium.org, Nov 29

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 30

Project Member

Comment 26 by bugdroid1@chromium.org, Dec 1

Project Member

Comment 27 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b565c8bf4cb6317e9794d95944f8490c8557b053

commit b565c8bf4cb6317e9794d95944f8490c8557b053
Author: Ben Pastene <bpastene@chromium.org>
Date: Sat Dec 08 00:05:51 2018

Allow room for some failed flashing jobs in the cros dut scheduler.

Sometimes one job might fail. I don't think we should block the whole
process on that.

Also randomly select the subset of bots to flash.

Bug: 866062
Change-Id: I7698e7cee245e4b26d307ea0b5100495c3cbe046
Reviewed-on: https://chromium-review.googlesource.com/c/1366270
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/b565c8bf4cb6317e9794d95944f8490c8557b053/scripts/slave/README.recipes.md
[modify] https://crrev.com/b565c8bf4cb6317e9794d95944f8490c8557b053/scripts/slave/recipes/cros_flash_scheduler.py

Comment 28 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/828ea582dd796b227fcef4b0a3c066c14119715f

commit 828ea582dd796b227fcef4b0a3c066c14119715f
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Dec 12 00:03:03 2018

Fix cros flash scheduler recipe when current LKGM != lastest available version.

See https://luci-milo-dev.appspot.com/p/chromium/builders/luci.chromium.ci/cros-dut-flash-scheduler/35
where the current LKGM (11361) isn't the image we're actually flashing with (11327)

So this fixes a few bugs where we incorrectly treat those two versions as
the same.

Bug: 866062
Change-Id: Id6167c07a2526d95f46ed88c28db6188703346a6
Reviewed-on: https://chromium-review.googlesource.com/c/1372328
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/828ea582dd796b227fcef4b0a3c066c14119715f/scripts/slave/README.recipes.md
[modify] https://crrev.com/828ea582dd796b227fcef4b0a3c066c14119715f/scripts/slave/recipes/cros_flash_scheduler.py

Comment 30 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/bc167b08ed72a0d03e3002003316d088a9f66601

commit bc167b08ed72a0d03e3002003316d088a9f66601
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Dec 17 18:50:24 2018

Comment 31 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627e2941f115368c5d648f559380cc94f8ef0f9e

commit 627e2941f115368c5d648f559380cc94f8ef0f9e
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Dec 17 20:56:02 2018

Add support to chromeos test runner for running tests on devices.

Adds a "--use-vm" option (when using VMs) and a "--device" option (when
using real devices.)

Bug: 866062
Change-Id: Ic8fd34f9c34e5bc8b42b8e900220d30a8b19e645
Reviewed-on: https://chromium-review.googlesource.com/c/1380332
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617222}
[modify] https://crrev.com/627e2941f115368c5d648f559380cc94f8ef0f9e/build/chromeos/create_test_runner_script.py
[modify] https://crrev.com/627e2941f115368c5d648f559380cc94f8ef0f9e/build/chromeos/test_runner.py
[modify] https://crrev.com/627e2941f115368c5d648f559380cc94f8ef0f9e/build/config/chromeos/rules.gni

Comment 32 by bugdroid1@chromium.org, Dec 17

Project Member

Comment 33 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f50207917dd76fb013269042621a9c2475cf4c8a

commit f50207917dd76fb013269042621a9c2475cf4c8a
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Dec 17 22:36:07 2018

Remove luci *-dev configs for CrOS dut flasher cron.

Moving to prod in infra's buckets in:
https://chromium-review.googlesource.com/c/infra/infra/+/1380876

R=jbudorick, martiniss

Bug: 866062
Change-Id: I65922a1a220e07adccd37ff274e5e26634e3c53f
Reviewed-on: https://chromium-review.googlesource.com/c/1380678
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617264}
[modify] https://crrev.com/f50207917dd76fb013269042621a9c2475cf4c8a/infra/config/global/cr-buildbucket-dev.cfg
[modify] https://crrev.com/f50207917dd76fb013269042621a9c2475cf4c8a/infra/config/global/luci-scheduler-dev.cfg

Comment 34 by bugdroid1@chromium.org, Dec 17

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ad52de19ee53554fbc02c5633d71ef84cc9207e7

commit ad52de19ee53554fbc02c5633d71ef84cc9207e7
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Dec 17 23:55:42 2018

Add luci configs in luci.infra.cron for CrOS DUT flash cron.

This adds two builders:
- cros-flash-scheduler-kevin: Runs every night on any Ubuntu bot & selectively
    triggers builds on the 2nd builder, "cros-dut-flash".
- cros-dut-flash: Runs on any CrOS DUT swarming bot (pool:Chrome,os:ChromeOS),
    and flashes its Chromebook device.

This setup might be a little weird since both builders will belong to the "cron"
bucket, but the second builder runs on machines in "pool:Chrome". Hopefully
that doesn't prove problematic.

Bug: 866062
Change-Id: I30c98174a6a233d382707984a83e68c1f6ef1355
Reviewed-on: https://chromium-review.googlesource.com/c/1380876
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19616}
[modify] https://crrev.com/ad52de19ee53554fbc02c5633d71ef84cc9207e7/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/ad52de19ee53554fbc02c5633d71ef84cc9207e7/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/ad52de19ee53554fbc02c5633d71ef84cc9207e7/infra/config/global/cr-buildbucket.cfg

Comment 36 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/136d4bb98bc62b788a64ada9a9028e8455415492

commit 136d4bb98bc62b788a64ada9a9028e8455415492
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Dec 18 00:44:52 2018

Add some tests to the CrOS device bot on fyi.

Adds one Gtest (base_unittests), the sanity test, and all chrome tast tests.

Will add them to this bot:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel-hw-tests

Theoretically this should work now that crrev.com/c/1380332 has landed.
Only one way to find out though.

R=jbudorick, dpranke

Bug: 866062
Change-Id: Ied282ab5878653595e56c1d2a76ebc81fbe254b9
Reviewed-on: https://chromium-review.googlesource.com/c/1381241
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617315}
[modify] https://crrev.com/136d4bb98bc62b788a64ada9a9028e8455415492/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/136d4bb98bc62b788a64ada9a9028e8455415492/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/136d4bb98bc62b788a64ada9a9028e8455415492/testing/buildbot/waterfalls.pyl

Comment 37 by bugdroid1@chromium.org, Dec 18

Project Member

Comment 38 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0319feeb31585614cd2cbd8449323663117c3218

commit 0319feeb31585614cd2cbd8449323663117c3218
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Dec 18 22:50:15 2018

Remove the cros_flash* recipes from tools/build.

Moving them from tools/build to infra/infra since the builder that runs
them belongs to the infra.cron bucket. (Which is where it belongs.)

infra/infra side change:
https://chromium-review.googlesource.com/c/infra/infra/+/1383333

R=jbudorick, martiniss

Bug: 866062
Change-Id: Ib7f3e96ea75cb8c857975815fad16ae6d5f397c8
Reviewed-on: https://chromium-review.googlesource.com/c/1383372
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash_scheduler.expected/full_run.json
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash.expected/basic_test.json
[modify] https://crrev.com/0319feeb31585614cd2cbd8449323663117c3218/scripts/slave/recipes/OWNERS
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash.expected/missing_props.json
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash.expected/basic_test_with_extract.json
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash.expected/unknown_image_format.json
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash.py
[delete] https://crrev.com/c48b82ab95781c36e5c13afebb773c5b64eecb3e/scripts/slave/recipes/cros_flash_scheduler.py

Comment 39 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbb96a90540551b2878b7b0dd4fbfca7ef0ff0cf

commit dbb96a90540551b2878b7b0dd4fbfca7ef0ff0cf
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Dec 19 00:11:19 2018

Don't strip symbols from Chrome binaries when running CrOS tests on devices.

VMs can't handle the symbols, but hopefully real devices can.

R=jbudorick

Bug: 866062
Change-Id: Ia7a22cecca4046a1e13efc47bcf3a8b296385c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1383042
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617682}
[modify] https://crrev.com/dbb96a90540551b2878b7b0dd4fbfca7ef0ff0cf/build/chromeos/test_runner.py

Comment 40 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4d175dbf07df6d4f29cc100e9955786ca0a5edca

commit 4d175dbf07df6d4f29cc100e9955786ca0a5edca
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Dec 19 02:06:36 2018

Add the cros_flash* recipes to infra/infra.git.

Moving them from tools/build to infra/infra since the builder that runs
them belongs to the infra.cron bucket. (Which is where it belongs.)

tools/build side change:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1383372

R=jbudorick, martiniss
CC=​tandrii

Bug: 866062
Change-Id: I8aa05dee864b09601fe89e57b2a58c6d73c33e41
Reviewed-on: https://chromium-review.googlesource.com/c/1383333
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19659}
[add] https://crrev.com/4d175dbf07df6d4f29cc100e9955786ca0a5edca/recipes/recipes/cros_flash_scheduler.py
[modify] https://crrev.com/4d175dbf07df6d4f29cc100e9955786ca0a5edca/recipes/recipes/OWNERS
[modify] https://crrev.com/4d175dbf07df6d4f29cc100e9955786ca0a5edca/recipes/README.recipes.md
[add] https://crrev.com/4d175dbf07df6d4f29cc100e9955786ca0a5edca/recipes/recipes/cros_flash.py
[add] https://crrev.com/4d175dbf07df6d4f29cc100e9955786ca0a5edca/recipes/recipes/cros_flash_scheduler.expected/full_run.json

Comment 41 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc68d72f338b3405a1ae422cabc06cb1119df68

commit acc68d72f338b3405a1ae422cabc06cb1119df68
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Dec 20 00:49:10 2018

Create a different target for tast tests that run on devices.

There's a bot up that's running the tast test suite on kevin devices:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel-hw-tests

A few of them are perma-failing. This creates a new target which has them
disabled.

Bug: 866062
Change-Id: Ia715a164ae96bfbc2ee54d85482a25cdc216de96
Reviewed-on: https://chromium-review.googlesource.com/c/1382508
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618044}
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/build/chromeos/create_test_runner_script.py
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/build/chromeos/test_runner.py
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/build/config/chromeos/rules.gni
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/chromeos/BUILD.gn
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/acc68d72f338b3405a1ae422cabc06cb1119df68/tools/mb/mb_config.pyl

Comment 42 by bpastene@chromium.org, Jan 7

Blockedon: 919599

Comment 44 by bugdroid1@chromium.org, Jan 9

Project Member

Comment 45 by bugdroid1@chromium.org, Jan 9

Project Member

Comment 46 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/12df28eecf7991ebf61b0247cee9327a7ec3173e

commit 12df28eecf7991ebf61b0247cee9327a7ec3173e
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Jan 09 17:49:55 2019

Update the swarming pool for cros duts in the flash scheduler.

They moved pools in crrev.com/i/776069

Bug: 866062
Change-Id: I8c31dc9f4c48c9da94d3b225f24223a4e6b4f8a6
Reviewed-on: https://chromium-review.googlesource.com/c/1403260
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19861}
[modify] https://crrev.com/12df28eecf7991ebf61b0247cee9327a7ec3173e/infra/config/global/cr-buildbucket.cfg

Comment 47 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20be2531dc1e92d6528cf229c2282eb9e500a4b8

commit 20be2531dc1e92d6528cf229c2282eb9e500a4b8
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Jan 09 19:35:12 2019

Change swarming pool dimension for cros dut tests.

They moved pools in crrev.com/i/776069

Bug: 866062
Change-Id: Ib0be757e70781a2707ca7598c67c2bef4b7a2e53
Reviewed-on: https://chromium-review.googlesource.com/c/1403396
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621271}
[modify] https://crrev.com/20be2531dc1e92d6528cf229c2282eb9e500a4b8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/20be2531dc1e92d6528cf229c2282eb9e500a4b8/testing/buildbot/waterfalls.pyl

Comment 48 by bpastene@chromium.org, Jan 9

Blockedon: 920442

Comment 49 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3f776a44bf50decd7cf490b501ef372059df5e66

commit 3f776a44bf50decd7cf490b501ef372059df5e66
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Jan 10 20:44:02 2019

Update pool dim in cros dut flash builds.

R=jbudorick

Bug: 866062
Change-Id: I4d19b7582e31eaae3ae15e139042f7cf2392346e
Reviewed-on: https://chromium-review.googlesource.com/c/1405712
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19903}
[modify] https://crrev.com/3f776a44bf50decd7cf490b501ef372059df5e66/infra/config/global/cr-buildbucket.cfg

Comment 50 by bugdroid1@chromium.org, Jan 10

Project Member

Comment 51 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fb193f18d2083822d1eca54ab192873e6dc1233a

commit fb193f18d2083822d1eca54ab192873e6dc1233a
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Jan 10 23:34:57 2019

Allow cros-flash-scheduler-kevin to schedule other builders in its bucket.

The builder "cros-flash-scheduler-kevin" needs to trigger the builder
"cros-dut-flash" in its own bucket. But it doesn't currently have the ACLs
to do so:
https://logs.chromium.org/logs/infra/led/bpastene_google.com/7ad41caf71f9daf8b6455307cbee7f90257c62214adf6aeb1e0bcb34cbf66f80/+/steps/flash_bots/0/steps/build1-a1--build3-a1/0/stdout

This should fix that.

Bug: 866062
Change-Id: I8111e8330dad33e26685fafd036c51f9814b40e2
Reviewed-on: https://chromium-review.googlesource.com/c/1405620
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19912}
[modify] https://crrev.com/fb193f18d2083822d1eca54ab192873e6dc1233a/infra/config/global/cr-buildbucket.cfg

Comment 52 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1a09ce625cb1fbf3cd59825256e2267ab4ed02cb

commit 1a09ce625cb1fbf3cd59825256e2267ab4ed02cb
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 11 00:30:06 2019

Remove the default 'cpu:x86-64' for cros flash tasks.

The dut bots lack the cpu dim:
https://chromium-swarm.appspot.com/bot?id=build1-a1--build2-a1

But cpu:x86-64 is currently being requested:
https://chromium-swarm.appspot.com/task?id=42531124ccfb1010

This'll remove it.

Bug: 866062
Change-Id: If2abb1d8e353a24dc3c59f8869daf5095aed0e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1406023
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19915}
[modify] https://crrev.com/1a09ce625cb1fbf3cd59825256e2267ab4ed02cb/infra/config/global/cr-buildbucket.cfg

Comment 53 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/93d42aa64657596c60ba3f5169d7446922a6c02a

commit 93d42aa64657596c60ba3f5169d7446922a6c02a
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 11 01:30:06 2019

Fix the bucket name for the cros-flash-scheduler builder.

The buildbucket bucket of the builder != the swarming pool of its bots.

Bug: 866062
Change-Id: Ibfcae8e0507ade482fa049669d6214ad3abbd95e
Reviewed-on: https://chromium-review.googlesource.com/c/1405619
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19918}
[modify] https://crrev.com/93d42aa64657596c60ba3f5169d7446922a6c02a/recipes/recipes/cros_flash_scheduler.py
[modify] https://crrev.com/93d42aa64657596c60ba3f5169d7446922a6c02a/recipes/README.recipes.md
[modify] https://crrev.com/93d42aa64657596c60ba3f5169d7446922a6c02a/recipes/recipes/cros_flash_scheduler.expected/full_run.json

Comment 54 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/ad3c7c29310c43764adc2acfeeb755b772e1c02f

commit ad3c7c29310c43764adc2acfeeb755b772e1c02f
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 11 17:38:00 2019

Comment 55 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/143dd92117bab8931238c750fc7d0108c82c8f79

commit 143dd92117bab8931238c750fc7d0108c82c8f79
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 11 17:54:10 2019

Comment 56 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7e0d2e07239e8b96e21f7abcfd22a6cdc3c16b27

commit 7e0d2e07239e8b96e21f7abcfd22a6cdc3c16b27
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Jan 14 17:41:14 2019

Fix bucket and builder names when the cros flash scheduler retriggers itself.

Previously it was hardcoded, and incorrect:
https://luci-milo.appspot.com/p/infra/builders/luci.infra.cron/cros-flash-scheduler-kevin/b8924454891720260112

This changes it to use buildbucket's api, which should always be correct.

Bug: 866062
Change-Id: I8551c0f9e2b73a533556d7d36cedac1fd4624233
Reviewed-on: https://chromium-review.googlesource.com/c/1409742
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19961}
[modify] https://crrev.com/7e0d2e07239e8b96e21f7abcfd22a6cdc3c16b27/recipes/recipes/cros_flash_scheduler.py
[modify] https://crrev.com/7e0d2e07239e8b96e21f7abcfd22a6cdc3c16b27/recipes/recipes/cros_flash_scheduler.expected/full_run.json

Comment 57 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/35799788405cb60dfdccb5f550c09c768a7a91f3

commit 35799788405cb60dfdccb5f550c09c768a7a91f3
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Jan 15 01:45:58 2019

Clobber the stateful partition when flashing cros duts.

Sometimes that partition can get corrupted and cause the flash to fail:
https://luci-milo.appspot.com/swarming/task/426793f6ef033710

This should fix that.

Bug: 866062
Change-Id: Ie20865863d787eda3780478224903de5d8f678f9
Reviewed-on: https://chromium-review.googlesource.com/c/1410306
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19976}
[modify] https://crrev.com/35799788405cb60dfdccb5f550c09c768a7a91f3/recipes/recipes/cros_flash.py

Comment 58 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/372401ae002b1f712c9cb1ca7fa1e1dacdd50fe6

commit 372401ae002b1f712c9cb1ca7fa1e1dacdd50fe6
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Jan 15 02:04:56 2019

Change a cros_docker container's ssh config to disable host key checking.

It's actually already disabled; this'll just move the host key file
from an actual file to /dev/null. Previously it would store the file
in /b/known_hosts and complain when it changed (which it does after
every update).

Bug: 866062
Change-Id: I9a4d9cbc52051d62a4e88d255a5a1c1bef3d1427
Reviewed-on: https://chromium-review.googlesource.com/c/1410133
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19977}
[modify] https://crrev.com/372401ae002b1f712c9cb1ca7fa1e1dacdd50fe6/infra/services/cros_docker/host.py

Comment 59 by bpastene@chromium.org, Jan 15

Blocking: 922137

Comment 60 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/f5524977da03a2ee18723b2959ace940c07051f8

commit f5524977da03a2ee18723b2959ace940c07051f8
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Jan 15 20:17:21 2019

Comment 61 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3955a7cf4d9ede4e48b29491726d73536f1318a0

commit 3955a7cf4d9ede4e48b29491726d73536f1318a0
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Jan 15 22:39:12 2019

Clear devserver cache from cros dut bots when flashing.

Otherwise cros images will pile up there. This should save some disk space.

R=jbudorick

Bug: 866062
Change-Id: Ie6459e2096d47006fc07b94d3527acf1f6c2e02f
Reviewed-on: https://chromium-review.googlesource.com/c/1413432
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20000}
[modify] https://crrev.com/3955a7cf4d9ede4e48b29491726d73536f1318a0/recipes/recipes/cros_flash.py

Comment 62 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9e583b977bcd04b37706718766e526f17713690

commit a9e583b977bcd04b37706718766e526f17713690
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Jan 16 02:57:26 2019

Add a swarming test trigger script for ChromeOS hardware tests.

It's a pretty lightweight script that simply adds the contents of the
//chromeos/CHROMEOS_LKGM file as a task dimension via the
"--optional-dimension" arg.

Bug: 866062
Change-Id: I550fc9abe1674a96bcd7d00f209c07e48c7dc252
Reviewed-on: https://chromium-review.googlesource.com/c/1405455
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623073}
[modify] https://crrev.com/a9e583b977bcd04b37706718766e526f17713690/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a9e583b977bcd04b37706718766e526f17713690/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/a9e583b977bcd04b37706718766e526f17713690/testing/buildbot/generate_buildbot_json_unittest.py
[modify] https://crrev.com/a9e583b977bcd04b37706718766e526f17713690/testing/buildbot/waterfalls.pyl
[add] https://crrev.com/a9e583b977bcd04b37706718766e526f17713690/testing/trigger_scripts/chromeos_device_trigger.py

Comment 63 by bugdroid1@chromium.org, Jan 16

Project Member

Comment 64 by crouleau@chromium.org, Jan 23

Blocking: 772181

Comment 65 by bugdroid, Jan 24

Project Member

Comment 66 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd09c424fb6bbc07739df7fdd1005a35f6f08f5d

commit bd09c424fb6bbc07739df7fdd1005a35f6f08f5d
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Jan 24 22:08:54 2019

Disable NetworkListenersARC and WebRTCPeerConnCameraVP8 on chromeos-kevin-rel tester.

Looks like they're the only remaining tast test that fails:
https://chromium-swarm.appspot.com/task?id=429a15ecadd81410

Bug: 916367, 866062
Change-Id: If1368f981f788f99def300c50e2539fffc783e48
Reviewed-on: https://chromium-review.googlesource.com/c/1434795
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625835}

Comment 68 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e12d0be456347e96579b57489a6b9ad19264e072

commit e12d0be456347e96579b57489a6b9ad19264e072
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 25 18:34:15 2019

When flashing cros duts, pin the local cros checkout at a release branch.

I've spent the entire day trying to figure out why last night's flashing
sweep all failed:
https://luci-milo.appspot.com/b/8923458325440330880

Turns out the cros flash code is broken at head:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-dev/Nys_sGO8ves

This will checkout the flashing code at a known good branch instead of at
head.

Needs https://chromium-review.googlesource.com/c/chromium/tools/build/+/1435489
before this can land.

Bug: 866062
Change-Id: Ib5d69ca1aa66ce2d180327f07217e42f71cd71dc
Reviewed-on: https://chromium-review.googlesource.com/c/1435587
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20218}
[modify] https://crrev.com/e12d0be456347e96579b57489a6b9ad19264e072/recipes/recipes/cros_flash.py

Comment 69 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1f3bbc5eccc98ace324b1c12261d5393a9b62f3

commit a1f3bbc5eccc98ace324b1c12261d5393a9b62f3
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Jan 25 20:50:13 2019

Add telemetry(_perf)_unittests to the cros device test bot.

Bug: 866062
Change-Id: Ib611fae1f944b2674531ba064f19810fc40dd381
Reviewed-on: https://chromium-review.googlesource.com/c/1417114
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626187}

Comment 70 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/71999686efa2c8f626344d27c997caa43ddbaef6

commit 71999686efa2c8f626344d27c997caa43ddbaef6
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Jan 29 17:15:21 2019

Make failures to fetch a cros checkout non-fatal in a the dut flasher.

And also decrease j's and only fetch the current branch.

Sometimes the bots exceed their individual gerrit quota during checkout:
https://ci.chromium.org/p/infra/builders/luci.infra.cron/cros-dut-flash/b8923092995525790384

This should make that occur less frequently, and not fail when it does.

Bug: 866062
Change-Id: If7634268cb85e7acef6ff22b9ecf497e4d66d1a4
Reviewed-on: https://chromium-review.googlesource.com/c/1443512
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20289}
[modify] https://crrev.com/71999686efa2c8f626344d27c997caa43ddbaef6/recipes/recipes/cros_flash.py

Comment 71 by bugdroid, Jan 30

Project Member

Comment 72 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fea93ffbb7e61e962de55de9ab1ccef3ebf69a1

commit 7fea93ffbb7e61e962de55de9ab1ccef3ebf69a1
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Feb 11 21:39:39 2019

Add chromeos-kevin-compile-rel to all //chromeos/CHROMEOS_LKGM changes.

This will ensure an sdk exists for kevin when the lkgm gets rolled.

Note that the chromeos-kevin-rel bot also runs tests, but the OS of the
devices on that bot get updated separately. So using that trybot for
lkgm rolls would end up having test compiled at the newer lkgm version,
but running on devices on the older lkgm version.

So we'll just use the compile-only version of the bot for now.

Bug: 866062,  926874 
Change-Id: I7c3c8641c012e1a8a75d642cda66bade275961ee
Reviewed-on: https://chromium-review.googlesource.com/c/1450308
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630940}
[modify] https://crrev.com/7fea93ffbb7e61e962de55de9ab1ccef3ebf69a1/docs/infra/cq_builders.md
[modify] https://crrev.com/7fea93ffbb7e61e962de55de9ab1ccef3ebf69a1/infra/config/global/commit-queue.cfg

Comment 73 by bugdroid, Feb 15 (3 days ago)

Project Member

Comment 74 by bugdroid, Feb 16 (3 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4104178b90a40dedea65d89964844116ed470a06

commit 4104178b90a40dedea65d89964844116ed470a06
Author: Ben Pastene <bpastene@chromium.org>
Date: Sat Feb 16 04:21:58 2019

Add the device_status dimension to all triggered CrOS device tests.

This will ensure the tests only run on bots with healthy devices. Note
that we're not using a bot's quarantining method to do so since we also
want tasks that can heal an unhealthy device to still run.

Bug: 866062
Change-Id: Ieac1b8f5e58c2c49813952d039337dbfba20373c
Reviewed-on: https://chromium-review.googlesource.com/c/1474287
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632906}
[modify] https://crrev.com/4104178b90a40dedea65d89964844116ed470a06/testing/test.gni
[modify] https://crrev.com/4104178b90a40dedea65d89964844116ed470a06/testing/trigger_scripts/chromeos_device_trigger.py

Sign in to add a comment