Marking as untriaged so an engineer will get assigned to this.

Both on my machine and in the screenshot, it looks like the shadow is present, but hard to see.

That doesn't surprise me because both the shadow color as we've defined it is slightly LIGHTER in color than the background.

Alan - do you have further guidance in how you do want the shadow to look on top of a dark background?

My suggestion would be to use the same opacity/blur/spread values, but change the color to #000000 instead of GG800 (#3C4043). That should make this more visible. 

+1 to c7. Or G900 given its our new "black". Maybe screenshots of both on the incognito interstitial and on top of a white page

Implementation notes: Here is where the shadow values are created for the Omnibox:

https://cs.chromium.org/chromium/src/ui/gfx/shadow_value.cc?q=shadow_value.cc&sq=package:chromium&g=0&l=94-100

Further up the stack, it's created here:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc?q=rounded_omnibox&sq=package:chromium&g=0&l=139-144

Somehow we need to plumb down an is_incognito flag... or the color, to make it look right on Incognito mode.

Per offline conversation this morning, Manuk is going to take a look at this.

attached r some samples of what it would look like with g900, #000, and #fff; imo, g900 is difficult to detect.

Deleted: g900.png 65.0 KB

	g900.png 65.0 KB View Download

Deleted: #000.png 67.1 KB

	#000.png 67.1 KB View Download

Deleted: #fff.png 57.4 KB

	#fff.png 57.4 KB View Download

1 more screenshot for #000 on a light page

Deleted: #000 on google.com.png 48.9 KB

	#000 on google.com.png 48.9 KB View Download

will merge to master, but not milestone 69 (unless someone thinks it should be merged to 69?) as it's only a slight color adjustment + graphical changes r hard to test all edge cases

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ac8cbbdefe065f651a9a832f011c7f8eed709a

commit 65ac8cbbdefe065f651a9a832f011c7f8eed709a
Author: manuk <manukh@chromium.org>
Date: Thu Aug 09 21:31:28 2018

Omnibox: Change results popup shadow color for incognito.

Previously, the results popup shadow color was kGoogleGrey800 (#3C4043) for both
incognito and normal windows. This shadow was difficult to detect on incognito's
dark new tab page. This changes the shadow color for incognito windows to black
(#000). This change only affects material refresh.

The results popup uses BubbleBorder to draw its border, including its shadow.
BubbleBorder can be provided a shadow elevation to determine the size of its
shadow, or else it will provide a default shadow. Additionally, BubbleBorder
shadows consider the material refresh flag. Elevated refresh shadows (e.g.
refresh flag is on and elevation is 3 or 16) are delegated to
ShadowValue::MakeRefreshShadowValues. Elevated non-refresh shadows (e.g. refresh
flag is off or elevation is neither 3 nor 16) are delegated to
ShadowValue::MakeMdShadowValues. Un-elevated shadows are constructed inline
within BubbleBorder::GetShadowValues.

Previously, ShadowValue::MakeRefreshShadowValues shadows were kGoogleGrey800,
while ShadowValue::MakeMdShadowValues and BubbleBorder::GetShadowValues shadows
were SK_ColorBLACK. This cl adds the ability to set custom shadow colors for all
3 shadow constructions. If no color is set, SK_ColorBLACK is used by default,
this is consistent with all current usages of ShadowValue and BubbleBorder.

Bug:  866054 
Change-Id: I6d592f290daf41a6a083e7e6214c0a30dfdfb68f
Reviewed-on: https://chromium-review.googlesource.com/1165794
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581895}
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/chrome/browser/ui/views/harmony/material_refresh_layout_provider.h
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/gfx/shadow_value.cc
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/gfx/shadow_value.h
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/views/bubble/bubble_border.h
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/65ac8cbbdefe065f651a9a832f011c7f8eed709a/ui/views/layout/layout_provider.h