New issue
Advanced search Search tips

Issue 866052 link

Starred by 1 user
Status: Fixed
Owner:
mar...@chromium.org
Closed: Nov 20
Cc:
vadimsh@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Swarming: remove forbid_unknown_pools by setting it to true everywhere

Project Member Reported by mar...@chromium.org, Jul 20 
This will help further lock down the fleets.

AI:
1. Set it to true in the config to all swarming instances.
  1a. Fix pools.cfg as needed.
2. Change the server to ignore the condition on this value, always enforcing it.
3. Remove the value from all configs.
4. Remove forbid_unknown_pools from the proto.

Ref: https://cs.chromium.org/chromium/infra/luci/appengine/swarming/proto/pools.proto

The most important part is #1, the rest is less important, since the gain is in the first step.

Comment 1 by mar...@chromium.org, Jul 20

Labels: -Pri-3 Pri-2
One additional reason for doing this is to have a pools.cfg, as this is needed for issue 864724 and issue 864722.

Technically a nearly empty pools.cfg would do, but that would be confusing.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/32798c50577f215d32a832b2152096ee5b5bcbfa

commit 32798c50577f215d32a832b2152096ee5b5bcbfa
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Jul 23 19:29:58 2018
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/139a98c0026bac1d3c1dc76e6258548ef73a447f

commit 139a98c0026bac1d3c1dc76e6258548ef73a447f
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Jul 24 17:07:12 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/0e964f2484612e44b1cac7b45ee874de1a971302

commit 0e964f2484612e44b1cac7b45ee874de1a971302
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Jul 24 20:37:52 2018
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c9e675b2a840810fd1872cdc151748cf1423ca83

commit c9e675b2a840810fd1872cdc151748cf1423ca83
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Thu Jul 26 19:00:44 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/6c427c2a1ef1c9a0020eda4d1f52d246909dfd2c

commit 6c427c2a1ef1c9a0020eda4d1f52d246909dfd2c
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Jul 27 18:19:36 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/40a53d8ff04c36e25f9fc5fec8f9de960f69df34

commit 40a53d8ff04c36e25f9fc5fec8f9de960f69df34
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed Aug 01 22:05:50 2018
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e9315e3a273d73b89ea2df37310b4e02bf88689d

commit e9315e3a273d73b89ea2df37310b4e02bf88689d
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Aug 14 18:06:39 2018
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e8eaf444c801cab6d3f7fa3ce9de290e06e82f61

commit e8eaf444c801cab6d3f7fa3ce9de290e06e82f61
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Aug 14 18:13:09 2018
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/22bfef694d5accac5f574e0dc974bb7cd9750e07

commit 22bfef694d5accac5f574e0dc974bb7cd9750e07
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Aug 14 21:12:59 2018

[swarming] Ignore forbid_unknown_pools and enforce True

This effectively requires a pools.cfg going forward. This required
updating the unit tests accordingly.

Since the bot has no default access to trigger tasks, and that many unit tests
didn't define a pool, that required a fair amount of unit test overhaul.

Bug:  866052 
Change-Id: I950d8b3605bdff6d155e8e405e3d0e72be0ecd12
Reviewed-on: https://chromium-review.googlesource.com/1174939
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/doc/Access-Groups.md
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/handlers_bot_test.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/handlers_endpoints_test.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/handlers_test.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/local_smoke_test.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/main.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/proto/pools.proto
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/server/pools_config.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/server/pools_config_test.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/server/task_scheduler.py
[modify] https://crrev.com/22bfef694d5accac5f574e0dc974bb7cd9750e07/appengine/swarming/server/task_scheduler_test.py
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/75d2c3b43d86be91c8a8b6a9bd4c64b49bc37fb1

commit 75d2c3b43d86be91c8a8b6a9bd4c64b49bc37fb1
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Thu Sep 06 19:09:52 2018
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/3807521dd6dd9bf389453e74f483f68eccbfa7be

commit 3807521dd6dd9bf389453e74f483f68eccbfa7be
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Nov 20 17:20:53 2018

[swarming] Remove forbid_unknown_pools

It was ignored and enforced as true.

No config has been using it for a while.

Rebuilt with protobuf 3.6.1.

R=qyearsley@chromium.org

Bug:  866052 
Change-Id: Id8afa01607873bdfb1ad3deac2bda60738c28cc2
Reviewed-on: https://chromium-review.googlesource.com/c/1343305
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/3807521dd6dd9bf389453e74f483f68eccbfa7be/appengine/swarming/proto/plugin_prpc_pb2.py
[modify] https://crrev.com/3807521dd6dd9bf389453e74f483f68eccbfa7be/appengine/swarming/proto/pools.proto
[modify] https://crrev.com/3807521dd6dd9bf389453e74f483f68eccbfa7be/appengine/swarming/proto/pools_pb2.py

Comment 13 by mar...@chromium.org, Nov 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment