[BlinkGenPropertyTrees] Implement overscroll-behavior |
|||
Issue descriptionvirtual/threaded/fast/scroll-behavior/overscroll-behavior.html fails with blink gen property trees. This can be run with: third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees virtual/threaded/fast/scroll-behavior/overscroll-behavior.html The failure is: FAIL overscroll-behavior-y: none should only prevent scroll propagation on y axis with: wheel. assert_equals: expected 100 but got 0 FAIL overscroll-behavior-x: none should only prevent scroll propagation on x axis with: wheel. assert_equals: expected 100 but got 0 PASS overscroll-behavior should not affect scrolling inside the applied container with: wheel. PASS overscroll-behavior on non-scrollable area should not affect scroll propagation with: wheel. FAIL overscroll-behavior-y: none should only prevent scroll propagation on y axis with: touch. assert_equals: expected 100 but got 0 FAIL overscroll-behavior-x: none should only prevent scroll propagation on x axis with: touch. assert_equals: expected 100 but got 0 PASS overscroll-behavior on non-scrollable area should not affect scroll propagation with: touch.
,
Aug 24
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1b5081ffe2854258568e10ad671ba835ed75808 commit e1b5081ffe2854258568e10ad671ba835ed75808 Author: David Bokan <bokan@chromium.org> Date: Tue Aug 28 15:14:00 2018 [BlinkGenPropertyTrees] Implement overscroll-behavior The CSS overscroll-behavior feature controls whether scrolling should continue to propagate up to the parent scroller. This CL adds the necessary plumbing to set the correct values on the CC ScrollNodes when Blink is responsible for creating the property trees (i.e. with --enable-blink-gen-property-trees is used). TEST=virtual/threaded/fast/scroll-behavior/overscroll-behavior.html Bug: 866051 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I55938ec5801083e3cdcbf1e3d2da1cb7791d2c43 Reviewed-on: https://chromium-review.googlesource.com/1188647 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586707} [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/cc/layers/layer.h [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/core/layout/layout_box.cc [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/core/page/scrolling/overscroll_controller.cc [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc [modify] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h [add] https://crrev.com/e1b5081ffe2854258568e10ad671ba835ed75808/third_party/blink/renderer/platform/scroll/overscroll_behavior.h
,
Aug 28
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e417c15c5deb96238bdc8aef346a088262263f commit 64e417c15c5deb96238bdc8aef346a088262263f Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Tue Aug 28 23:11:24 2018 [jumbo] disambiguate ToString in scroll_paint_property_node.cc https://chromium-review.googlesource.com/1188647 added a ToString function in the anonymous namespace, but then called blink::ToString which resolved to another blink::ToString in jumbo builds. Let's give this ToString a unique name. Bug: 866051 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12eace7cb0a47b995a52b7acffe76e988bb15417 Reviewed-on: https://chromium-review.googlesource.com/1193854 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#586917} [modify] https://crrev.com/64e417c15c5deb96238bdc8aef346a088262263f/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bokan@chromium.org
, Aug 24Owner: bokan@chromium.org
Status: Assigned (was: Available)
Summary: [BlinkGenPropertyTrees] Implement overscroll-behavior (was: [BlinkGenPropertyTrees] virtual/threaded/fast/scroll-behavior/overscroll-behavior.html fails)