New issue
Advanced search Search tips

Issue 866043 link

Starred by 1 user
Status: Fixed
Owner:
dcheng@chromium.org
Closed: Jul 22
Cc:
jdoerrie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Static spans shouldn't need a size_ field

Project Member Reported by dcheng@chromium.org, Jul 20 
Static spans are static. We should be able to specialize on whether or not its a dynamic extent to select whether or not we need storage for the size.

Comment 1 by dcheng@chromium.org, Jul 21

Cc: jdoerrie@chromium.org
Owner: dcheng@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3b1a962e3eda00c51f359e59aa97ed4808bbae

commit 3a3b1a962e3eda00c51f359e59aa97ed4808bbae
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jul 21 23:15:43 2018

base::span: don't allocate storage for size_ with static extents

If the extent is static, there's no need to store the size in a field:
the size is already contained in the type.

Bug:  866043 
Change-Id: I5456e54055d76eb88f20bd8da257be3e2a5941d6
Reviewed-on: https://chromium-review.googlesource.com/1145959
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577085}
[modify] https://crrev.com/3a3b1a962e3eda00c51f359e59aa97ed4808bbae/base/containers/span.h

Comment 3 by dcheng@chromium.org, Jul 22

Status: Fixed (was: Started)
►

Sign in to add a comment